From: Linus Walleij <linus.walleij@linaro.org>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, grant.likely@secretlab.ca,
rob.herring@calxeda.com, kgene.kim@samsung.com,
patches@linaro.org
Subject: Re: [PATCH v2 2/4] pinctrl: add exynos4210 specific extensions for samsung pinctrl driver
Date: Tue, 21 Aug 2012 14:02:18 +0200 [thread overview]
Message-ID: <CACRpkdYiJOkHrjZ22_0onRHc0ApmBLj+tXPa4SrPo2h0d=fJHA@mail.gmail.com> (raw)
In-Reply-To: <1345060656-32201-3-git-send-email-thomas.abraham@linaro.org>
On Wed, Aug 15, 2012 at 9:57 PM, Thomas Abraham
<thomas.abraham@linaro.org> wrote:
> Add information about the Exynos4210 pin banks and driver data which is
> used by the Samsung pinctrl driver. In addition to this, the support for
> external gpio and wakeup interrupt support is included and hooked up with
> the Samsung pinctrl driver.
OK...
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> +config PINCTRL_EXYNOS4
> + bool "Pinctrl driver data for Exynos4 SoC"
> + depends on ARCH_EXYNOS4 && OF
Since you depend on PINCTRL_SAMSUNG which depends
on OF you don't need to depend on OF here.
> + depends on PINCTRL_SAMSUNG
> + select PINMUX
> + select PINCONF
So as noted in the main driver, let PINCTRL_SAMSUNG
select PINMUX and PINCONF and you need only select
PINCTRL_SAMSUNG here.
> diff --git a/drivers/pinctrl/pinctrl-exynos.c b/drivers/pinctrl/pinctrl-exynos.c
(...)
> +#include <linux/interrupt.h>
> +#include <linux/irqdomain.h>
> +#include <linux/irq.h>
> +#include <linux/of_irq.h>
Do you need these includes? Didn't you put them
all in "pinctrl-samsung.h"?
Overall this looks good and straight-forward, but I cannot figure
out how the samsung_pinctrl_soc_data is passed to the main
driver, it seems to be through some DT node but I cannot figure
this out. Can you explain this?
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] pinctrl: add exynos4210 specific extensions for samsung pinctrl driver
Date: Tue, 21 Aug 2012 14:02:18 +0200 [thread overview]
Message-ID: <CACRpkdYiJOkHrjZ22_0onRHc0ApmBLj+tXPa4SrPo2h0d=fJHA@mail.gmail.com> (raw)
In-Reply-To: <1345060656-32201-3-git-send-email-thomas.abraham@linaro.org>
On Wed, Aug 15, 2012 at 9:57 PM, Thomas Abraham
<thomas.abraham@linaro.org> wrote:
> Add information about the Exynos4210 pin banks and driver data which is
> used by the Samsung pinctrl driver. In addition to this, the support for
> external gpio and wakeup interrupt support is included and hooked up with
> the Samsung pinctrl driver.
OK...
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> +config PINCTRL_EXYNOS4
> + bool "Pinctrl driver data for Exynos4 SoC"
> + depends on ARCH_EXYNOS4 && OF
Since you depend on PINCTRL_SAMSUNG which depends
on OF you don't need to depend on OF here.
> + depends on PINCTRL_SAMSUNG
> + select PINMUX
> + select PINCONF
So as noted in the main driver, let PINCTRL_SAMSUNG
select PINMUX and PINCONF and you need only select
PINCTRL_SAMSUNG here.
> diff --git a/drivers/pinctrl/pinctrl-exynos.c b/drivers/pinctrl/pinctrl-exynos.c
(...)
> +#include <linux/interrupt.h>
> +#include <linux/irqdomain.h>
> +#include <linux/irq.h>
> +#include <linux/of_irq.h>
Do you need these includes? Didn't you put them
all in "pinctrl-samsung.h"?
Overall this looks good and straight-forward, but I cannot figure
out how the samsung_pinctrl_soc_data is passed to the main
driver, it seems to be through some DT node but I cannot figure
this out. Can you explain this?
Yours,
Linus Walleij
next prev parent reply other threads:[~2012-08-21 12:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 19:57 [PATCH v2 0/4] pinctrl: add support for samsung pinctrl driver Thomas Abraham
2012-08-15 19:57 ` Thomas Abraham
2012-08-15 19:57 ` [PATCH v2 1/4] pinctrl: add samsung pinctrl and gpiolib driver Thomas Abraham
2012-08-15 19:57 ` Thomas Abraham
2012-08-21 11:25 ` Linus Walleij
2012-08-21 11:25 ` Linus Walleij
2012-08-21 21:38 ` Stephen Warren
2012-08-21 21:38 ` Stephen Warren
2012-08-22 5:00 ` Thomas Abraham
2012-08-22 5:00 ` Thomas Abraham
2012-08-22 4:22 ` Thomas Abraham
2012-08-22 4:22 ` Thomas Abraham
2012-08-22 4:22 ` Thomas Abraham
2012-08-27 23:22 ` Linus Walleij
2012-08-27 23:22 ` Linus Walleij
2012-08-28 5:25 ` Thomas Abraham
2012-08-28 5:25 ` Thomas Abraham
2012-08-15 19:57 ` [PATCH v2 2/4] pinctrl: add exynos4210 specific extensions for samsung pinctrl driver Thomas Abraham
2012-08-15 19:57 ` Thomas Abraham
2012-08-15 19:57 ` Thomas Abraham
2012-08-21 12:02 ` Linus Walleij [this message]
2012-08-21 12:02 ` Linus Walleij
2012-08-22 4:37 ` Thomas Abraham
2012-08-22 4:37 ` Thomas Abraham
2012-08-15 19:57 ` [PATCH v2 3/4] gpio: exynos4: skip gpiolib registration if pinctrl driver is used Thomas Abraham
2012-08-15 19:57 ` Thomas Abraham
2012-08-21 12:05 ` Linus Walleij
2012-08-21 12:05 ` Linus Walleij
2012-08-22 4:38 ` Thomas Abraham
2012-08-22 4:38 ` Thomas Abraham
2012-08-15 19:57 ` [PATCH v2 4/4] ARM: EXYNOS: skip wakeup interrupt setup " Thomas Abraham
2012-08-15 19:57 ` Thomas Abraham
2012-08-21 12:04 ` Linus Walleij
2012-08-21 12:04 ` Linus Walleij
2012-08-22 4:39 ` Thomas Abraham
2012-08-22 4:39 ` Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYiJOkHrjZ22_0onRHc0ApmBLj+tXPa4SrPo2h0d=fJHA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=grant.likely@secretlab.ca \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rob.herring@calxeda.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.