All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Biju Das <biju.das@bp.renesas.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	Li Jun <jun.li@nxp.com>,
	Badhri Jagan Sridharan <badhri@google.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Min Guo <min.guo@mediatek.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-usb <linux-usb@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v8 00/11] add USB GPIO based connection detection driver
Date: Tue, 6 Aug 2019 15:26:50 +0200	[thread overview]
Message-ID: <CACRpkdZ8LjG22QCA0tB+vMi7fPJNBiX-sL1+t0yZqcfRjMJF7Q@mail.gmail.com> (raw)
In-Reply-To: <1565077710.23705.21.camel@mhfsdcap03>

On Tue, Aug 6, 2019 at 9:48 AM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
> On Mon, 2019-08-05 at 12:06 +0200, Linus Walleij wrote:
> > On Wed, Jul 24, 2019 at 10:51 AM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:

> > But for just "hey I'm plugged in" we can surely keep this
> > ID on GPIO detection in the USB subsystem.
>
> Sorry, you mean provide a common API? could you please describe more
> clearer about your suggestion?

Sorry I am not suggesting anything, this code is fine.

But:

> > I just get a bit insecure about how we should ideally
> > handle these "funny-PHY's".

I am more thinking about which subsystem these things really
belong in. But let's keep it like this for the simple GPIO case.
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Biju Das <biju.das@bp.renesas.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	Li Jun <jun.li@nxp.com>,
	Badhri Jagan Sridharan <badhri@google.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Min Guo <min.guo@mediatek.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-usb <linux-usb@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	moderated list:ARM/Mediatek So
Subject: Re: [PATCH v8 00/11] add USB GPIO based connection detection driver
Date: Tue, 6 Aug 2019 15:26:50 +0200	[thread overview]
Message-ID: <CACRpkdZ8LjG22QCA0tB+vMi7fPJNBiX-sL1+t0yZqcfRjMJF7Q@mail.gmail.com> (raw)
In-Reply-To: <1565077710.23705.21.camel@mhfsdcap03>

On Tue, Aug 6, 2019 at 9:48 AM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
> On Mon, 2019-08-05 at 12:06 +0200, Linus Walleij wrote:
> > On Wed, Jul 24, 2019 at 10:51 AM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:

> > But for just "hey I'm plugged in" we can surely keep this
> > ID on GPIO detection in the USB subsystem.
>
> Sorry, you mean provide a common API? could you please describe more
> clearer about your suggestion?

Sorry I am not suggesting anything, this code is fine.

But:

> > I just get a bit insecure about how we should ideally
> > handle these "funny-PHY's".

I am more thinking about which subsystem these things really
belong in. But let's keep it like this for the simple GPIO case.
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Biju Das <biju.das@bp.renesas.com>,
	Badhri Jagan Sridharan <badhri@google.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	Min Guo <min.guo@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Li Jun <jun.li@nxp.com>
Subject: Re: [PATCH v8 00/11] add USB GPIO based connection detection driver
Date: Tue, 6 Aug 2019 15:26:50 +0200	[thread overview]
Message-ID: <CACRpkdZ8LjG22QCA0tB+vMi7fPJNBiX-sL1+t0yZqcfRjMJF7Q@mail.gmail.com> (raw)
In-Reply-To: <1565077710.23705.21.camel@mhfsdcap03>

On Tue, Aug 6, 2019 at 9:48 AM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
> On Mon, 2019-08-05 at 12:06 +0200, Linus Walleij wrote:
> > On Wed, Jul 24, 2019 at 10:51 AM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:

> > But for just "hey I'm plugged in" we can surely keep this
> > ID on GPIO detection in the USB subsystem.
>
> Sorry, you mean provide a common API? could you please describe more
> clearer about your suggestion?

Sorry I am not suggesting anything, this code is fine.

But:

> > I just get a bit insecure about how we should ideally
> > handle these "funny-PHY's".

I am more thinking about which subsystem these things really
belong in. But let's keep it like this for the simple GPIO case.
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-08-06 13:27 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-24  8:50 [PATCH v8 00/11] add USB GPIO based connection detection driver Chunfeng Yun
2019-07-24  8:50 ` Chunfeng Yun
2019-07-24  8:50 ` Chunfeng Yun
2019-07-24  8:50 ` [PATCH v8 01/11] dt-binding: usb: add usb-role-switch property Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-07-24  8:50 ` [PATCH v8 02/11] dt-bindings: connector: add optional properties for Type-B Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-08-05 10:09   ` Linus Walleij
2019-08-05 10:09     ` Linus Walleij
2019-08-05 10:09     ` Linus Walleij
2019-07-24  8:50 ` [PATCH v8 03/11] dt-bindings: usb: add binding for USB GPIO based connection detection driver Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-08-05 10:08   ` Linus Walleij
2019-08-05 10:08     ` Linus Walleij
2019-08-05 10:08     ` Linus Walleij
2019-07-24  8:50 ` [PATCH v8 04/11] dt-bindings: usb: mtu3: add properties about USB Role Switch Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-07-24  8:50 ` [PATCH v8 05/11] usb: roles: Introduce stubs for the exiting functions in role.h Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-07-24  8:50 ` [PATCH v8 06/11] device connection: Add fwnode_connection_find_match() Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-07-24  8:50 ` [PATCH v8 07/11] usb: roles: Add fwnode_usb_role_switch_get() function Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-07-24  8:50 ` [PATCH v8 08/11] usb: roles: get usb-role-switch from parent Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-07-29 14:25   ` Heikki Krogerus
2019-07-29 14:25     ` Heikki Krogerus
2019-07-31  6:29     ` Chunfeng Yun
2019-07-31  6:29       ` Chunfeng Yun
2019-07-31  6:29       ` Chunfeng Yun
2019-07-24  8:50 ` [PATCH v8 09/11] usb: common: create Kconfig file Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-07-24  8:50 ` [PATCH v8 10/11] usb: common: add USB GPIO based connection detection driver Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-08-05 10:10   ` Linus Walleij
2019-08-05 10:10     ` Linus Walleij
2019-08-05 10:10     ` Linus Walleij
2019-07-24  8:50 ` [PATCH v8 11/11] usb: mtu3: register a USB Role Switch for dual role mode Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-07-24  8:50   ` Chunfeng Yun
2019-08-05 10:06 ` [PATCH v8 00/11] add USB GPIO based connection detection driver Linus Walleij
2019-08-05 10:06   ` Linus Walleij
2019-08-05 10:06   ` Linus Walleij
2019-08-06  7:48   ` Chunfeng Yun
2019-08-06  7:48     ` Chunfeng Yun
2019-08-06  7:48     ` Chunfeng Yun
2019-08-06 13:26     ` Linus Walleij [this message]
2019-08-06 13:26       ` Linus Walleij
2019-08-06 13:26       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdZ8LjG22QCA0tB+vMi7fPJNBiX-sL1+t0yZqcfRjMJF7Q@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=Adam.Thomson.Opensource@diasemi.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=badhri@google.com \
    --cc=biju.das@bp.renesas.com \
    --cc=chunfeng.yun@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jun.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=min.guo@mediatek.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.