All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org,
	Hans Ulli Kroll <ulli.kroll@googlemail.com>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	LABBE Corentin <clabbe.montjoie@gmail.com>
Subject: Re: [PATCH net-next] net: gemini: allow any RGMII interface mode
Date: Tue, 4 Jan 2022 17:48:58 +0100	[thread overview]
Message-ID: <CACRpkdZCACEHEFq93CHvr4E+xMFa3YHUVcJXt=Uc1THZ8_3psQ@mail.gmail.com> (raw)
In-Reply-To: <E1n4mpT-002PLd-Ha@rmk-PC.armlinux.org.uk>

On Tue, Jan 4, 2022 at 5:38 PM Russell King (Oracle)
<rmk+kernel@armlinux.org.uk> wrote:

> The four RGMII interface modes take care of the required RGMII delay
> configuration at the PHY and should not be limited by the network MAC
> driver. Sadly, gemini was only permitting RGMII mode with no delays,
> which would require the required delay to be inserted via PCB tracking
> or by the MAC.
>
> However, there are designs that require the PHY to add the delay, which
> is impossible without Gemini permitting the other three PHY interface
> modes. Fix the driver to allow these.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Excellent root-cause analysis of this and thanks!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	 "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org,
	 Hans Ulli Kroll <ulli.kroll@googlemail.com>,
	Jakub Kicinski <kuba@kernel.org>,
	 linux-arm-kernel@lists.infradead.org,
	 LABBE Corentin <clabbe.montjoie@gmail.com>
Subject: Re: [PATCH net-next] net: gemini: allow any RGMII interface mode
Date: Tue, 4 Jan 2022 17:48:58 +0100	[thread overview]
Message-ID: <CACRpkdZCACEHEFq93CHvr4E+xMFa3YHUVcJXt=Uc1THZ8_3psQ@mail.gmail.com> (raw)
In-Reply-To: <E1n4mpT-002PLd-Ha@rmk-PC.armlinux.org.uk>

On Tue, Jan 4, 2022 at 5:38 PM Russell King (Oracle)
<rmk+kernel@armlinux.org.uk> wrote:

> The four RGMII interface modes take care of the required RGMII delay
> configuration at the PHY and should not be limited by the network MAC
> driver. Sadly, gemini was only permitting RGMII mode with no delays,
> which would require the required delay to be inserted via PCB tracking
> or by the MAC.
>
> However, there are designs that require the PHY to add the delay, which
> is impossible without Gemini permitting the other three PHY interface
> modes. Fix the driver to allow these.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Excellent root-cause analysis of this and thanks!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-01-04 16:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04 16:38 [PATCH net-next] net: gemini: allow any RGMII interface mode Russell King (Oracle)
2022-01-04 16:38 ` Russell King (Oracle)
2022-01-04 16:48 ` Linus Walleij [this message]
2022-01-04 16:48   ` Linus Walleij
2022-01-04 19:53 ` Corentin Labbe
2022-01-04 19:53   ` Corentin Labbe
2022-01-05 18:40 ` patchwork-bot+netdevbpf
2022-01-05 18:40   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdZCACEHEFq93CHvr4E+xMFa3YHUVcJXt=Uc1THZ8_3psQ@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=andrew@lunn.ch \
    --cc=clabbe.montjoie@gmail.com \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=ulli.kroll@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.