From: Linus Walleij <linus.walleij@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Alexander Shiyan <shc_work@mail.ru>
Subject: Re: [PATCH] gpio: generic: make bgpio_pdata always visible
Date: Wed, 13 Jan 2016 16:01:19 +0100 [thread overview]
Message-ID: <CACRpkdZd6sToPvGXtjrXEvoHyARfL9gz=t91Q_Qmawwu5_A8Jw@mail.gmail.com> (raw)
In-Reply-To: <21095568.bdP2eOAsBs@wuerfel>
On Sat, Jan 9, 2016 at 10:16 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Board files that define their own bgpio_pdata are broken when
> CONFIG_GPIO_GENERIC is disabled and the bgpio_pdata structure
> definition is hidden by the #ifdef:
>
> arch/arm/mach-clps711x/board-autcpu12.c:148:15: error: variable 'autcpu12_mmgpio_pdata' has initializer but incomplete type
> static struct bgpio_pdata autcpu12_mmgpio_pdata __initdata = {
> arch/arm/mach-clps711x/board-autcpu12.c:149:2: error: unknown field 'base' specified in initializer
> .base = AUTCPU12_MMGPIO_BASE,
>
> Since the board files should generally not care what drivers are
> enabled, this makes the structure definition visible again.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
Thanks a lot, patch applied!
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: generic: make bgpio_pdata always visible
Date: Wed, 13 Jan 2016 16:01:19 +0100 [thread overview]
Message-ID: <CACRpkdZd6sToPvGXtjrXEvoHyARfL9gz=t91Q_Qmawwu5_A8Jw@mail.gmail.com> (raw)
In-Reply-To: <21095568.bdP2eOAsBs@wuerfel>
On Sat, Jan 9, 2016 at 10:16 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Board files that define their own bgpio_pdata are broken when
> CONFIG_GPIO_GENERIC is disabled and the bgpio_pdata structure
> definition is hidden by the #ifdef:
>
> arch/arm/mach-clps711x/board-autcpu12.c:148:15: error: variable 'autcpu12_mmgpio_pdata' has initializer but incomplete type
> static struct bgpio_pdata autcpu12_mmgpio_pdata __initdata = {
> arch/arm/mach-clps711x/board-autcpu12.c:149:2: error: unknown field 'base' specified in initializer
> .base = AUTCPU12_MMGPIO_BASE,
>
> Since the board files should generally not care what drivers are
> enabled, this makes the structure definition visible again.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
Thanks a lot, patch applied!
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-01-13 15:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 21:16 [PATCH] gpio: generic: make bgpio_pdata always visible Arnd Bergmann
2016-01-09 21:16 ` Arnd Bergmann
2016-01-13 15:01 ` Linus Walleij [this message]
2016-01-13 15:01 ` Linus Walleij
2016-01-13 15:01 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZd6sToPvGXtjrXEvoHyARfL9gz=t91Q_Qmawwu5_A8Jw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=arnd@arndb.de \
--cc=gnurou@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.