From: Linus Walleij <linus.walleij@linaro.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: "Wei Yongjun" <weiyj.lk@gmail.com>,
"Tomasz Figa" <tomasz.figa@gmail.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Wei Yongjun" <weiyongjun1@huawei.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"Andrzej Hajda" <a.hajda@samsung.com>, 대인기 <inki.dae@samsung.com>,
최찬우 <cw00.choi@samsung.com>, 김승우 <sw0312.kim@samsung.com>
Subject: Re: [PATCH -next v2] pinctrl: samsung: Fix return value check in samsung_pinctrl_get_soc_data()
Date: Tue, 14 Mar 2017 11:29:28 +0100 [thread overview]
Message-ID: <CACRpkda1tALy3rmk7FebnR3Xg4WOuUc0Gv1xAmxkd+RLhJ_1VQ@mail.gmail.com> (raw)
In-Reply-To: <c4dd122b-0312-fcca-08e2-4d4586949a88@samsung.com>
On Tue, Feb 21, 2017 at 2:49 PM, Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
> Sadly this patch breaks support for IMEM pinctrl block on Exynos5433/TM2
> and it took us some time to find the source of the problem.
>
> devm_ioremap_resource() is not functionally a full equivalent of
> devm_ioremap(). The problem here is that registers for IMEM and ALIVE
> pin controllers are shared and both devices have <0x11090000 0x1000>
> range in their reg property. devm_ioremap_resource() maps given
> resource exclusively for the device, while devm_ioremap() allows
> non-exclusive mappings.
>
> This patch has to be reverted asap.
Patch reverted for fixes, copying the above text as commit message.
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -next v2] pinctrl: samsung: Fix return value check in samsung_pinctrl_get_soc_data()
Date: Tue, 14 Mar 2017 11:29:28 +0100 [thread overview]
Message-ID: <CACRpkda1tALy3rmk7FebnR3Xg4WOuUc0Gv1xAmxkd+RLhJ_1VQ@mail.gmail.com> (raw)
In-Reply-To: <c4dd122b-0312-fcca-08e2-4d4586949a88@samsung.com>
On Tue, Feb 21, 2017 at 2:49 PM, Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
> Sadly this patch breaks support for IMEM pinctrl block on Exynos5433/TM2
> and it took us some time to find the source of the problem.
>
> devm_ioremap_resource() is not functionally a full equivalent of
> devm_ioremap(). The problem here is that registers for IMEM and ALIVE
> pin controllers are shared and both devices have <0x11090000 0x1000>
> range in their reg property. devm_ioremap_resource() maps given
> resource exclusively for the device, while devm_ioremap() allows
> non-exclusive mappings.
>
> This patch has to be reverted asap.
Patch reverted for fixes, copying the above text as commit message.
Yours,
Linus Walleij
next prev parent reply other threads:[~2017-03-14 10:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 14:03 [PATCH -next] pinctrl: samsung: Fix return value check in samsung_pinctrl_get_soc_data() Wei Yongjun
2017-01-25 14:03 ` Wei Yongjun
2017-01-25 14:25 ` Tomasz Figa
2017-01-25 14:25 ` Tomasz Figa
2017-02-05 15:58 ` [PATCH -next v2] " Wei Yongjun
2017-02-05 15:58 ` Wei Yongjun
2017-02-07 19:56 ` Krzysztof Kozlowski
2017-02-07 19:56 ` Krzysztof Kozlowski
2017-02-13 14:49 ` Linus Walleij
2017-02-13 14:49 ` Linus Walleij
2017-02-21 13:49 ` Marek Szyprowski
2017-02-21 13:49 ` Marek Szyprowski
2017-02-21 14:14 ` Tomasz Figa
2017-02-21 14:14 ` Tomasz Figa
2017-02-21 15:32 ` Krzysztof Kozlowski
2017-02-21 15:32 ` Krzysztof Kozlowski
2017-03-14 10:29 ` Linus Walleij [this message]
2017-03-14 10:29 ` Linus Walleij
2017-03-14 10:44 ` Andrzej Hajda
2017-03-14 10:44 ` Andrzej Hajda
2017-03-15 13:45 ` Linus Walleij
2017-03-15 13:45 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkda1tALy3rmk7FebnR3Xg4WOuUc0Gv1xAmxkd+RLhJ_1VQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=a.hajda@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=inki.dae@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=sw0312.kim@samsung.com \
--cc=tomasz.figa@gmail.com \
--cc=weiyj.lk@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.