From: Linus Walleij <linus.walleij@linaro.org>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Corentin Labbe <clabbe@baylibre.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: partitions: Fix refcount leak in parse_redboot_of
Date: Thu, 26 May 2022 16:29:06 +0200 [thread overview]
Message-ID: <CACRpkdapKGvc75KV6ryJTLZdWCk=_dNrkzv_g0DnyNJm=1DvXw@mail.gmail.com> (raw)
In-Reply-To: <20220526110652.64849-1-linmq006@gmail.com>
On Thu, May 26, 2022 at 1:07 PM Miaoqian Lin <linmq006@gmail.com> wrote:
> of_get_child_by_name() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 237960880960 ("mtd: partitions: redboot: seek fis-index-block in the right node")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Corentin Labbe <clabbe@baylibre.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: partitions: Fix refcount leak in parse_redboot_of
Date: Thu, 26 May 2022 16:29:06 +0200 [thread overview]
Message-ID: <CACRpkdapKGvc75KV6ryJTLZdWCk=_dNrkzv_g0DnyNJm=1DvXw@mail.gmail.com> (raw)
In-Reply-To: <20220526110652.64849-1-linmq006@gmail.com>
On Thu, May 26, 2022 at 1:07 PM Miaoqian Lin <linmq006@gmail.com> wrote:
> of_get_child_by_name() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 237960880960 ("mtd: partitions: redboot: seek fis-index-block in the right node")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-05-26 14:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 11:06 [PATCH] mtd: partitions: Fix refcount leak in parse_redboot_of Miaoqian Lin
2022-05-26 11:06 ` Miaoqian Lin
2022-05-26 14:29 ` Linus Walleij [this message]
2022-05-26 14:29 ` Linus Walleij
2022-06-09 12:42 ` Miquel Raynal
2022-06-09 12:42 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdapKGvc75KV6ryJTLZdWCk=_dNrkzv_g0DnyNJm=1DvXw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=clabbe@baylibre.com \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.