From: Linus Walleij <linus.walleij@linaro.org>
To: Paul Walmsley <paul@pwsan.com>
Cc: Tony Lindgren <tony@atomide.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux-OMAP <linux-omap@vger.kernel.org>,
Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH v2] ARM: omap2: throw the die id into the entropy pool
Date: Tue, 10 Sep 2013 10:20:48 +0200 [thread overview]
Message-ID: <CACRpkdartxUGNqNkpymecaTrgVrkcDTg9UN7LRiCVRcwnE01Og@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1309091908270.28435@utopia.booyaka.com>
On Mon, Sep 9, 2013 at 9:14 PM, Paul Walmsley <paul@pwsan.com> wrote:
> Heh, that function name "add_device_randomness()" is a bit misleading.
> It's not actually intended to add "randomness": from
> drivers/char/random.c:
Yeah you're right...
Tony feel free to edit the commit message when applying.
> * None of this adds any entropy, it is meant to avoid the
> * problem of the nonblocking pool having similar initial state
> * across largely identical devices.
It's noble enough, just a few years back I ran into the problem where
all boards in a test farm came up with the same ethernet MAC
address due to the initialization of the nonblocking pool being
constant.
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: omap2: throw the die id into the entropy pool
Date: Tue, 10 Sep 2013 10:20:48 +0200 [thread overview]
Message-ID: <CACRpkdartxUGNqNkpymecaTrgVrkcDTg9UN7LRiCVRcwnE01Og@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1309091908270.28435@utopia.booyaka.com>
On Mon, Sep 9, 2013 at 9:14 PM, Paul Walmsley <paul@pwsan.com> wrote:
> Heh, that function name "add_device_randomness()" is a bit misleading.
> It's not actually intended to add "randomness": from
> drivers/char/random.c:
Yeah you're right...
Tony feel free to edit the commit message when applying.
> * None of this adds any entropy, it is meant to avoid the
> * problem of the nonblocking pool having similar initial state
> * across largely identical devices.
It's noble enough, just a few years back I ran into the problem where
all boards in a test farm came up with the same ethernet MAC
address due to the initialization of the nonblocking pool being
constant.
Yours,
Linus Walleij
next prev parent reply other threads:[~2013-09-10 8:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 7:29 [PATCH v2] ARM: omap2: throw the die id into the entropy pool Linus Walleij
2013-09-05 7:29 ` Linus Walleij
2013-09-09 19:14 ` Paul Walmsley
2013-09-09 19:14 ` Paul Walmsley
2013-09-09 20:15 ` Paul Walmsley
2013-09-09 20:15 ` Paul Walmsley
2013-09-10 8:20 ` Linus Walleij [this message]
2013-09-10 8:20 ` Linus Walleij
2013-10-03 18:13 ` Tony Lindgren
2013-10-03 18:13 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdartxUGNqNkpymecaTrgVrkcDTg9UN7LRiCVRcwnE01Og@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.