From: Linus Walleij <linus.walleij@linaro.org> To: Ben Levinsky <BLEVINSK@xilinx.com> Cc: Catalin Marinas <catalin.marinas@arm.com>, Stefano Stabellini <stefanos@xilinx.com>, "Ed T. Mooring" <emooring@xilinx.com>, "sunnyliangjy@gmail.com" <sunnyliangjy@gmail.com>, Punit Agrawal <punit1.agrawal@toshiba.co.jp>, Michal Simek <michals@xilinx.com>, "michael.auchter@ni.com" <michael.auchter@ni.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Mathieu Poirier <mathieu.poirier@linaro.org>, "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v18 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings Date: Thu, 8 Oct 2020 22:54:12 +0200 [thread overview] Message-ID: <CACRpkdb2AamnF9h_FfFDhTBMz7W-gob98OOzrHOiovyoiBPWRw@mail.gmail.com> (raw) In-Reply-To: <BYAPR02MB4407F9D8A60519D00F317D27B50B0@BYAPR02MB4407.namprd02.prod.outlook.com> On Thu, Oct 8, 2020 at 4:21 PM Ben Levinsky <BLEVINSK@xilinx.com> wrote: > As you said, this is just regular ARM TCM memory (as seen by the main ARM64 cluster). > Yes I can add back the compatible string, though maybe just "tcm" or "xlnx,tcm" I mean that if it is an ARM standard feature it should be prefixed "arm," > That being said, we can change this around to couple the TCM bank nodes into the R5 as we have In our present, internal implementation at > - https://github.com/Xilinx/linux-xlnx/blob/master/Documentation/devicetree/bindings/remoteproc/xilinx%2Czynqmp-r5-remoteproc.txt > - https://github.com/Xilinx/linux-xlnx/blob/master/drivers/remoteproc/zynqmp_r5_remoteproc.c > the TCM nodes are coupled in the R5 but after some previous review on this list, it was moved to have the TCM nodes decoupled from the R5 node > > I am not sure what you mean on the Arm64 handling of TCM memory. Via the architecture of the SoC https://www.xilinx.com/support/documentation/user_guides/ug1085-zynq-ultrascale-trm.pdf I know that the A53 cluster can see the absolute addresses of the R5 cluster so the translation is *I think* done as you describe with the CP15 instructions you listed. It seems like the TCM memories are von Neumann type (either can contain both code and data) which removes one of my worries. According to this data sheet they are also nothing ARM-provided but a Xilinx invention, and just happen to be hardcoded at the same address as TCM memories in ARM32, what a coincidence. So I take it this is the correct view and you can proceed like this, sorry for the fuzz. Yours, Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org> To: Ben Levinsky <BLEVINSK@xilinx.com> Cc: Stefano Stabellini <stefanos@xilinx.com>, "Ed T. Mooring" <emooring@xilinx.com>, "michael.auchter@ni.com" <michael.auchter@ni.com>, Punit Agrawal <punit1.agrawal@toshiba.co.jp>, Mathieu Poirier <mathieu.poirier@linaro.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "sunnyliangjy@gmail.com" <sunnyliangjy@gmail.com>, Rob Herring <robh+dt@kernel.org>, Michal Simek <michals@xilinx.com>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v18 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings Date: Thu, 8 Oct 2020 22:54:12 +0200 [thread overview] Message-ID: <CACRpkdb2AamnF9h_FfFDhTBMz7W-gob98OOzrHOiovyoiBPWRw@mail.gmail.com> (raw) In-Reply-To: <BYAPR02MB4407F9D8A60519D00F317D27B50B0@BYAPR02MB4407.namprd02.prod.outlook.com> On Thu, Oct 8, 2020 at 4:21 PM Ben Levinsky <BLEVINSK@xilinx.com> wrote: > As you said, this is just regular ARM TCM memory (as seen by the main ARM64 cluster). > Yes I can add back the compatible string, though maybe just "tcm" or "xlnx,tcm" I mean that if it is an ARM standard feature it should be prefixed "arm," > That being said, we can change this around to couple the TCM bank nodes into the R5 as we have In our present, internal implementation at > - https://github.com/Xilinx/linux-xlnx/blob/master/Documentation/devicetree/bindings/remoteproc/xilinx%2Czynqmp-r5-remoteproc.txt > - https://github.com/Xilinx/linux-xlnx/blob/master/drivers/remoteproc/zynqmp_r5_remoteproc.c > the TCM nodes are coupled in the R5 but after some previous review on this list, it was moved to have the TCM nodes decoupled from the R5 node > > I am not sure what you mean on the Arm64 handling of TCM memory. Via the architecture of the SoC https://www.xilinx.com/support/documentation/user_guides/ug1085-zynq-ultrascale-trm.pdf I know that the A53 cluster can see the absolute addresses of the R5 cluster so the translation is *I think* done as you describe with the CP15 instructions you listed. It seems like the TCM memories are von Neumann type (either can contain both code and data) which removes one of my worries. According to this data sheet they are also nothing ARM-provided but a Xilinx invention, and just happen to be hardcoded at the same address as TCM memories in ARM32, what a coincidence. So I take it this is the correct view and you can proceed like this, sorry for the fuzz. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-08 20:54 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-05 16:06 [PATCH v18 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP Ben Levinsky 2020-10-05 16:06 ` Ben Levinsky 2020-10-05 16:06 ` [PATCH v18 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration Ben Levinsky 2020-10-05 16:06 ` Ben Levinsky 2020-10-05 16:06 ` [PATCH v18 2/5] firmware: xilinx: Add shutdown/wakeup APIs Ben Levinsky 2020-10-05 16:06 ` Ben Levinsky 2020-10-05 16:06 ` [PATCH v18 3/5] firmware: xilinx: Add RPU configuration APIs Ben Levinsky 2020-10-05 16:06 ` Ben Levinsky 2020-10-05 16:06 ` [PATCH v18 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings Ben Levinsky 2020-10-05 16:06 ` Ben Levinsky 2020-10-08 12:37 ` Linus Walleij 2020-10-08 12:37 ` Linus Walleij 2020-10-08 14:21 ` Ben Levinsky 2020-10-08 14:21 ` Ben Levinsky 2020-10-08 16:45 ` Ben Levinsky 2020-10-08 16:45 ` Ben Levinsky 2020-10-08 20:22 ` Stefano Stabellini 2020-10-08 20:22 ` Stefano Stabellini 2020-10-08 20:54 ` Linus Walleij [this message] 2020-10-08 20:54 ` Linus Walleij 2020-10-05 16:06 ` [PATCH v18 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver Ben Levinsky 2020-10-05 16:06 ` Ben Levinsky 2020-10-05 19:34 ` Michael Auchter 2020-10-05 19:34 ` Michael Auchter 2020-10-06 19:15 ` Ben Levinsky 2020-10-06 19:15 ` Ben Levinsky 2020-10-06 21:31 ` Michael Auchter 2020-10-06 21:31 ` Michael Auchter 2020-10-06 21:46 ` Ben Levinsky 2020-10-06 21:46 ` Ben Levinsky 2020-10-06 22:20 ` Michael Auchter 2020-10-06 22:20 ` Michael Auchter 2020-10-07 14:31 ` Ben Levinsky 2020-10-07 14:31 ` Ben Levinsky 2020-10-15 18:31 ` Ben Levinsky 2020-10-15 18:31 ` Ben Levinsky 2020-10-19 20:43 ` Stefano Stabellini 2020-10-19 20:43 ` Stefano Stabellini 2020-10-19 21:33 ` Ben Levinsky 2020-10-19 21:33 ` Ben Levinsky
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACRpkdb2AamnF9h_FfFDhTBMz7W-gob98OOzrHOiovyoiBPWRw@mail.gmail.com \ --to=linus.walleij@linaro.org \ --cc=BLEVINSK@xilinx.com \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=emooring@xilinx.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=mathieu.poirier@linaro.org \ --cc=michael.auchter@ni.com \ --cc=michals@xilinx.com \ --cc=punit1.agrawal@toshiba.co.jp \ --cc=robh+dt@kernel.org \ --cc=stefanos@xilinx.com \ --cc=sunnyliangjy@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.