All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Cc: ext Tony Lindgren <tony@atomide.com>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Greg KH <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux-OMAP <linux-omap@vger.kernel.org>,
	linux-serial@vger.kernel.org,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO descriptor
Date: Thu, 23 Aug 2018 12:42:27 +0200	[thread overview]
Message-ID: <CACRpkdb7E7cjZuYx6Cgxv2sNJmxvwqg0dNh3WpALwtnuCsezuw@mail.gmail.com> (raw)
In-Reply-To: <20180820181333.2527-2-jmkrzyszt@gmail.com>

On Mon, Aug 20, 2018 at 8:12 PM Janusz Krzysztofik <jmkrzyszt@gmail.com> wrote:

> Don't request MODEM IRQ GPIO by its global number in
> ams_delta_modem_init().  Instead, obtain its GPIO descriptor
> and assign related IRQ to the MODEM.  Do that from
> omap_gpio_deps_init(), where the chip is already looked up.  Then, in
> ams_delta_modem_init(), just check for the IRQ number having been
> already assigned.
>
> Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

It's a bit unorthodox to have the board files intercept and poke
around inside the gpio_chip like the code in this file does,
I prefer to keep it encapsulated inside the GPIO driver.
However this is the lesser evil... if OMAP1 is ever phased
over to device tree it will go away, until then it is just nicely
contained.

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO descriptor
Date: Thu, 23 Aug 2018 12:42:27 +0200	[thread overview]
Message-ID: <CACRpkdb7E7cjZuYx6Cgxv2sNJmxvwqg0dNh3WpALwtnuCsezuw@mail.gmail.com> (raw)
In-Reply-To: <20180820181333.2527-2-jmkrzyszt@gmail.com>

On Mon, Aug 20, 2018 at 8:12 PM Janusz Krzysztofik <jmkrzyszt@gmail.com> wrote:

> Don't request MODEM IRQ GPIO by its global number in
> ams_delta_modem_init().  Instead, obtain its GPIO descriptor
> and assign related IRQ to the MODEM.  Do that from
> omap_gpio_deps_init(), where the chip is already looked up.  Then, in
> ams_delta_modem_init(), just check for the IRQ number having been
> already assigned.
>
> Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

It's a bit unorthodox to have the board files intercept and poke
around inside the gpio_chip like the code in this file does,
I prefer to keep it encapsulated inside the GPIO driver.
However this is the lesser evil... if OMAP1 is ever phased
over to device tree it will go away, until then it is just nicely
contained.

Yours,
Linus Walleij

  reply	other threads:[~2018-08-23 10:42 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20 18:13 [PATCH 0/3] ARM: OMAP1: ams-delta: Clean up GPIO setup for MODEM Janusz Krzysztofik
2018-08-20 18:13 ` Janusz Krzysztofik
2018-08-20 18:13 ` [PATCH 1/3] ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO descriptor Janusz Krzysztofik
2018-08-20 18:13   ` Janusz Krzysztofik
2018-08-23 10:42   ` Linus Walleij [this message]
2018-08-23 10:42     ` Linus Walleij
2018-08-20 18:13 ` [PATCH 2/3] ARM: OMAP1: ams-delta: initialize latch2 pins to safe values Janusz Krzysztofik
2018-08-20 18:13   ` Janusz Krzysztofik
2018-08-23 10:44   ` Linus Walleij
2018-08-23 10:44     ` Linus Walleij
2018-08-20 18:13 ` [PATCH 3/3] ARM: OMAP1: ams-delta: register MODEM device earlier Janusz Krzysztofik
2018-08-20 18:13   ` Janusz Krzysztofik
2018-08-23 10:45   ` Linus Walleij
2018-08-23 10:45     ` Linus Walleij
2018-09-07 16:56 ` [PATCH 0/3] ARM: OMAP1: ams-delta: Clean up GPIO setup for MODEM Tony Lindgren
2018-09-07 16:56   ` Tony Lindgren
2018-09-09 23:44 ` [PATCH v2 " Janusz Krzysztofik
2018-09-09 23:44   ` Janusz Krzysztofik
2018-09-09 23:44   ` Janusz Krzysztofik
2018-09-09 23:44   ` [PATCH v2 1/3] ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO descriptor Janusz Krzysztofik
2018-09-09 23:44     ` Janusz Krzysztofik
2018-09-09 23:44     ` Janusz Krzysztofik
2018-09-09 23:44   ` [PATCH v2 2/3] ARM: OMAP1: ams-delta: initialize latch2 pins to safe values Janusz Krzysztofik
2018-09-09 23:44     ` Janusz Krzysztofik
2018-09-09 23:44     ` Janusz Krzysztofik
2018-09-09 23:44   ` [PATCH v2 3/3] ARM: OMAP1: ams-delta: register MODEM device earlier Janusz Krzysztofik
2018-09-09 23:44     ` Janusz Krzysztofik
2018-09-09 23:44     ` Janusz Krzysztofik
2018-09-10 21:49   ` [PATCH v2 0/3] ARM: OMAP1: ams-delta: Clean up GPIO setup for MODEM Janusz Krzysztofik
2018-09-10 21:49     ` Janusz Krzysztofik
2018-09-20 21:23     ` Tony Lindgren
2018-09-20 21:23       ` Tony Lindgren
2018-09-20 22:43       ` Janusz Krzysztofik
2018-09-20 22:43         ` Janusz Krzysztofik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdb7E7cjZuYx6Cgxv2sNJmxvwqg0dNh3WpALwtnuCsezuw@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=aaro.koskinen@iki.fi \
    --cc=gregkh@linuxfoundation.org \
    --cc=jmkrzyszt@gmail.com \
    --cc=jslaby@suse.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.