Re: [PATCH net-next v2 6/9] net: wan/ixp4xx_hss: Convert to platform remove callback returning void

From: Linus Walleij <linus.walleij@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	Linus Walleij <linusw@kernel.org>,
	 Imre Kaloz <kaloz@openwrt.org>,
	linux-arm-kernel@lists.infradead.org,  netdev@vger.kernel.org,
	kernel@pengutronix.de
Subject: Re: [PATCH net-next v2 6/9] net: wan/ixp4xx_hss: Convert to platform remove callback returning void
Date: Tue, 5 Dec 2023 23:43:19 +0100	[thread overview]
Message-ID: <CACRpkdbszYnpuDYeUCKiMwJvV9tq8b4Yq8bmsTr7vK5g_b=Qng@mail.gmail.com> (raw)
In-Reply-To: <b0488fa6181a47668e5737905ae7adc8d7cd055e.1701713943.git.u.kleine-koenig@pengutronix.de>

On Mon, Dec 4, 2023 at 7:31 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:

> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Link: https://lore.kernel.org/r/20231117095922.876489-8-u.kleine-koenig@pengutronix.de
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij