From: Jonas Jensen <jonas.jensen@gmail.com> To: Mark Rutland <mark.rutland@arm.com> Cc: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "arm@kernel.org" <arm@kernel.org>, "vinod.koul@intel.com" <vinod.koul@intel.com>, "djbw@fb.com" <djbw@fb.com>, "arnd@arndb.de" <arnd@arndb.de>, "linux@arm.linux.org.uk" <linux@arm.linux.org.uk> Subject: Re: [PATCH v8] dmaengine: Add MOXA ART DMA engine driver Date: Mon, 7 Oct 2013 15:42:40 +0200 [thread overview] Message-ID: <CACmBeS0G=GVVZiTNEovq0PtfZrr-L7rskyGOrpY12=6fgesyWg@mail.gmail.com> (raw) In-Reply-To: <20130807151316.GH28558@e106331-lin.cambridge.arm.com> Hi Mark, Thanks for the replies. Please have a look at v9. On 7 August 2013 17:13, Mark Rutland <mark.rutland@arm.com> wrote: >> + >> + ret = devm_request_irq(dev, irq, moxart_dma_interrupt, 0, >> + "moxart-dma-engine", mdc); >> + if (ret) { >> + dev_err(dev, "devm_request_irq failed\n"); > > Do you not need calls to of_dma_controller_free and > dma_async_device_unregister here? I'm not all that familiar with the DMA > API, so maybe you don't. Yes. I see now, I should have moved both dma_async_device_register() and of_dma_controller_register() to happen after devm_request_irq(). I'll include that in next version. >> +static int moxart_remove(struct platform_device *pdev) >> +{ >> + struct moxart_dma_container *m = dev_get_drvdata(&pdev->dev); > > Similarly, do you not need to call of_dma_controller free here? Yes, this is now done. Best regards, Jonas
WARNING: multiple messages have this Message-ID (diff)
From: jonas.jensen@gmail.com (Jonas Jensen) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v8] dmaengine: Add MOXA ART DMA engine driver Date: Mon, 7 Oct 2013 15:42:40 +0200 [thread overview] Message-ID: <CACmBeS0G=GVVZiTNEovq0PtfZrr-L7rskyGOrpY12=6fgesyWg@mail.gmail.com> (raw) In-Reply-To: <20130807151316.GH28558@e106331-lin.cambridge.arm.com> Hi Mark, Thanks for the replies. Please have a look at v9. On 7 August 2013 17:13, Mark Rutland <mark.rutland@arm.com> wrote: >> + >> + ret = devm_request_irq(dev, irq, moxart_dma_interrupt, 0, >> + "moxart-dma-engine", mdc); >> + if (ret) { >> + dev_err(dev, "devm_request_irq failed\n"); > > Do you not need calls to of_dma_controller_free and > dma_async_device_unregister here? I'm not all that familiar with the DMA > API, so maybe you don't. Yes. I see now, I should have moved both dma_async_device_register() and of_dma_controller_register() to happen after devm_request_irq(). I'll include that in next version. >> +static int moxart_remove(struct platform_device *pdev) >> +{ >> + struct moxart_dma_container *m = dev_get_drvdata(&pdev->dev); > > Similarly, do you not need to call of_dma_controller free here? Yes, this is now done. Best regards, Jonas
next prev parent reply other threads:[~2013-10-07 13:42 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-10 8:51 [PATCH] dmaengine: Add MOXA ART DMA engine driver Jonas Jensen 2013-07-10 8:51 ` Jonas Jensen 2013-07-10 9:30 ` Russell King - ARM Linux 2013-07-10 9:30 ` Russell King - ARM Linux 2013-07-10 9:48 ` Jonas Jensen 2013-07-10 9:48 ` Jonas Jensen 2013-07-10 12:43 ` [PATCH v2] " Jonas Jensen 2013-07-10 12:43 ` Jonas Jensen 2013-07-17 10:06 ` [PATCH v3] " Jonas Jensen 2013-07-17 10:06 ` Jonas Jensen 2013-07-29 13:44 ` [PATCH v4] " Jonas Jensen 2013-07-29 13:44 ` Jonas Jensen 2013-07-29 16:35 ` Arnd Bergmann 2013-07-29 16:35 ` Arnd Bergmann 2013-08-02 12:28 ` Jonas Jensen 2013-08-02 12:28 ` Jonas Jensen 2013-08-02 19:28 ` Arnd Bergmann 2013-08-02 19:28 ` Arnd Bergmann 2013-08-02 12:03 ` [PATCH v5] " Jonas Jensen 2013-08-02 12:03 ` Jonas Jensen 2013-08-02 13:28 ` [PATCH v6] " Jonas Jensen 2013-08-02 13:28 ` Jonas Jensen 2013-08-02 13:51 ` Russell King - ARM Linux 2013-08-02 13:51 ` Russell King - ARM Linux 2013-08-02 14:09 ` Mark Rutland 2013-08-02 14:09 ` Mark Rutland 2013-08-05 14:37 ` [PATCH v7] " Jonas Jensen 2013-08-05 14:37 ` Jonas Jensen 2013-08-05 16:57 ` Mark Rutland 2013-08-05 16:57 ` Mark Rutland 2013-08-05 20:49 ` Arnd Bergmann 2013-08-05 20:49 ` Arnd Bergmann 2013-08-06 12:38 ` [PATCH v8] " Jonas Jensen 2013-08-06 12:38 ` Jonas Jensen 2013-08-06 18:42 ` Arnd Bergmann 2013-08-06 18:42 ` Arnd Bergmann 2013-08-07 15:13 ` Mark Rutland 2013-08-07 15:13 ` Mark Rutland 2013-10-07 13:42 ` Jonas Jensen [this message] 2013-10-07 13:42 ` Jonas Jensen 2013-10-07 13:13 ` [PATCH v9] " Jonas Jensen 2013-10-07 13:13 ` Jonas Jensen 2013-10-07 14:10 ` [PATCH v10] " Jonas Jensen 2013-10-07 14:10 ` Jonas Jensen 2013-10-07 15:12 ` Mark Rutland 2013-10-07 15:12 ` Mark Rutland 2013-10-07 15:12 ` Mark Rutland 2013-10-08 9:53 ` Jonas Jensen 2013-10-08 9:53 ` Jonas Jensen 2013-10-08 9:53 ` Jonas Jensen 2013-10-08 12:55 ` Mark Rutland 2013-10-08 12:55 ` Mark Rutland 2013-10-08 12:55 ` Mark Rutland 2013-10-08 8:42 ` [PATCH v11] " Jonas Jensen 2013-10-08 8:42 ` Jonas Jensen 2013-11-13 13:59 ` Vinod Koul 2013-11-13 13:59 ` Vinod Koul 2013-11-13 17:16 ` Arnd Bergmann 2013-11-13 17:16 ` Arnd Bergmann 2013-12-06 14:27 ` [PATCH v12] " Jonas Jensen 2013-12-06 14:27 ` Jonas Jensen 2013-12-11 15:13 ` [PATCH v13] " Jonas Jensen 2013-12-11 15:13 ` Jonas Jensen 2013-12-11 21:27 ` Arnd Bergmann 2013-12-11 21:27 ` Arnd Bergmann 2013-12-12 9:16 ` Andy Shevchenko 2013-12-12 9:16 ` Andy Shevchenko 2013-12-12 12:32 ` [PATCH v14] " Jonas Jensen 2013-12-12 12:32 ` Jonas Jensen 2013-12-13 16:02 ` Lars-Peter Clausen 2013-12-13 16:02 ` Lars-Peter Clausen 2013-12-16 10:24 ` [PATCH v15] " Jonas Jensen 2013-12-16 10:24 ` Jonas Jensen 2014-01-17 8:46 ` [PATCH v16] " Jonas Jensen 2014-01-17 8:46 ` Jonas Jensen [not found] ` <1389948365-13999-1-git-send-email-jonas.jensen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2014-01-17 13:29 ` Fwd: " Jonas Jensen 2014-01-17 14:42 ` Arnd Bergmann 2014-01-17 14:42 ` Arnd Bergmann 2014-01-20 7:07 ` Vinod Koul 2014-01-20 7:07 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CACmBeS0G=GVVZiTNEovq0PtfZrr-L7rskyGOrpY12=6fgesyWg@mail.gmail.com' \ --to=jonas.jensen@gmail.com \ --cc=arm@kernel.org \ --cc=arnd@arndb.de \ --cc=djbw@fb.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=mark.rutland@arm.com \ --cc=vinod.koul@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.