Re: [PATCH 02/10 v2] xen/arm: vpl011: Add new vuart domctl interface to setup pfn and evtchn

From: Bhupinder Thakur <bhupinder.thakur@linaro.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Julien Grall <julien.grall@arm.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH 02/10 v2] xen/arm: vpl011: Add new vuart domctl interface to setup pfn and evtchn
Date: Tue, 2 May 2017 15:17:05 +0530	[thread overview]
Message-ID: <CACtJ1JT-1n3WUUWPdxCOu0sC9BLBzb_LpMo3h_117eLOHPAezw@mail.gmail.com> (raw)
In-Reply-To: <590853E002000078001559E2@prv-mh.provo.novell.com>

Hi Jan,

On 2 May 2017 at 13:09, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 28.04.17 at 21:23, <sstabellini@kernel.org> wrote:
>> On Fri, 28 Apr 2017, Bhupinder Thakur wrote:
>>> --- a/xen/include/public/domctl.h
>>> +++ b/xen/include/public/domctl.h
>>> @@ -1138,6 +1138,15 @@ struct xen_domctl_psr_cat_op {
>>>      uint32_t target;    /* IN */
>>>      uint64_t data;      /* IN/OUT */
>>>  };
>>> +
>>> +struct xen_domctl_vuart_op {
>>> +#define XEN_DOMCTL_VUART_OP_SET_PFN      0
>>> +#define XEN_DOMCTL_VUART_OP_GET_EVTCHN   1
>>> +        uint32_t cmd;       /* XEN_DOMCTL_VUART_OP_* */
>>> +        uint32_t pfn;       /* IN */
>>
>> xen_pfn_t
>
> And "pfn" is likely the wrong name: Do you mean an MFN or a GFN?
I will rename it to GFN.

>
>>> +        uint32_t evtchn;    /* OUT */
>>
>> evtchn_port_t
>
> Plus considering their fully separate use, the two should form a
> union imo.
Yes. I will define a union of the two.

Regards,
Bhupinder

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel