Re: [PATCH 02/10 v2] xen/arm: vpl011: Add new vuart domctl interface to setup pfn and evtchn

From: Bhupinder Thakur <bhupinder.thakur@linaro.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Julien Grall <julien.grall@arm.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH 02/10 v2] xen/arm: vpl011: Add new vuart domctl interface to setup pfn and evtchn
Date: Tue, 2 May 2017 15:28:16 +0530	[thread overview]
Message-ID: <CACtJ1JTyQaKj1wSO6MWE5i1ha192Kyw8+FG1yGTUq3FdVQyYog@mail.gmail.com> (raw)
In-Reply-To: <590855C902000078001559F5@prv-mh.provo.novell.com>

Hi Jan,

>> +    case XEN_DOMCTL_vuart_op:
>> +        ret = -EOPNOTSUPP;
>> +        break;
>
> There should be no need for such an addition.

This check was added to return a failure if user tries to call the
vuart domctl in case of x86 (wrong user configuration). If this check
is not there will it not end up calling the default case:
iommu_do_domctl()?

Regards,
Bhupinder

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel