From: Emil Velikov <emil.l.velikov@gmail.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-fbdev <linux-fbdev@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 1/2] video: fbdev: amifb: remove dead APUS support
Date: Mon, 15 Jun 2020 21:35:10 +0100 [thread overview]
Message-ID: <CACvgo50HieMRRb1kK3X0XWXtNmgidYi_OWW9DGCrxT+1q14RWQ@mail.gmail.com> (raw)
In-Reply-To: <839133dd-8ed4-5fec-c311-ce9f8abf3d5f@samsung.com>
Hi Bartlomiej,
On Tue, 2 Jun 2020 at 11:37, Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
>
>
> On 5/14/20 10:21 PM, Geert Uytterhoeven wrote:
>
> > These #ifdefs are relics from APUS (Amiga Power-Up System), which
> > added a PPC board. APUS support was killed off a long time ago,
> > when arch/ppc/ was still king, but these #ifdefs were missed, because
> > they didn't test for CONFIG_APUS.
>
> Reported-by: Al Viro <viro@zeniv.linux.org.uk>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> drivers/video/fbdev/amifb.c | 63 --------------------------------------------
> 1 file changed, 63 deletions(-)
>
A quick look through my checkout (drm-misc/next aka 5.8 ish), shows
multiple other places which check for the define.
And a single place where it's being set - the Makefile below.
Should those be addressed as well? Or perhaps they are and I've got an old tree.
HTH
Emil
$ git grep -c __mc68000__
arch/m68k/Makefile:1
drivers/block/floppy.c:2
drivers/ide/ide-probe.c:2
drivers/input/misc/hp_sdc_rtc.c:1
drivers/input/serio/hp_sdc.c:3
drivers/input/serio/hp_sdc_mlc.c:1
drivers/net/ethernet/i825xx/82596.c:8
drivers/tty/vt/keyboard.c:1
drivers/video/fbdev/amifb.c:11
include/linux/a.out.h:1
include/linux/hp_sdc.h:1
include/uapi/linux/a.out.h:1
lib/fonts/fonts.c:2
lib/mpi/longlong.h:1
WARNING: multiple messages have this Message-ID (diff)
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-fbdev <linux-fbdev@vger.kernel.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 1/2] video: fbdev: amifb: remove dead APUS support
Date: Mon, 15 Jun 2020 20:35:10 +0000 [thread overview]
Message-ID: <CACvgo50HieMRRb1kK3X0XWXtNmgidYi_OWW9DGCrxT+1q14RWQ@mail.gmail.com> (raw)
In-Reply-To: <839133dd-8ed4-5fec-c311-ce9f8abf3d5f@samsung.com>
Hi Bartlomiej,
On Tue, 2 Jun 2020 at 11:37, Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
>
>
> On 5/14/20 10:21 PM, Geert Uytterhoeven wrote:
>
> > These #ifdefs are relics from APUS (Amiga Power-Up System), which
> > added a PPC board. APUS support was killed off a long time ago,
> > when arch/ppc/ was still king, but these #ifdefs were missed, because
> > they didn't test for CONFIG_APUS.
>
> Reported-by: Al Viro <viro@zeniv.linux.org.uk>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> drivers/video/fbdev/amifb.c | 63 --------------------------------------------
> 1 file changed, 63 deletions(-)
>
A quick look through my checkout (drm-misc/next aka 5.8 ish), shows
multiple other places which check for the define.
And a single place where it's being set - the Makefile below.
Should those be addressed as well? Or perhaps they are and I've got an old tree.
HTH
Emil
$ git grep -c __mc68000__
arch/m68k/Makefile:1
drivers/block/floppy.c:2
drivers/ide/ide-probe.c:2
drivers/input/misc/hp_sdc_rtc.c:1
drivers/input/serio/hp_sdc.c:3
drivers/input/serio/hp_sdc_mlc.c:1
drivers/net/ethernet/i825xx/82596.c:8
drivers/tty/vt/keyboard.c:1
drivers/video/fbdev/amifb.c:11
include/linux/a.out.h:1
include/linux/hp_sdc.h:1
include/uapi/linux/a.out.h:1
lib/fonts/fonts.c:2
lib/mpi/longlong.h:1
WARNING: multiple messages have this Message-ID (diff)
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-fbdev <linux-fbdev@vger.kernel.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 1/2] video: fbdev: amifb: remove dead APUS support
Date: Mon, 15 Jun 2020 21:35:10 +0100 [thread overview]
Message-ID: <CACvgo50HieMRRb1kK3X0XWXtNmgidYi_OWW9DGCrxT+1q14RWQ@mail.gmail.com> (raw)
In-Reply-To: <839133dd-8ed4-5fec-c311-ce9f8abf3d5f@samsung.com>
Hi Bartlomiej,
On Tue, 2 Jun 2020 at 11:37, Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
>
>
> On 5/14/20 10:21 PM, Geert Uytterhoeven wrote:
>
> > These #ifdefs are relics from APUS (Amiga Power-Up System), which
> > added a PPC board. APUS support was killed off a long time ago,
> > when arch/ppc/ was still king, but these #ifdefs were missed, because
> > they didn't test for CONFIG_APUS.
>
> Reported-by: Al Viro <viro@zeniv.linux.org.uk>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> drivers/video/fbdev/amifb.c | 63 --------------------------------------------
> 1 file changed, 63 deletions(-)
>
A quick look through my checkout (drm-misc/next aka 5.8 ish), shows
multiple other places which check for the define.
And a single place where it's being set - the Makefile below.
Should those be addressed as well? Or perhaps they are and I've got an old tree.
HTH
Emil
$ git grep -c __mc68000__
arch/m68k/Makefile:1
drivers/block/floppy.c:2
drivers/ide/ide-probe.c:2
drivers/input/misc/hp_sdc_rtc.c:1
drivers/input/serio/hp_sdc.c:3
drivers/input/serio/hp_sdc_mlc.c:1
drivers/net/ethernet/i825xx/82596.c:8
drivers/tty/vt/keyboard.c:1
drivers/video/fbdev/amifb.c:11
include/linux/a.out.h:1
include/linux/hp_sdc.h:1
include/uapi/linux/a.out.h:1
lib/fonts/fonts.c:2
lib/mpi/longlong.h:1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-06-15 20:38 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200504232908eucas1p296927bc7c736ad924cefaea9a546459d@eucas1p2.samsung.com>
2020-05-04 23:29 ` [trivial PATCH] video: fbdev: Use IS_BUILTIN Joe Perches
2020-05-04 23:29 ` Joe Perches
2020-05-04 23:29 ` Joe Perches
2020-05-04 23:29 ` Joe Perches
2020-06-01 13:25 ` Bartlomiej Zolnierkiewicz
2020-06-01 13:25 ` Bartlomiej Zolnierkiewicz
2020-06-01 13:25 ` Bartlomiej Zolnierkiewicz
2020-06-01 13:25 ` Bartlomiej Zolnierkiewicz
2020-06-02 10:37 ` [PATCH 1/2] video: fbdev: amifb: remove dead APUS support Bartlomiej Zolnierkiewicz
2020-06-02 10:37 ` Bartlomiej Zolnierkiewicz
2020-06-02 10:37 ` Bartlomiej Zolnierkiewicz
2020-06-02 10:41 ` John Paul Adrian Glaubitz
2020-06-02 10:41 ` John Paul Adrian Glaubitz
2020-06-02 10:41 ` John Paul Adrian Glaubitz
2020-06-02 11:04 ` Geert Uytterhoeven
2020-06-02 11:04 ` Geert Uytterhoeven
2020-06-02 11:04 ` Geert Uytterhoeven
2020-06-02 11:07 ` John Paul Adrian Glaubitz
2020-06-02 11:07 ` John Paul Adrian Glaubitz
2020-06-02 11:07 ` John Paul Adrian Glaubitz
2020-06-02 11:27 ` Bartlomiej Zolnierkiewicz
2020-06-02 11:27 ` Bartlomiej Zolnierkiewicz
2020-06-02 11:27 ` Bartlomiej Zolnierkiewicz
2020-06-15 20:35 ` Emil Velikov [this message]
2020-06-15 20:35 ` Emil Velikov
2020-06-15 20:35 ` Emil Velikov
2020-06-15 21:26 ` Geert Uytterhoeven
2020-06-15 21:26 ` Geert Uytterhoeven
2020-06-15 21:26 ` Geert Uytterhoeven
2020-06-02 10:38 ` [PATCH 2/2] video: fbdev: amifb: add FIXMEs about {put,get}_user() failures Bartlomiej Zolnierkiewicz
2020-06-02 10:38 ` Bartlomiej Zolnierkiewicz
2020-06-02 10:38 ` Bartlomiej Zolnierkiewicz
2020-06-02 11:50 ` [PATCH v2 1/2] video: fbdev: amifb: add FIXME about dead APUS support Bartlomiej Zolnierkiewicz
2020-06-02 11:50 ` Bartlomiej Zolnierkiewicz
2020-06-02 11:50 ` Bartlomiej Zolnierkiewicz
2020-06-02 12:03 ` Geert Uytterhoeven
2020-06-02 12:03 ` Geert Uytterhoeven
2020-06-02 12:03 ` Geert Uytterhoeven
2020-06-02 16:12 ` Al Viro
2020-06-02 16:12 ` Al Viro
2020-06-02 16:12 ` Al Viro
2020-06-03 0:20 ` Finn Thain
2020-06-03 0:20 ` Finn Thain
2020-06-03 0:20 ` Finn Thain
2020-07-10 14:23 ` Bartlomiej Zolnierkiewicz
2020-07-10 14:23 ` Bartlomiej Zolnierkiewicz
2020-07-10 14:23 ` Bartlomiej Zolnierkiewicz
2020-06-02 11:52 ` [PATCH v2 2/2] video: fbdev: amifb: add FIXMEs about {put,get}_user() failures Bartlomiej Zolnierkiewicz
2020-06-02 11:52 ` Bartlomiej Zolnierkiewicz
2020-06-02 11:52 ` Bartlomiej Zolnierkiewicz
2020-06-02 12:03 ` Geert Uytterhoeven
2020-06-02 12:03 ` Geert Uytterhoeven
2020-06-02 12:03 ` Geert Uytterhoeven
2020-07-10 14:23 ` Bartlomiej Zolnierkiewicz
2020-07-10 14:23 ` Bartlomiej Zolnierkiewicz
2020-07-10 14:23 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACvgo50HieMRRb1kK3X0XWXtNmgidYi_OWW9DGCrxT+1q14RWQ@mail.gmail.com \
--to=emil.l.velikov@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.