Re: [PATCH RESEND 1/2] vgacon: dummy implementation for vgacon_text_force

From: Emil Velikov <emil.l.velikov@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH RESEND 1/2] vgacon: dummy implementation for vgacon_text_force
Date: Fri, 27 Nov 2015 15:29:52 +0000	[thread overview]
Message-ID: <CACvgo5135MWO4Si9xYjW4PsmUYdadtPA++X12g2Y76KtRe85kQ@mail.gmail.com> (raw)
In-Reply-To: <1448637005-3847-1-git-send-email-daniel.vetter@ffwll.ch>

On 27 November 2015 at 15:10, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> This allows us to ditch a ton of ugly #ifdefs from a bunch of drm modeset
> drivers.
>
> v2: Make the dummy function actually return a sane value, spotted by
> Ville.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/ast/ast_drv.c         | 2 --
>  drivers/gpu/drm/cirrus/cirrus_drv.c   | 2 --
>  drivers/gpu/drm/i915/i915_drv.c       | 2 --
>  drivers/gpu/drm/mgag200/mgag200_drv.c | 2 --
>  drivers/gpu/drm/nouveau/nouveau_drm.c | 2 --
>  drivers/gpu/drm/qxl/qxl_drv.c         | 2 --
>  drivers/gpu/drm/radeon/radeon_drv.c   | 2 --
>  include/linux/console.h               | 2 ++

The new drivers seems to be missing the conversion. Namely amdgpu and
virtio_gpu.

> --- a/drivers/gpu/drm/nouveau/nouveau_drm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
> @@ -1072,10 +1072,8 @@ nouveau_drm_init(void)
>         nouveau_display_options();
>
>         if (nouveau_modeset == -1) {
> -#ifdef CONFIG_VGA_CONSOLE
>                 if (vgacon_text_force())
>                         nouveau_modeset = 0;
> -#endif
It's kind of interesting how nouveau differs from everyone else. The
force toggle has lower priority than the nouveau specific one :-)
Obviously not something you should address or anything.

Another interesting fact is how none of the SoC honour the modeset fla :-\

Regards,
Emil