All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "David Airlie" <airlied@linux.ie>,
	"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
	"moderated list:ARM/S5P EXYNOS AR..."
	<linux-samsung-soc@vger.kernel.org>,
	"ML nouveau" <nouveau@lists.freedesktop.org>,
	"Seung-Woo Kim" <sw0312.kim@samsung.com>,
	"Russell King" <rmk+kernel@armlinux.org.uk>,
	"ML dri-devel" <dri-devel@lists.freedesktop.org>,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Kukjin Kim" <kgene@kernel.org>,
	linux-mediatek@lists.infradead.org,
	"Ben Skeggs" <bskeggs@redhat.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Christian König" <christian.koenig@amd.com>,
	LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/5] headers_check: don't warn about c++ guards
Date: Wed, 18 May 2016 21:20:29 +0100	[thread overview]
Message-ID: <CACvgo51FkfzzhFjYKyyHfxb-DyZeheQP2oZG-tWf1-EiBakp2w@mail.gmail.com> (raw)
In-Reply-To: <1463587653-3035181-2-git-send-email-arnd@arndb.de>

On 18 May 2016 at 17:07, Arnd Bergmann <arnd@arndb.de> wrote:
> A recent addition to the DRM tree for 4.7 added 'extern "C"' guards
> for c++ to all the DRM headers, and that now causes warnings
> in 'make headers_check':
>
> usr/include/drm/amdgpu_drm.h:38: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm.h:63: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm.h:699: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm_fourcc.h:30: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm_mode.h:33: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm_sarea.h:38: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/exynos_drm.h:21: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/i810_drm.h:7: userspace cannot reference function or variable defined in the kernel
>
> This changes the headers_check.pl script to not warn about this.
> I'm listing the merge commit as introducing the problem, because
> there are several patches in this branch that each do this for
> one file.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7c10ddf87472 ("Merge branch 'drm-uapi-extern-c-fixes' of https://github.com/evelikov/linux into drm-next")
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

Thanks Arnd !

As Dave mentioned - the best solution would be to have the hunks
generated on the fly. Sadly Perl and me don't go hand in hand so if
you're interested I'll be really grateful.

-Emil

WARNING: multiple messages have this Message-ID (diff)
From: Emil Velikov <emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: "Krzysztof Kozlowski"
	<k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	"moderated list:ARM/S5P EXYNOS AR..."
	<linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"David Airlie" <airlied-cv59FeDIM0c@public.gmane.org>,
	"ML nouveau"
	<nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	"Seung-Woo Kim"
	<sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	"Linux-Kernel@Vger. Kernel. Org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"ML dri-devel"
	<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	"Matthias Brugger"
	<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Russell King"
	<rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	"Kukjin Kim" <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	"Ben Skeggs" <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"Alex Deucher" <alexander.deucher-5C7GfCeVMHo@public.gmane.org>,
	"Kyungmin Park"
	<kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	"Christian König" <christian.koenig-5C7GfCeVMHo@public.gmane.org>,
	LAKML
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 1/5] headers_check: don't warn about c++ guards
Date: Wed, 18 May 2016 21:20:29 +0100	[thread overview]
Message-ID: <CACvgo51FkfzzhFjYKyyHfxb-DyZeheQP2oZG-tWf1-EiBakp2w@mail.gmail.com> (raw)
In-Reply-To: <1463587653-3035181-2-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>

On 18 May 2016 at 17:07, Arnd Bergmann <arnd@arndb.de> wrote:
> A recent addition to the DRM tree for 4.7 added 'extern "C"' guards
> for c++ to all the DRM headers, and that now causes warnings
> in 'make headers_check':
>
> usr/include/drm/amdgpu_drm.h:38: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm.h:63: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm.h:699: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm_fourcc.h:30: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm_mode.h:33: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm_sarea.h:38: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/exynos_drm.h:21: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/i810_drm.h:7: userspace cannot reference function or variable defined in the kernel
>
> This changes the headers_check.pl script to not warn about this.
> I'm listing the merge commit as introducing the problem, because
> there are several patches in this branch that each do this for
> one file.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7c10ddf87472 ("Merge branch 'drm-uapi-extern-c-fixes' of https://github.com/evelikov/linux into drm-next")
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

Thanks Arnd !

As Dave mentioned - the best solution would be to have the hunks
generated on the fly. Sadly Perl and me don't go hand in hand so if
you're interested I'll be really grateful.

-Emil
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

WARNING: multiple messages have this Message-ID (diff)
From: emil.l.velikov@gmail.com (Emil Velikov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] headers_check: don't warn about c++ guards
Date: Wed, 18 May 2016 21:20:29 +0100	[thread overview]
Message-ID: <CACvgo51FkfzzhFjYKyyHfxb-DyZeheQP2oZG-tWf1-EiBakp2w@mail.gmail.com> (raw)
In-Reply-To: <1463587653-3035181-2-git-send-email-arnd@arndb.de>

On 18 May 2016 at 17:07, Arnd Bergmann <arnd@arndb.de> wrote:
> A recent addition to the DRM tree for 4.7 added 'extern "C"' guards
> for c++ to all the DRM headers, and that now causes warnings
> in 'make headers_check':
>
> usr/include/drm/amdgpu_drm.h:38: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm.h:63: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm.h:699: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm_fourcc.h:30: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm_mode.h:33: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/drm_sarea.h:38: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/exynos_drm.h:21: userspace cannot reference function or variable defined in the kernel
> usr/include/drm/i810_drm.h:7: userspace cannot reference function or variable defined in the kernel
>
> This changes the headers_check.pl script to not warn about this.
> I'm listing the merge commit as introducing the problem, because
> there are several patches in this branch that each do this for
> one file.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7c10ddf87472 ("Merge branch 'drm-uapi-extern-c-fixes' of https://github.com/evelikov/linux into drm-next")
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

Thanks Arnd !

As Dave mentioned - the best solution would be to have the hunks
generated on the fly. Sadly Perl and me don't go hand in hand so if
you're interested I'll be really grateful.

-Emil

  reply	other threads:[~2016-05-18 20:21 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-18 16:07 [PATCH 0/5] drm: fixes for merge-window regressions Arnd Bergmann
2016-05-18 16:07 ` Arnd Bergmann
2016-05-18 16:07 ` Arnd Bergmann
2016-05-18 16:07 ` [PATCH 1/5] headers_check: don't warn about c++ guards Arnd Bergmann
2016-05-18 16:07   ` Arnd Bergmann
2016-05-18 16:07   ` Arnd Bergmann
2016-05-18 20:20   ` Emil Velikov [this message]
2016-05-18 20:20     ` Emil Velikov
2016-05-18 20:20     ` Emil Velikov
2016-05-18 16:07 ` [PATCH 2/5] drm: mediatek: add CONFIG_OF dependency Arnd Bergmann
2016-05-18 16:07   ` Arnd Bergmann
2016-05-18 16:07   ` Arnd Bergmann
2016-05-19 14:55   ` Matthias Brugger
2016-05-19 14:55     ` Matthias Brugger
2016-05-18 16:07 ` [PATCH 3/5] drm: mediatek: fixup drm_gem_object_lookup API change Arnd Bergmann
2016-05-18 16:07   ` Arnd Bergmann
2016-05-18 16:07   ` Arnd Bergmann
2016-05-19 14:56   ` Matthias Brugger
2016-05-19 14:56     ` Matthias Brugger
2016-05-18 16:07 ` [PATCH 4/5] drm: exynos: mark pm functions as __maybe_unused Arnd Bergmann
2016-05-18 16:07   ` Arnd Bergmann
2016-05-18 16:07   ` Arnd Bergmann
2016-05-18 16:07 ` [PATCH 5/5] drm: remove unused dev variables Arnd Bergmann
2016-05-18 16:07   ` Arnd Bergmann
2016-05-18 16:07   ` Arnd Bergmann
2016-05-18 17:17   ` Daniel Vetter
2016-05-18 17:17     ` Daniel Vetter
2016-05-18 17:17     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACvgo51FkfzzhFjYKyyHfxb-DyZeheQP2oZG-tWf1-EiBakp2w@mail.gmail.com \
    --to=emil.l.velikov@gmail.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=arnd@arndb.de \
    --cc=bskeggs@redhat.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=sw0312.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.