All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jordan Niethe <jniethe5@gmail.com>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: Jordan Niethe <jpn@linux.vnet.ibm.com>,
	linuxppc-dev@lists.ozlabs.org, mikey@neuling.org,
	kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
	sbhat@linux.ibm.com, vaibhav@linux.ibm.com
Subject: Re: [RFC PATCH v2 2/6] KVM: PPC: Add fpr getters and setters
Date: Sat, 10 Jun 2023 11:54:55 +1000	[thread overview]
Message-ID: <CACzsE9oNLp7eSDiNhTB_hWn1TSu9Obr2rNPgTyK7_fYGXvu5Fw@mail.gmail.com> (raw)
In-Reply-To: <CT6996Z3V83E.21I51JGIDHPOE@wheely>

On Wed, Jun 7, 2023 at 5:56 PM Nicholas Piggin <npiggin@gmail.com> wrote:
[snip]
>
> Is there a particular reason some reg sets are broken into their own
> patches? Looking at this hunk you think the VR one got missed, but it's
> in its own patch.
>
> Not really a big deal but I wouldn't mind them all in one patch. Or at
> least the FP/VR/VSR ine one since they're quite regular and similar.

There's not really a reason,

Originally I had things even more broken apart but then thought one
patch made
more sense. Part way through squashing the patches I had a change of
heart
and thought I'd see if people had a preference.

I'll just finish the squashing for the next series.

Thanks,
Jordan
>
> Thanks,
> Nick
>

WARNING: multiple messages have this Message-ID (diff)
From: Jordan Niethe <jniethe5@gmail.com>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: mikey@neuling.org, kvm@vger.kernel.org, sbhat@linux.ibm.com,
	kvm-ppc@vger.kernel.org, Jordan Niethe <jpn@linux.vnet.ibm.com>,
	vaibhav@linux.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH v2 2/6] KVM: PPC: Add fpr getters and setters
Date: Sat, 10 Jun 2023 11:54:55 +1000	[thread overview]
Message-ID: <CACzsE9oNLp7eSDiNhTB_hWn1TSu9Obr2rNPgTyK7_fYGXvu5Fw@mail.gmail.com> (raw)
In-Reply-To: <CT6996Z3V83E.21I51JGIDHPOE@wheely>

On Wed, Jun 7, 2023 at 5:56 PM Nicholas Piggin <npiggin@gmail.com> wrote:
[snip]
>
> Is there a particular reason some reg sets are broken into their own
> patches? Looking at this hunk you think the VR one got missed, but it's
> in its own patch.
>
> Not really a big deal but I wouldn't mind them all in one patch. Or at
> least the FP/VR/VSR ine one since they're quite regular and similar.

There's not really a reason,

Originally I had things even more broken apart but then thought one
patch made
more sense. Part way through squashing the patches I had a change of
heart
and thought I'd see if people had a preference.

I'll just finish the squashing for the next series.

Thanks,
Jordan
>
> Thanks,
> Nick
>

WARNING: multiple messages have this Message-ID (diff)
From: Jordan Niethe <jniethe5@gmail.com>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: Jordan Niethe <jpn@linux.vnet.ibm.com>,
	linuxppc-dev@lists.ozlabs.org, mikey@neuling.org,
	kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
	sbhat@linux.ibm.com, vaibhav@linux.ibm.com
Subject: Re: [RFC PATCH v2 2/6] KVM: PPC: Add fpr getters and setters
Date: Sat, 10 Jun 2023 01:54:55 +0000	[thread overview]
Message-ID: <CACzsE9oNLp7eSDiNhTB_hWn1TSu9Obr2rNPgTyK7_fYGXvu5Fw@mail.gmail.com> (raw)
In-Reply-To: <CT6996Z3V83E.21I51JGIDHPOE@wheely>

On Wed, Jun 7, 2023 at 5:56 PM Nicholas Piggin <npiggin@gmail.com> wrote:
[snip]
>
> Is there a particular reason some reg sets are broken into their own
> patches? Looking at this hunk you think the VR one got missed, but it's
> in its own patch.
>
> Not really a big deal but I wouldn't mind them all in one patch. Or at
> least the FP/VR/VSR ine one since they're quite regular and similar.

There's not really a reason,

Originally I had things even more broken apart but then thought one
patch made
more sense. Part way through squashing the patches I had a change of
heart
and thought I'd see if people had a preference.

I'll just finish the squashing for the next series.

Thanks,
Jordan
>
> Thanks,
> Nick
>

  reply	other threads:[~2023-06-10  1:55 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05  6:48 [RFC PATCH v2 0/6] KVM: PPC: Nested PAPR guests Jordan Niethe
2023-06-05  6:48 ` Jordan Niethe
2023-06-05  6:48 ` Jordan Niethe
2023-06-05  6:48 ` [RFC PATCH v2 1/6] KVM: PPC: Use getters and setters for vcpu register state Jordan Niethe
2023-06-05  6:48   ` Jordan Niethe
2023-06-05  6:48   ` Jordan Niethe
2023-06-07  7:51   ` Nicholas Piggin
2023-06-07  7:51     ` Nicholas Piggin
2023-06-07  7:51     ` Nicholas Piggin
2023-06-10  1:52     ` Jordan Niethe
2023-06-10  1:52       ` Jordan Niethe
2023-06-10  1:52       ` Jordan Niethe
2023-06-05  6:48 ` [RFC PATCH v2 2/6] KVM: PPC: Add fpr getters and setters Jordan Niethe
2023-06-05  6:48   ` Jordan Niethe
2023-06-05  6:48   ` Jordan Niethe
2023-06-07  7:55   ` Nicholas Piggin
2023-06-07  7:55     ` Nicholas Piggin
2023-06-07  7:55     ` Nicholas Piggin
2023-06-10  1:54     ` Jordan Niethe [this message]
2023-06-10  1:54       ` Jordan Niethe
2023-06-10  1:54       ` Jordan Niethe
2023-06-05  6:48 ` [RFC PATCH v2 3/6] KVM: PPC: Add vr " Jordan Niethe
2023-06-05  6:48   ` Jordan Niethe
2023-06-05  6:48   ` Jordan Niethe
2023-06-05  6:48 ` [RFC PATCH v2 4/6] KVM: PPC: Add helper library for Guest State Buffers Jordan Niethe
2023-06-05  6:48   ` Jordan Niethe
2023-06-05  6:48   ` Jordan Niethe
2023-06-07  8:26   ` Nicholas Piggin
2023-06-07  8:26     ` Nicholas Piggin
2023-06-07  8:26     ` Nicholas Piggin
2023-06-10  2:09     ` Jordan Niethe
2023-06-10  2:09       ` Jordan Niethe
2023-06-10  2:09       ` Jordan Niethe
2023-06-05  6:48 ` [RFC PATCH v2 5/6] KVM: PPC: Add support for nested PAPR guests Jordan Niethe
2023-06-05  6:48   ` Jordan Niethe
2023-06-05  6:48   ` Jordan Niethe
2023-06-07  9:08   ` Nicholas Piggin
2023-06-07  9:08     ` Nicholas Piggin
2023-06-07  9:08     ` Nicholas Piggin
2023-06-10  2:16     ` Jordan Niethe
2023-06-10  2:16       ` Jordan Niethe
2023-06-10  2:16       ` Jordan Niethe
2023-06-05  6:48 ` [RFC PATCH v2 6/6] docs: powerpc: Document nested KVM on POWER Jordan Niethe
2023-06-05  6:48   ` Jordan Niethe
2023-06-05  6:48   ` Jordan Niethe
2023-06-07  5:37   ` [PATCH RFC " Gautam Menghani
2023-06-07  5:49     ` Gautam Menghani
2023-06-07  5:37     ` Gautam Menghani
2023-06-10  1:39     ` Jordan Niethe
2023-06-10  1:39       ` Jordan Niethe
2023-06-10  1:39       ` Jordan Niethe
2023-06-07  5:53 ` [RFC PATCH v2 0/6] KVM: PPC: Nested PAPR guests Nicholas Piggin
2023-06-07  5:53   ` Nicholas Piggin
2023-06-07  5:53   ` Nicholas Piggin
2023-06-10  1:46   ` Jordan Niethe
2023-06-10  1:46     ` Jordan Niethe
2023-06-10  1:46     ` Jordan Niethe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACzsE9oNLp7eSDiNhTB_hWn1TSu9Obr2rNPgTyK7_fYGXvu5Fw@mail.gmail.com \
    --to=jniethe5@gmail.com \
    --cc=jpn@linux.vnet.ibm.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=npiggin@gmail.com \
    --cc=sbhat@linux.ibm.com \
    --cc=vaibhav@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.