From: Doug Anderson <dianders@chromium.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Brian Norris <briannorris@chromium.org>,
Heiko Stuebner <heiko@sntech.de>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Xing Zheng <zhengxing@rock-chips.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
linux-clk <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] clk: rockchip: fix the rk3399 sdmmc sample shift
Date: Fri, 13 May 2016 09:38:16 -0700 [thread overview]
Message-ID: <CAD=FV=UNVHrGeKj0N_1WQvL+PNBTrPTj1xmk-63F4hJhPuvkug@mail.gmail.com> (raw)
In-Reply-To: <0261c4b4-7398-fe15-5e26-f92bfbe79f3c@rock-chips.com>
Shawn,
On Fri, May 13, 2016 at 12:46 AM, Shawn Lin <shawn.lin@rock-chips.com> wrote:
>> This should be possible to verify in one of two ways. If the TRM has
>> a typo and things truly _do_ start at 0 instead of 1, then:
>>
>> 1. There will be roughly mirrors of valid ranges.
>> 2. Things won't match up if we change tuning to use 180 course offsets
>> and the rest fine offsets.
>>
>> It would be ideal if you could confirm with the chip guys, but if you
>
>
> I have checked it before Xing upstreamed the code, but as your question on
> the TRM, I check it with the chip guys again.
>
> So the answer is that drv/sample stuff should refer to Mobile Strorage
> Host Controller section, and it will fit the future Socs from now on.
OK, awesome. I also did more quick tests by forcing dw_mmc to give me
extra details about the tuning. These tests agree with you.
Please consider this patch abandoned. Note that the previous patch
(1/2) is still good as far as I know, so just this patch (2/2) should
be abandoned.
Thanks! :)
-Doug
WARNING: multiple messages have this Message-ID (diff)
From: dianders@chromium.org (Doug Anderson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] clk: rockchip: fix the rk3399 sdmmc sample shift
Date: Fri, 13 May 2016 09:38:16 -0700 [thread overview]
Message-ID: <CAD=FV=UNVHrGeKj0N_1WQvL+PNBTrPTj1xmk-63F4hJhPuvkug@mail.gmail.com> (raw)
In-Reply-To: <0261c4b4-7398-fe15-5e26-f92bfbe79f3c@rock-chips.com>
Shawn,
On Fri, May 13, 2016 at 12:46 AM, Shawn Lin <shawn.lin@rock-chips.com> wrote:
>> This should be possible to verify in one of two ways. If the TRM has
>> a typo and things truly _do_ start at 0 instead of 1, then:
>>
>> 1. There will be roughly mirrors of valid ranges.
>> 2. Things won't match up if we change tuning to use 180 course offsets
>> and the rest fine offsets.
>>
>> It would be ideal if you could confirm with the chip guys, but if you
>
>
> I have checked it before Xing upstreamed the code, but as your question on
> the TRM, I check it with the chip guys again.
>
> So the answer is that drv/sample stuff should refer to Mobile Strorage
> Host Controller section, and it will fit the future Socs from now on.
OK, awesome. I also did more quick tests by forcing dw_mmc to give me
extra details about the tuning. These tests agree with you.
Please consider this patch abandoned. Note that the previous patch
(1/2) is still good as far as I know, so just this patch (2/2) should
be abandoned.
Thanks! :)
-Doug
next prev parent reply other threads:[~2016-05-13 16:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 18:03 [PATCH 1/2] Revert "clk: rockchip: reset init state before mmc card initialization" Douglas Anderson
2016-05-12 18:03 ` Douglas Anderson
2016-05-12 18:03 ` [PATCH 2/2] clk: rockchip: fix the rk3399 sdmmc sample shift Douglas Anderson
2016-05-12 18:03 ` Douglas Anderson
2016-05-12 23:10 ` Brian Norris
2016-05-12 23:10 ` Brian Norris
2016-05-12 23:47 ` Shawn Lin
2016-05-12 23:47 ` Shawn Lin
2016-05-13 4:36 ` Doug Anderson
2016-05-13 4:36 ` Doug Anderson
2016-05-13 4:36 ` Doug Anderson
2016-05-13 4:36 ` Doug Anderson
2016-05-13 7:46 ` Shawn Lin
2016-05-13 7:46 ` Shawn Lin
2016-05-13 7:46 ` Shawn Lin
2016-05-13 16:38 ` Doug Anderson [this message]
2016-05-13 16:38 ` Doug Anderson
2016-05-13 16:38 ` Doug Anderson
2016-05-12 23:41 ` [PATCH 1/2] Revert "clk: rockchip: reset init state before mmc card initialization" Heiko Stuebner
2016-05-12 23:41 ` Heiko Stuebner
2016-05-13 2:11 ` Doug Anderson
2016-05-13 2:11 ` Doug Anderson
2016-05-13 2:11 ` Doug Anderson
2016-05-13 0:19 ` Shawn Lin
2016-05-13 0:19 ` Shawn Lin
2016-05-17 21:56 ` Heiko Stuebner
2016-05-17 21:56 ` Heiko Stuebner
2016-05-18 7:25 ` Shawn Lin
2016-05-18 7:25 ` Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=UNVHrGeKj0N_1WQvL+PNBTrPTj1xmk-63F4hJhPuvkug@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=briannorris@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=shawn.lin@rock-chips.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.