From: Doug Anderson <dianders@chromium.org>
To: Chris Zhong <zyw@rock-chips.com>
Cc: "Heiko Stübner" <heiko@sntech.de>,
"Mike Turquette" <mturquette@linaro.org>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Russell King" <linux@arm.linux.org.uk>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Kevin Hilman" <khilman@kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Kumar Gala" <galak@codeaurora.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 4/4] ARM: dts: rockchip: add suspend settings for rk3288-evb-rk808
Date: Wed, 26 Nov 2014 14:52:35 -0800 [thread overview]
Message-ID: <CAD=FV=V29zCpcEHE+rq6q_6SOZ_NOJgc5FiwmJ9jnRZK4mMUhw@mail.gmail.com> (raw)
In-Reply-To: <1416900743-29204-5-git-send-email-zyw@rock-chips.com>
Chris,
On Mon, Nov 24, 2014 at 11:32 PM, Chris Zhong <zyw@rock-chips.com> wrote:
> vcc_ddr: DCDC_REG3 {
> regulator-always-on;
> regulator-boot-on;
> regulator-name = "vcc_ddr";
> + regulator-suspend-mem-enabled;
The "regulator-suspend-mem-enabled" is not an upstream property and
isn't doing anything. It should be removed.
Possibly this is something Heiko could do when applying (depends on
what he wants) if no other spins are required.
> vcc_18: LDO_REG7 {
> @@ -128,6 +163,11 @@
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> regulator-name = "vcc_18";
> + regulator-suspend-mem-microvolt = <1800000>;
Another non-upstream property: regulator-suspend-mem-microvolt
WARNING: multiple messages have this Message-ID (diff)
From: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: Chris Zhong <zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
"Mike Turquette"
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Ian Campbell"
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
"Russell King" <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Pawel Moll" <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"Linus Walleij"
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Kevin Hilman" <khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"Kumar Gala" <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v9 4/4] ARM: dts: rockchip: add suspend settings for rk3288-evb-rk808
Date: Wed, 26 Nov 2014 14:52:35 -0800 [thread overview]
Message-ID: <CAD=FV=V29zCpcEHE+rq6q_6SOZ_NOJgc5FiwmJ9jnRZK4mMUhw@mail.gmail.com> (raw)
In-Reply-To: <1416900743-29204-5-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Chris,
On Mon, Nov 24, 2014 at 11:32 PM, Chris Zhong <zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org> wrote:
> vcc_ddr: DCDC_REG3 {
> regulator-always-on;
> regulator-boot-on;
> regulator-name = "vcc_ddr";
> + regulator-suspend-mem-enabled;
The "regulator-suspend-mem-enabled" is not an upstream property and
isn't doing anything. It should be removed.
Possibly this is something Heiko could do when applying (depends on
what he wants) if no other spins are required.
> vcc_18: LDO_REG7 {
> @@ -128,6 +163,11 @@
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> regulator-name = "vcc_18";
> + regulator-suspend-mem-microvolt = <1800000>;
Another non-upstream property: regulator-suspend-mem-microvolt
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: dianders@chromium.org (Doug Anderson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 4/4] ARM: dts: rockchip: add suspend settings for rk3288-evb-rk808
Date: Wed, 26 Nov 2014 14:52:35 -0800 [thread overview]
Message-ID: <CAD=FV=V29zCpcEHE+rq6q_6SOZ_NOJgc5FiwmJ9jnRZK4mMUhw@mail.gmail.com> (raw)
In-Reply-To: <1416900743-29204-5-git-send-email-zyw@rock-chips.com>
Chris,
On Mon, Nov 24, 2014 at 11:32 PM, Chris Zhong <zyw@rock-chips.com> wrote:
> vcc_ddr: DCDC_REG3 {
> regulator-always-on;
> regulator-boot-on;
> regulator-name = "vcc_ddr";
> + regulator-suspend-mem-enabled;
The "regulator-suspend-mem-enabled" is not an upstream property and
isn't doing anything. It should be removed.
Possibly this is something Heiko could do when applying (depends on
what he wants) if no other spins are required.
> vcc_18: LDO_REG7 {
> @@ -128,6 +163,11 @@
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> regulator-name = "vcc_18";
> + regulator-suspend-mem-microvolt = <1800000>;
Another non-upstream property: regulator-suspend-mem-microvolt
next prev parent reply other threads:[~2014-11-26 22:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 7:32 [PATCH v9 0/4] The 1st version of suspend for RK3288 Chris Zhong
2014-11-25 7:32 ` Chris Zhong
2014-11-25 7:32 ` [PATCH v9 1/4] ARM: rockchip: add suspend and resume " Chris Zhong
2014-11-25 7:32 ` Chris Zhong
2014-11-25 7:32 ` [PATCH v9 2/4] ARM: rockchip: Add pmu-sram binding Chris Zhong
2014-11-25 7:32 ` [PATCH v9 3/4] ARM: dts: add RK3288 suspend support Chris Zhong
2014-11-25 7:32 ` Chris Zhong
2014-12-01 5:26 ` Doug Anderson
2014-12-01 5:26 ` Doug Anderson
2014-12-01 5:26 ` Doug Anderson
2014-12-01 8:56 ` Chris Zhong
2014-12-01 8:56 ` Chris Zhong
2014-11-25 7:32 ` [PATCH v9 4/4] ARM: dts: rockchip: add suspend settings for rk3288-evb-rk808 Chris Zhong
2014-11-25 7:32 ` Chris Zhong
2014-11-26 22:52 ` Doug Anderson [this message]
2014-11-26 22:52 ` Doug Anderson
2014-11-26 22:52 ` Doug Anderson
2014-11-27 0:56 ` Chris Zhong
2014-11-27 0:56 ` Chris Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=V29zCpcEHE+rq6q_6SOZ_NOJgc5FiwmJ9jnRZK4mMUhw@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.