From: Doug Anderson <dianders@chromium.org>
To: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, broonie@kernel.org,
linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_msavaliy@quicinc.com,
mka@chromium.org, swboyd@chromium.org, quic_vtanuku@quicinc.com,
dan.carpenter@linaro.org
Subject: Re: [PATCH 4/4] spi: spi-qcom-qspi: Add DMA_CHAIN_DONE to ALL_IRQS
Date: Tue, 25 Jul 2023 10:58:21 -0700 [thread overview]
Message-ID: <CAD=FV=X+LULPZW7fccz2aMqfrR=fuOvBAb7LN-mGYeppuxAQZw@mail.gmail.com> (raw)
In-Reply-To: <1690285689-30233-5-git-send-email-quic_vnivarth@quicinc.com>
Hi,
On Tue, Jul 25, 2023 at 4:48 AM Vijaya Krishna Nivarthi
<quic_vnivarth@quicinc.com> wrote:
>
> Add latest added DMA_CHAIN_DONE irq to QSPI_ALL_IRQS that encompasses all
> of the qspi IRQs.
>
> Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
> ---
> drivers/spi/spi-qcom-qspi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I don't think this really does anything since the interrupts shouldn't
really be "hanging around" when a PIO transfer starts and that's the
only place it's used. I suspect we could actually fully remove that
bit of "Ack any previous interrupts that might be hanging around" code
and everything would be fine.
In any case, I don't have any huge objections, thus:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2023-07-25 17:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 11:48 [PATCH 0/4] spi: spi-qcom-qspi: Follow-up patches to DMA mode support Vijaya Krishna Nivarthi
2023-07-25 11:48 ` [PATCH 1/4] spi: spi-qcom-qspi: Ignore disabled interrupts' status in isr Vijaya Krishna Nivarthi
2023-07-25 17:57 ` Doug Anderson
2023-07-25 11:48 ` [PATCH 2/4] spi: spi-qcom-qspi: Use GFP_ATOMIC flag while allocating for descriptor Vijaya Krishna Nivarthi
2023-07-25 17:58 ` Doug Anderson
2023-07-25 11:48 ` [PATCH 3/4] spi: spi-qcom-qspi: Call dma_wmb() after setting up descriptors Vijaya Krishna Nivarthi
2023-07-25 17:58 ` Doug Anderson
2023-07-25 11:48 ` [PATCH 4/4] spi: spi-qcom-qspi: Add DMA_CHAIN_DONE to ALL_IRQS Vijaya Krishna Nivarthi
2023-07-25 17:58 ` Doug Anderson [this message]
2023-07-25 20:36 ` [PATCH 0/4] spi: spi-qcom-qspi: Follow-up patches to DMA mode support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=X+LULPZW7fccz2aMqfrR=fuOvBAb7LN-mGYeppuxAQZw@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mka@chromium.org \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vnivarth@quicinc.com \
--cc=quic_vtanuku@quicinc.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.