From: Doug Anderson <dianders@chromium.org>
To: Rakesh Pillai <pillair@codeaurora.org>,
Kalle Valo <kvalo@codeaurora.org>
Cc: ath10k@lists.infradead.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990
Date: Fri, 26 Jun 2020 14:46:57 -0700 [thread overview]
Message-ID: <CAD=FV=X+v1TpZQPBZNV_Azt8J=0ZJw+XGJhLbnBxaZJGCCPwVg@mail.gmail.com> (raw)
In-Reply-To: <1593194502-13164-2-git-send-email-pillair@codeaurora.org>
Hi,
On Fri, Jun 26, 2020 at 11:02 AM Rakesh Pillai <pillair@codeaurora.org> wrote:
>
> Add an additional regulator supply as an optional
> property for WCN3990.
>
> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
>
> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> ---
> Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Overall though: aren't you missing a whole lot of CCs? Have you tried
using get_maintainer?
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> index 65ee68e..b7188d3 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> @@ -65,7 +65,8 @@ Optional properties:
> the length can vary between hw versions.
> - <supply-name>-supply: handle to the regulator device tree node
> optional "supply-name" are "vdd-0.8-cx-mx",
> - "vdd-1.8-xo", "vdd-1.3-rfa" and "vdd-3.3-ch0".
> + "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0"
> + and "vdd-3.3-ch1".
nit that could probably be fixed by maintainer when applying: missing
comma at the end of "vdd-3.3-ch0"
I will also note that this file is in dire need of being converted to
yaml. Pretty soon I think people are going to start disallowing
changes to the bindings that haven't been converted to yaml so you
probably want to get a jump start on it so future patches aren't
stalled.
In any case:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Doug Anderson <dianders@chromium.org>
To: Rakesh Pillai <pillair@codeaurora.org>,
Kalle Valo <kvalo@codeaurora.org>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
ath10k@lists.infradead.org
Subject: Re: [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990
Date: Fri, 26 Jun 2020 14:46:57 -0700 [thread overview]
Message-ID: <CAD=FV=X+v1TpZQPBZNV_Azt8J=0ZJw+XGJhLbnBxaZJGCCPwVg@mail.gmail.com> (raw)
In-Reply-To: <1593194502-13164-2-git-send-email-pillair@codeaurora.org>
Hi,
On Fri, Jun 26, 2020 at 11:02 AM Rakesh Pillai <pillair@codeaurora.org> wrote:
>
> Add an additional regulator supply as an optional
> property for WCN3990.
>
> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
>
> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> ---
> Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Overall though: aren't you missing a whole lot of CCs? Have you tried
using get_maintainer?
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> index 65ee68e..b7188d3 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> @@ -65,7 +65,8 @@ Optional properties:
> the length can vary between hw versions.
> - <supply-name>-supply: handle to the regulator device tree node
> optional "supply-name" are "vdd-0.8-cx-mx",
> - "vdd-1.8-xo", "vdd-1.3-rfa" and "vdd-3.3-ch0".
> + "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0"
> + and "vdd-3.3-ch1".
nit that could probably be fixed by maintainer when applying: missing
comma at the end of "vdd-3.3-ch0"
I will also note that this file is in dire need of being converted to
yaml. Pretty soon I think people are going to start disallowing
changes to the bindings that haven't been converted to yaml so you
probably want to get a jump start on it so future patches aren't
stalled.
In any case:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2020-06-26 21:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 18:01 [PATCH 0/2] ath10k: Add chain-1 voltage regulator voting Rakesh Pillai
2020-06-26 18:01 ` Rakesh Pillai
2020-06-26 18:01 ` [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990 Rakesh Pillai
2020-06-26 18:01 ` Rakesh Pillai
2020-06-26 21:46 ` Doug Anderson [this message]
2020-06-26 21:46 ` Doug Anderson
2020-07-15 20:21 ` Rob Herring
2020-07-15 20:21 ` Rob Herring
2020-09-08 5:43 ` Kalle Valo
2020-09-08 5:43 ` Kalle Valo
2020-06-26 18:01 ` [PATCH 2/2] ath10k: Add support for chain1 regulator supply voting Rakesh Pillai
2020-06-26 18:01 ` Rakesh Pillai
2020-06-26 21:51 ` Doug Anderson
2020-06-26 21:51 ` Doug Anderson
2020-06-29 12:13 ` Rakesh Pillai
2020-06-29 12:13 ` Rakesh Pillai
2020-06-29 14:33 ` Doug Anderson
2020-06-29 14:33 ` Doug Anderson
2020-08-24 23:50 ` [PATCH 0/2] ath10k: Add chain-1 voltage regulator voting Doug Anderson
2020-08-24 23:50 ` Doug Anderson
2020-09-07 16:10 ` Kalle Valo
2020-09-07 16:10 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=X+v1TpZQPBZNV_Azt8J=0ZJw+XGJhLbnBxaZJGCCPwVg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=ath10k@lists.infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pillair@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.