From: Doug Anderson <dianders@chromium.org>
To: Chris Ball <cjb@laptop.org>
Cc: Olof Johansson <olof@lixom.net>,
Andrew Bresticker <abrestic@chromium.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Abhilash Kesavan <a.kesavan@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Seungwon Jeon <tgih.jun@samsung.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>,
Will Newton <will.newton@gmail.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
linux-doc@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] mmc: dw_mmc: Handle late vmmc regulators with EPROBE_DEFER
Date: Thu, 27 Jun 2013 10:10:26 -0700 [thread overview]
Message-ID: <CAD=FV=X8qVAeD_F-kQLHcgusY65pw4WCs5mMsO0wTapqBUAiQw@mail.gmail.com> (raw)
In-Reply-To: <87vc4zlczt.fsf@octavius.laptop.org>
Chris,
On Thu, Jun 27, 2013 at 9:44 AM, Chris Ball <cjb@laptop.org> wrote:
> This hunk breaks the build for me, because err_setup_bus and ret are
> used in the error path of the call to mmc_add_host() in this function.
>
> I'll push a version that leaves those in. Let me know if you think
> something strange is happening that made this work okay for you, like
> a mismerge.
WTF. OK, this is clearly my fault. I went back to the exact patch
and it didn't compile for me, either. :( My typical workflow is to
develop something in our local tree and then cherry-pick (and test!)
on ToT linux. Probably what happened in this case was that there was
a compile error and I didn't notice and somehow ended up testing my
local tree (which doesn't error-check mmc_add_host).
Sorry for the hassle. Leaving the err_setup_bus in is correct (and
leaving the "ret" variable declared).
I did those fixups and it now compiles and things boot. I haven't
tested the deferral case in ToT yet, though. I'll try that now and
post if something weird comes up.
-Doug
next prev parent reply other threads:[~2013-06-27 17:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 4:46 [PATCH 1/2] mmc: dw_mmc: Handle late vmmc regulator with EPROBE_DEFER Doug Anderson
2013-06-07 4:46 ` Doug Anderson
2013-06-07 4:46 ` [PATCH 2/2] mmc: dw_mmc: Add the ability to set the ciu clock frequency Doug Anderson
2013-06-07 4:46 ` Doug Anderson
2013-06-07 5:35 ` Jaehoon Chung
2013-06-07 10:19 ` [PATCH 1/2] mmc: dw_mmc: Handle late vmmc regulator with EPROBE_DEFER Tomasz Figa
2013-06-07 10:24 ` Mark Brown
2013-06-07 10:24 ` Mark Brown
2013-06-07 10:30 ` Tomasz Figa
2013-06-07 15:01 ` Doug Anderson
2013-06-07 15:01 ` Doug Anderson
2013-06-07 17:28 ` [PATCH v2 1/2] mmc: dw_mmc: Handle late vmmc regulators " Doug Anderson
2013-06-07 17:28 ` [PATCH v2 2/2] mmc: dw_mmc: Add the ability to set the ciu clock frequency Doug Anderson
2013-06-18 4:51 ` Jaehoon Chung
2013-06-18 15:15 ` Doug Anderson
2013-06-18 15:15 ` Doug Anderson
2013-06-20 1:52 ` Jaehoon Chung
2013-06-20 1:52 ` Jaehoon Chung
2013-06-27 15:36 ` Chris Ball
2013-06-07 17:42 ` [PATCH v2 1/2] mmc: dw_mmc: Handle late vmmc regulators with EPROBE_DEFER Tomasz Figa
2013-06-07 18:14 ` Doug Anderson
2013-06-07 18:14 ` Doug Anderson
2013-06-27 15:34 ` Chris Ball
2013-06-27 16:44 ` Chris Ball
2013-06-27 17:10 ` Doug Anderson [this message]
2013-06-27 17:10 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=X8qVAeD_F-kQLHcgusY65pw4WCs5mMsO0wTapqBUAiQw@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=a.kesavan@samsung.com \
--cc=abrestic@chromium.org \
--cc=alim.akhtar@samsung.com \
--cc=cjb@laptop.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=tgih.jun@samsung.com \
--cc=tomasz.figa@gmail.com \
--cc=will.newton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.