From: Joel A Fernandes <agnel.joel@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Sekhar Nori <nsekhar@ti.com>, Joel A Fernandes <joelagnel@ti.com>,
Tony Lindgren <tony@atomide.com>, Matt Porter <matt@ohporter.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Vinod Koul <vinod.koul@intel.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Benoit Cousson <b-cousson@ti.com>,
Russell King <linux@arm.linux.org.uk>,
Rob Landley <rob@landley.net>,
Andrew Morton <akpm@linux-foundation.org>,
Jason Kridner <jkridner@beagleboard.org>,
Koen Kooi <koen@beagleboard.org>,
Devicetree Discuss <devicetree-discuss@lists.ozlabs.org>,
Linux OMAP List <linux-omap@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux DaVinci Kernel List
<davinci-linux-open-source@linux.davincidsp.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Documentation List <linux-doc@vger.kernel.org>,
Linux MMC List <linux-mmc@vger.kernel.org>,
Linux SPI Devel List <spi-devel-general@lists.sourceforge.net>
Subject: Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA
Date: Fri, 21 Jun 2013 09:20:01 -0500 [thread overview]
Message-ID: <CAD=GYpZ_5Lp1La=f+2BQfmuj+sc3FgygZRD4gfj4JGGZ0Do=_Q@mail.gmail.com> (raw)
In-Reply-To: <201306211600.04986.arnd@arndb.de>
On Fri, Jun 21, 2013 at 9:00 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 21 June 2013, Joel A Fernandes wrote:
>> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> >> index b1c66a4..7d58cd9 100644
>> >> --- a/arch/arm/Kconfig
>> >> +++ b/arch/arm/Kconfig
>> >> @@ -841,6 +841,7 @@ config ARCH_DAVINCI
>> >> select HAVE_IDE
>> >> select NEED_MACH_GPIO_H
>> >> select TI_PRIV_EDMA
>> >> + select DMADEVICES
>> >
>> > It is generally a bad idea to force select on something that can be
>> > enabled using menuconfig. Unless used carefully, select causes "unmet
>> > direct dependency" warnings which folks are already fighting hard to
>> > fix. This leads to what Russell referred in the past as "select madness" [1]
>>
>> Are you concerned with bloat issues? I know your point of view but the idea
>> was to build these options by default for these platforms even though
>> in some cases
>> it might not be used. I have seen folks including myself select the wrong
>> option. Having the build system automatically select the correct option for the
>> most common cases can be very useful I feel and not require manual
>> configuration.
>
> For defaults, you should use the defconfig, not 'select' in Kconfig.
>
> A lot of the 'select' statements are actually wrong because they
> do not take dependencies into account where A selects B but not C,
> and B depends on C, which leads to broken builds when C is disabled
> by a user (or randconfig).
I haven't come across this problem but- are you saying there is a
shortcoming in Kbuild/Kconfig that selects an option even if its
dependency is not met?
The problem with defconfig is also too many options I feel for a common case.
CONFIG_DMADEVICES=y
CONFIG_TI_EDMA=y
Most if not all future OMAPs from will use EDMA. Why not we can be
explicit about it and just built it in anyway. If ARCH_OMAP and
DMADEVICES are selected, then we can just build EDMA in by default.
I agree maybe the option can be dropped from Davinci but I suggest
let's keep it for OMAP. Is that ok?
Thanks,
Joel
WARNING: multiple messages have this Message-ID (diff)
From: Joel A Fernandes <agnel.joel@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Sekhar Nori <nsekhar@ti.com>, Joel A Fernandes <joelagnel@ti.com>,
Tony Lindgren <tony@atomide.com>, Matt Porter <matt@ohporter.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Vinod Koul <vinod.koul@intel.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Benoit Cousson <b-cousson@ti.com>,
Russell King <linux@arm.linux.org.uk>,
Rob Landley <rob@landley.net>,
Andrew Morton <akpm@linux-foundation.org>,
Jason Kridner <jkridner@beagleboard.org>,
Koen Kooi <koen@beagleboard.org>,
Devicetree Discuss <devicetree-discuss@lists.ozlabs.org>,
Linux OMAP List <linux-omap@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux DaVinci Kernel List
<davinci-linux-open-source@linux.davincidsp.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Documentation List <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA
Date: Fri, 21 Jun 2013 09:20:01 -0500 [thread overview]
Message-ID: <CAD=GYpZ_5Lp1La=f+2BQfmuj+sc3FgygZRD4gfj4JGGZ0Do=_Q@mail.gmail.com> (raw)
In-Reply-To: <201306211600.04986.arnd@arndb.de>
On Fri, Jun 21, 2013 at 9:00 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 21 June 2013, Joel A Fernandes wrote:
>> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> >> index b1c66a4..7d58cd9 100644
>> >> --- a/arch/arm/Kconfig
>> >> +++ b/arch/arm/Kconfig
>> >> @@ -841,6 +841,7 @@ config ARCH_DAVINCI
>> >> select HAVE_IDE
>> >> select NEED_MACH_GPIO_H
>> >> select TI_PRIV_EDMA
>> >> + select DMADEVICES
>> >
>> > It is generally a bad idea to force select on something that can be
>> > enabled using menuconfig. Unless used carefully, select causes "unmet
>> > direct dependency" warnings which folks are already fighting hard to
>> > fix. This leads to what Russell referred in the past as "select madness" [1]
>>
>> Are you concerned with bloat issues? I know your point of view but the idea
>> was to build these options by default for these platforms even though
>> in some cases
>> it might not be used. I have seen folks including myself select the wrong
>> option. Having the build system automatically select the correct option for the
>> most common cases can be very useful I feel and not require manual
>> configuration.
>
> For defaults, you should use the defconfig, not 'select' in Kconfig.
>
> A lot of the 'select' statements are actually wrong because they
> do not take dependencies into account where A selects B but not C,
> and B depends on C, which leads to broken builds when C is disabled
> by a user (or randconfig).
I haven't come across this problem but- are you saying there is a
shortcoming in Kbuild/Kconfig that selects an option even if its
dependency is not met?
The problem with defconfig is also too many options I feel for a common case.
CONFIG_DMADEVICES=y
CONFIG_TI_EDMA=y
Most if not all future OMAPs from will use EDMA. Why not we can be
explicit about it and just built it in anyway. If ARCH_OMAP and
DMADEVICES are selected, then we can just build EDMA in by default.
I agree maybe the option can be dropped from Davinci but I suggest
let's keep it for OMAP. Is that ok?
Thanks,
Joel
WARNING: multiple messages have this Message-ID (diff)
From: agnel.joel@gmail.com (Joel A Fernandes)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v12 05/11] edma: config: Enable config options for EDMA
Date: Fri, 21 Jun 2013 09:20:01 -0500 [thread overview]
Message-ID: <CAD=GYpZ_5Lp1La=f+2BQfmuj+sc3FgygZRD4gfj4JGGZ0Do=_Q@mail.gmail.com> (raw)
In-Reply-To: <201306211600.04986.arnd@arndb.de>
On Fri, Jun 21, 2013 at 9:00 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 21 June 2013, Joel A Fernandes wrote:
>> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> >> index b1c66a4..7d58cd9 100644
>> >> --- a/arch/arm/Kconfig
>> >> +++ b/arch/arm/Kconfig
>> >> @@ -841,6 +841,7 @@ config ARCH_DAVINCI
>> >> select HAVE_IDE
>> >> select NEED_MACH_GPIO_H
>> >> select TI_PRIV_EDMA
>> >> + select DMADEVICES
>> >
>> > It is generally a bad idea to force select on something that can be
>> > enabled using menuconfig. Unless used carefully, select causes "unmet
>> > direct dependency" warnings which folks are already fighting hard to
>> > fix. This leads to what Russell referred in the past as "select madness" [1]
>>
>> Are you concerned with bloat issues? I know your point of view but the idea
>> was to build these options by default for these platforms even though
>> in some cases
>> it might not be used. I have seen folks including myself select the wrong
>> option. Having the build system automatically select the correct option for the
>> most common cases can be very useful I feel and not require manual
>> configuration.
>
> For defaults, you should use the defconfig, not 'select' in Kconfig.
>
> A lot of the 'select' statements are actually wrong because they
> do not take dependencies into account where A selects B but not C,
> and B depends on C, which leads to broken builds when C is disabled
> by a user (or randconfig).
I haven't come across this problem but- are you saying there is a
shortcoming in Kbuild/Kconfig that selects an option even if its
dependency is not met?
The problem with defconfig is also too many options I feel for a common case.
CONFIG_DMADEVICES=y
CONFIG_TI_EDMA=y
Most if not all future OMAPs from will use EDMA. Why not we can be
explicit about it and just built it in anyway. If ARCH_OMAP and
DMADEVICES are selected, then we can just build EDMA in by default.
I agree maybe the option can be dropped from Davinci but I suggest
let's keep it for OMAP. Is that ok?
Thanks,
Joel
next prev parent reply other threads:[~2013-06-21 14:20 UTC|newest]
Thread overview: 203+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 21:06 [PATCH v12 00/11] DMA Engine support for AM33XX Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-20 21:06 ` [PATCH v12 01/11] dmaengine: edma: Add TI EDMA device tree binding Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-20 21:06 ` [PATCH v12 02/11] ARM: edma: Add DT and runtime PM support to the private EDMA API Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-21 9:37 ` Sekhar Nori
2013-06-21 9:37 ` Sekhar Nori
2013-06-21 9:37 ` Sekhar Nori
2013-06-21 9:37 ` Sekhar Nori
2013-06-21 9:53 ` [PATCH v13] " Sekhar Nori
2013-06-21 9:53 ` Sekhar Nori
2013-06-21 9:53 ` Sekhar Nori
2013-06-21 9:53 ` Sekhar Nori
2013-06-24 10:06 ` Sekhar Nori
2013-06-24 10:06 ` Sekhar Nori
2013-06-24 10:06 ` Sekhar Nori
2013-06-24 10:06 ` Sekhar Nori
2013-06-21 13:37 ` [PATCH v12 02/11] " Joel A Fernandes
2013-06-21 13:37 ` Joel A Fernandes
2013-06-21 13:37 ` Joel A Fernandes
2013-06-21 13:37 ` Joel A Fernandes
2013-06-20 21:06 ` [PATCH v12 03/11] ARM: edma: Add EDMA crossbar event mux support Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-21 10:12 ` Sekhar Nori
2013-06-21 10:12 ` Sekhar Nori
2013-06-21 10:12 ` Sekhar Nori
2013-06-21 10:12 ` Sekhar Nori
2013-06-21 10:14 ` [PATCH] " Sekhar Nori
2013-06-21 10:14 ` Sekhar Nori
2013-06-21 10:14 ` Sekhar Nori
2013-06-21 10:14 ` Sekhar Nori
2013-06-20 21:06 ` [PATCH v12 04/11] dmaengine: edma: enable build for AM33XX Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-21 10:15 ` Sekhar Nori
2013-06-21 10:15 ` Sekhar Nori
2013-06-21 10:15 ` Sekhar Nori
2013-06-21 10:15 ` Sekhar Nori
2013-06-24 10:17 ` Tony Lindgren
2013-06-24 10:17 ` Tony Lindgren
2013-06-24 10:17 ` Tony Lindgren
2013-06-24 10:17 ` Tony Lindgren
2013-06-24 10:31 ` Sekhar Nori
2013-06-24 10:31 ` Sekhar Nori
2013-06-24 10:31 ` Sekhar Nori
2013-06-24 10:31 ` Sekhar Nori
2013-06-20 21:06 ` [PATCH v12 05/11] edma: config: Enable config options for EDMA Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-21 10:16 ` Sekhar Nori
2013-06-21 10:16 ` Sekhar Nori
2013-06-21 10:16 ` Sekhar Nori
2013-06-21 10:16 ` Sekhar Nori
2013-06-21 13:52 ` Joel A Fernandes
2013-06-21 13:52 ` Joel A Fernandes
2013-06-21 13:52 ` Joel A Fernandes
2013-06-21 13:52 ` Joel A Fernandes
2013-06-21 14:00 ` Arnd Bergmann
2013-06-21 14:00 ` Arnd Bergmann
2013-06-21 14:00 ` Arnd Bergmann
2013-06-21 14:00 ` Arnd Bergmann
2013-06-21 14:20 ` Joel A Fernandes [this message]
2013-06-21 14:20 ` Joel A Fernandes
2013-06-21 14:20 ` Joel A Fernandes
2013-06-21 14:32 ` Arnd Bergmann
2013-06-21 14:32 ` Arnd Bergmann
2013-06-21 14:32 ` Arnd Bergmann
2013-06-21 18:40 ` Joel A Fernandes
2013-06-21 18:40 ` Joel A Fernandes
2013-06-21 18:40 ` Joel A Fernandes
2013-06-21 18:44 ` Arnd Bergmann
2013-06-21 18:44 ` Arnd Bergmann
2013-06-21 18:44 ` Arnd Bergmann
2013-06-21 21:53 ` Joel A Fernandes
2013-06-21 21:53 ` Joel A Fernandes
2013-06-21 21:53 ` Joel A Fernandes
2013-06-21 22:14 ` Arnd Bergmann
2013-06-21 22:14 ` Arnd Bergmann
2013-06-21 22:14 ` Arnd Bergmann
2013-06-22 2:53 ` Joel A Fernandes
2013-06-22 2:53 ` Joel A Fernandes
2013-06-22 2:53 ` Joel A Fernandes
2013-06-22 2:53 ` Joel A Fernandes
2013-06-24 11:53 ` Sekhar Nori
2013-06-24 11:53 ` Sekhar Nori
2013-06-24 11:53 ` Sekhar Nori
2013-06-24 11:53 ` Sekhar Nori
2013-06-24 14:48 ` Joel A Fernandes
2013-06-24 14:48 ` Joel A Fernandes
2013-06-24 14:48 ` Joel A Fernandes
2013-06-24 14:48 ` Joel A Fernandes
2013-06-24 20:28 ` Arnd Bergmann
2013-06-24 20:28 ` Arnd Bergmann
2013-06-24 20:28 ` Arnd Bergmann
2013-06-24 20:28 ` Arnd Bergmann
2013-06-24 20:32 ` Joel A Fernandes
2013-06-24 20:32 ` Joel A Fernandes
2013-06-24 20:32 ` Joel A Fernandes
2013-06-24 21:07 ` Arnd Bergmann
2013-06-24 21:07 ` Arnd Bergmann
2013-06-24 21:07 ` Arnd Bergmann
2013-06-24 21:09 ` Fernandes, Joel A
2013-06-24 21:09 ` Fernandes, Joel A
2013-06-24 21:09 ` Fernandes, Joel A
2013-06-24 21:09 ` Fernandes, Joel A
2013-06-24 11:23 ` Sekhar Nori
2013-06-24 11:23 ` Sekhar Nori
2013-06-24 11:23 ` Sekhar Nori
2013-06-24 11:23 ` Sekhar Nori
2013-06-24 11:34 ` Sekhar Nori
2013-06-24 11:34 ` Sekhar Nori
2013-06-24 11:34 ` Sekhar Nori
2013-06-24 11:34 ` Sekhar Nori
2013-06-24 20:10 ` Joel A Fernandes
2013-06-24 20:10 ` Joel A Fernandes
2013-06-24 20:10 ` Joel A Fernandes
2013-06-24 20:10 ` Joel A Fernandes
2013-06-20 21:06 ` [PATCH v12 06/11] da8xx: config: Enable MMC and FS options Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-20 21:06 ` [PATCH v12 07/11] ARM: davinci: Fix compiler warnings in devices-da8xx Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-20 21:06 ` [PATCH v12 08/11] spi: omap2-mcspi: add generic DMA request support to the DT binding Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-21 10:35 ` Sourav Poddar
2013-06-21 10:35 ` Sourav Poddar
2013-06-21 10:35 ` Sourav Poddar
2013-06-21 10:35 ` Sourav Poddar
2013-06-20 21:06 ` [PATCH v12 09/11] spi: omap2-mcspi: convert to dma_request_slave_channel_compat() Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-21 10:26 ` Sourav Poddar
2013-06-21 10:26 ` Sourav Poddar
2013-06-21 10:26 ` Sourav Poddar
2013-06-21 10:26 ` Sourav Poddar
2013-06-21 10:37 ` Sekhar Nori
2013-06-21 10:37 ` Sekhar Nori
2013-06-21 10:37 ` Sekhar Nori
2013-06-21 10:37 ` Sekhar Nori
2013-06-21 11:28 ` Mark Brown
2013-06-21 11:28 ` Mark Brown
2013-06-21 11:28 ` Mark Brown
2013-06-21 11:28 ` Mark Brown
2013-06-21 12:22 ` Sourav Poddar
2013-06-21 12:22 ` Sourav Poddar
2013-06-21 12:22 ` Sourav Poddar
2013-06-21 12:22 ` Sourav Poddar
2013-06-20 21:06 ` [PATCH v12 10/11] ARM: dts: add AM33XX EDMA support Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-08-19 14:22 ` Sebastian Andrzej Siewior
2013-08-19 14:22 ` Sebastian Andrzej Siewior
2013-08-19 14:22 ` Sebastian Andrzej Siewior
2013-08-19 14:22 ` Sebastian Andrzej Siewior
2013-06-20 21:06 ` [PATCH v12 11/11] ARM: dts: add AM33XX SPI DMA support Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-20 21:06 ` Joel A Fernandes
2013-06-21 10:27 ` [PATCH v12 00/11] DMA Engine support for AM33XX Sekhar Nori
2013-06-21 10:27 ` Sekhar Nori
2013-06-21 10:27 ` Sekhar Nori
2013-06-21 10:27 ` Sekhar Nori
2013-06-22 0:07 ` Joel A Fernandes
2013-06-22 0:07 ` Joel A Fernandes
2013-06-22 0:07 ` Joel A Fernandes
2013-06-22 0:07 ` Joel A Fernandes
2013-06-22 3:36 ` Joel A Fernandes
2013-06-22 3:36 ` Joel A Fernandes
2013-06-22 3:36 ` Joel A Fernandes
2013-06-22 3:36 ` Joel A Fernandes
2013-06-24 10:19 ` Tony Lindgren
2013-06-24 10:19 ` Tony Lindgren
2013-06-24 10:19 ` Tony Lindgren
2013-06-24 10:19 ` Tony Lindgren
2013-06-24 11:39 ` Sekhar Nori
2013-06-24 11:39 ` Sekhar Nori
2013-06-24 11:39 ` Sekhar Nori
2013-06-24 11:39 ` Sekhar Nori
2013-06-24 11:48 ` Sourav Poddar
2013-06-24 11:48 ` Sourav Poddar
2013-06-24 11:48 ` Sourav Poddar
2013-06-24 11:48 ` Sourav Poddar
2013-06-24 14:36 ` Benoit Cousson
2013-06-24 14:36 ` Benoit Cousson
2013-06-24 14:36 ` Benoit Cousson
2013-06-24 14:36 ` Benoit Cousson
2013-06-25 6:54 ` Tony Lindgren
2013-06-25 6:54 ` Tony Lindgren
2013-06-25 6:54 ` Tony Lindgren
2013-06-25 6:54 ` Tony Lindgren
2013-06-25 14:16 ` Sekhar Nori
2013-06-25 14:16 ` Sekhar Nori
2013-06-25 14:16 ` Sekhar Nori
2013-06-25 14:42 ` Santosh Shilimkar
2013-06-25 14:42 ` Santosh Shilimkar
2013-06-25 14:42 ` Santosh Shilimkar
2013-06-25 14:42 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=GYpZ_5Lp1La=f+2BQfmuj+sc3FgygZRD4gfj4JGGZ0Do=_Q@mail.gmail.com' \
--to=agnel.joel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=b-cousson@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jkridner@beagleboard.org \
--cc=joelagnel@ti.com \
--cc=koen@beagleboard.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=matt@ohporter.com \
--cc=nsekhar@ti.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=tony@atomide.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.