From: amit kachhap <amit.kachhap@gmail.com> To: Inderpal Singh <inderpal.singh@linaro.org>, Kukjin Kim <kgene.kim@samsung.com> Cc: linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Abraham <thomas.abraham@linaro.org>, cpufreq@vger.kernel.org Subject: Re: [PATCH 3/3] dts: Add cpufreq controller node for Exynos5440 SoC Date: Mon, 11 Feb 2013 17:12:18 -0800 [thread overview] Message-ID: <CADGdYn6+yW2_pFG+mHf8F5eBgEA-2_8iQXdkJhxqp-4Eq1fGeg@mail.gmail.com> (raw) In-Reply-To: <CAG17yqQBjuc9t2iXg0sjTMo=pbXcjkwuP0uRFu=YR=58+AmEmA@mail.gmail.com> On Fri, Feb 8, 2013 at 8:49 AM, Inderpal Singh <inderpal.singh@linaro.org> wrote: > On 8 February 2013 00:03, amit kachhap <amit.kachhap@gmail.com> wrote: >> On Wed, Feb 6, 2013 at 8:49 PM, Inderpal Singh >> <inderpal.singh@linaro.org> wrote: >>> On 7 February 2013 01:09, Amit Daniel Kachhap <amit.daniel@samsung.com> wrote: >>>> Add cpufreq controller device node for Exynos5440 SoC for passing >>>> parameters like controller base address, interrupt and cpufreq >>>> table. >>>> >>>> Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com> >>>> --- >>>> arch/arm/boot/dts/exynos5440.dtsi | 9 +++++++++ >>>> 1 file changed, 9 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi >>>> index 024269d..b20b517 100644 >>>> --- a/arch/arm/boot/dts/exynos5440.dtsi >>>> +++ b/arch/arm/boot/dts/exynos5440.dtsi >>>> @@ -63,6 +63,15 @@ >>>> >>>> }; >>>> >>>> + cpufreq@160000 { >>>> + compatible = "samsung,exynos5440-cpufreq"; >>>> + reg = <0x160000 0x1000>; >>>> + interrupts = <0 57 0>; >>>> + cpufreq_tbl = < 1200000 1025000 >>>> + 1000000 975000 >>>> + 800000 925000 >; >>>> + }; >>>> + >>> >>> I think cpufreq_tbl should be part of the cpu node as it's the >>> property of the cpu. >>> Please refer cpufreq-cpu0 and spear-cpufreq. >> >> http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/15364. >> In this thread same discussion followed. I am not sure what is the >> correct way but looks like Kukjin concluded this with a timer node >> separate from the CPU code. >> > > I am only talking about cpufreq_tbl and its nothing but operating > points for the cpus. It seems its agreed upon to add operating-points > to cpu node as being done by all other platforms like imx6q, am33xx, > cpufreq-cpu0 and spear. Even timer, GIC, cpufreq tbl, pmu etc are all cpu properties. But the problem is whether to put them in cpu0 or repeat same information in all cpu nodes as it is common to all cpu's and not just cpu0. So as Kukjin kim has put the timer node outside the cpu node so i also followed the same convention. Mr Kim, Any issue in this approach? Thanks, Amit Daniel > > Thanks, > Inder > >> Thanks, >> Amit Daniel >>> >>>> serial@B0000 { >>>> compatible = "samsung,exynos4210-uart"; >>>> reg = <0xB0000 0x1000>; >>>> -- >>>> 1.7.10.4 >>>> >>>> -- >>>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in >>>> the body of a message to majordomo@vger.kernel.org >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: amit.kachhap@gmail.com (amit kachhap) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/3] dts: Add cpufreq controller node for Exynos5440 SoC Date: Mon, 11 Feb 2013 17:12:18 -0800 [thread overview] Message-ID: <CADGdYn6+yW2_pFG+mHf8F5eBgEA-2_8iQXdkJhxqp-4Eq1fGeg@mail.gmail.com> (raw) In-Reply-To: <CAG17yqQBjuc9t2iXg0sjTMo=pbXcjkwuP0uRFu=YR=58+AmEmA@mail.gmail.com> On Fri, Feb 8, 2013 at 8:49 AM, Inderpal Singh <inderpal.singh@linaro.org> wrote: > On 8 February 2013 00:03, amit kachhap <amit.kachhap@gmail.com> wrote: >> On Wed, Feb 6, 2013 at 8:49 PM, Inderpal Singh >> <inderpal.singh@linaro.org> wrote: >>> On 7 February 2013 01:09, Amit Daniel Kachhap <amit.daniel@samsung.com> wrote: >>>> Add cpufreq controller device node for Exynos5440 SoC for passing >>>> parameters like controller base address, interrupt and cpufreq >>>> table. >>>> >>>> Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com> >>>> --- >>>> arch/arm/boot/dts/exynos5440.dtsi | 9 +++++++++ >>>> 1 file changed, 9 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi >>>> index 024269d..b20b517 100644 >>>> --- a/arch/arm/boot/dts/exynos5440.dtsi >>>> +++ b/arch/arm/boot/dts/exynos5440.dtsi >>>> @@ -63,6 +63,15 @@ >>>> >>>> }; >>>> >>>> + cpufreq at 160000 { >>>> + compatible = "samsung,exynos5440-cpufreq"; >>>> + reg = <0x160000 0x1000>; >>>> + interrupts = <0 57 0>; >>>> + cpufreq_tbl = < 1200000 1025000 >>>> + 1000000 975000 >>>> + 800000 925000 >; >>>> + }; >>>> + >>> >>> I think cpufreq_tbl should be part of the cpu node as it's the >>> property of the cpu. >>> Please refer cpufreq-cpu0 and spear-cpufreq. >> >> http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/15364. >> In this thread same discussion followed. I am not sure what is the >> correct way but looks like Kukjin concluded this with a timer node >> separate from the CPU code. >> > > I am only talking about cpufreq_tbl and its nothing but operating > points for the cpus. It seems its agreed upon to add operating-points > to cpu node as being done by all other platforms like imx6q, am33xx, > cpufreq-cpu0 and spear. Even timer, GIC, cpufreq tbl, pmu etc are all cpu properties. But the problem is whether to put them in cpu0 or repeat same information in all cpu nodes as it is common to all cpu's and not just cpu0. So as Kukjin kim has put the timer node outside the cpu node so i also followed the same convention. Mr Kim, Any issue in this approach? Thanks, Amit Daniel > > Thanks, > Inder > >> Thanks, >> Amit Daniel >>> >>>> serial at B0000 { >>>> compatible = "samsung,exynos4210-uart"; >>>> reg = <0xB0000 0x1000>; >>>> -- >>>> 1.7.10.4 >>>> >>>> -- >>>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in >>>> the body of a message to majordomo at vger.kernel.org >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in >>> the body of a message to majordomo at vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-02-12 1:12 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-02-06 19:39 [PATCH 1/3] cpufreq: exynos: Remove error return even if no soc found Amit Daniel Kachhap 2013-02-06 19:39 ` Amit Daniel Kachhap 2013-02-06 19:39 ` [PATCH 2/3] cpufreq: exynos: Adding cpufreq driver for exynos5440 Amit Daniel Kachhap 2013-02-06 19:39 ` Amit Daniel Kachhap 2013-02-07 5:09 ` Inderpal Singh 2013-02-07 5:09 ` Inderpal Singh 2013-02-07 11:19 ` Viresh Kumar 2013-02-07 11:19 ` Viresh Kumar 2013-02-07 11:28 ` Inderpal Singh 2013-02-07 11:28 ` Inderpal Singh 2013-02-07 18:39 ` amit kachhap 2013-02-07 18:39 ` amit kachhap 2013-02-07 11:17 ` Viresh Kumar 2013-02-07 11:17 ` Viresh Kumar 2013-02-07 19:08 ` amit kachhap 2013-02-07 19:08 ` amit kachhap 2013-02-08 2:42 ` Viresh Kumar 2013-02-08 2:42 ` Viresh Kumar 2013-02-08 3:26 ` amit kachhap 2013-02-08 3:26 ` amit kachhap 2013-02-08 4:23 ` Viresh Kumar 2013-02-08 4:23 ` Viresh Kumar 2013-02-06 19:39 ` [PATCH 3/3] dts: Add cpufreq controller node for Exynos5440 SoC Amit Daniel Kachhap 2013-02-06 19:39 ` Amit Daniel Kachhap 2013-02-07 4:49 ` Inderpal Singh 2013-02-07 4:49 ` Inderpal Singh 2013-02-07 18:33 ` amit kachhap 2013-02-07 18:33 ` amit kachhap 2013-02-08 16:49 ` Inderpal Singh 2013-02-08 16:49 ` Inderpal Singh 2013-02-12 1:12 ` amit kachhap [this message] 2013-02-12 1:12 ` amit kachhap 2013-02-12 5:00 ` Inderpal Singh 2013-02-12 5:00 ` Inderpal Singh 2013-02-07 11:20 ` [PATCH 1/3] cpufreq: exynos: Remove error return even if no soc found Viresh Kumar 2013-02-07 11:20 ` Viresh Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CADGdYn6+yW2_pFG+mHf8F5eBgEA-2_8iQXdkJhxqp-4Eq1fGeg@mail.gmail.com \ --to=amit.kachhap@gmail.com \ --cc=cpufreq@vger.kernel.org \ --cc=inderpal.singh@linaro.org \ --cc=kgene.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=rjw@sisk.pl \ --cc=thomas.abraham@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.