From: "Stéphane Marchesin" <marcheu@chromium.org> To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Jeffy Chen <jeffy.chen@rock-chips.com>, Emil Renner Berthing <kernel@esmil.dk>, Arnd Bergmann <arnd@arndb.de>, Tomeu Vizoso <tomeu.vizoso@collabora.com>, Catalin Marinas <catalin.marinas@arm.com>, Brian Norris <briannorris@chromium.org>, Will Deacon <will.deacon@arm.com>, Doug Anderson <dianders@chromium.org>, dri-devel <dri-devel@lists.freedesktop.org>, "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>, Rob Herring <robh+dt@kernel.org>, enric.balletbo@collabora.co.uk, Thierry Reding <thierry.reding@gmail.com>, "Kristian H. Kristensen" <hoegsberg@chromium.org>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Matthias Kaehlcke <mka@chromium.org>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v3 6/6] arm64: dts: rockchip: Specify override mode for kevin panel Date: Tue, 24 Apr 2018 16:02:26 -0700 [thread overview] Message-ID: <CADMs+9a+dwKeKUDHYeiUON6q1UOnt84HoJ4bpjT=6aYm7OZG9A@mail.gmail.com> (raw) In-Reply-To: <CAAEAJfAQMzUfM86o-xNoyBQzTiEMNH+W=9FyFpBy99nA3HrVgw@mail.gmail.com> On Tue, Apr 24, 2018 at 7:31 AM, Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> wrote: > Hi Doug, Sean: > > I would like to move this forward. > > On 26 February 2018 at 15:23, Doug Anderson <dianders@chromium.org> wrote: >> Hi, >> >> On Thu, Feb 8, 2018 at 9:48 AM, Sean Paul <seanpaul@chromium.org> wrote: >>> This patch adds an override mode for kevin devices. The mode increases >>> both back porches to allow a pixel clock of 26666kHz as opposed to the >>> 'typical' value of 252750kHz. This is needed to avoid interference with >>> the touch digitizer on these laptops. >>> >>> Changes in v2: >>> - Wrap the timing in display-timings node to match binding (Rob/Thierry) >>> Changes in v3: >>> - Unwrap the timing from display-timings and rename panel-timing (Rob) >>> >>> Cc: Doug Anderson <dianders@chromium.org> >>> Cc: Eric Anholt <eric@anholt.net> >>> Cc: Heiko Stuebner <heiko@sntech.de> >>> Cc: Jeffy Chen <jeffy.chen@rock-chips.com> >>> Cc: Rob Herring <robh+dt@kernel.org> >>> Cc: Stéphane Marchesin <marcheu@chromium.org> >>> Cc: Thierry Reding <thierry.reding@gmail.com> >>> Cc: devicetree@vger.kernel.org >>> Cc: dri-devel@lists.freedesktop.org >>> Cc: linux-rockchip@lists.infradead.org >>> Signed-off-by: Sean Paul <seanpaul@chromium.org> >>> --- >>> arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 14 ++++++++++++++ >>> 1 file changed, 14 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts >>> index 191a6bcb1704..658411ce37ea 100644 >>> --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts >>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts >>> @@ -98,6 +98,20 @@ >>> backlight = <&backlight>; >>> power-supply = <&pp3300_disp>; >>> >>> + panel-timing { >>> + clock-frequency = <266604720>; >>> + hactive = <2400>; >>> + hfront-porch = <48>; >>> + hback-porch = <84>; >>> + hsync-len = <32>; >>> + hsync-active = <0>; >>> + vactive = <1600>; >>> + vfront-porch = <3>; >>> + vback-porch = <120>; >>> + vsync-len = <10>; >>> + vsync-active = <0>; >>> + }; >>> + >>> ports { >>> panel_in_edp: endpoint { >>> remote-endpoint = <&edp_out_panel>; >> >> Kristian brought an old bug to my attention >> <https://bugs.chromium.org/p/chromium/issues/detail?id=750354> and it >> made me think. Should we somehow adjust the bindings here to account >> for the fact that a board may source several different panels? >> >> AKA: on some boards an ODM may want to second source (or third source, >> or ...) the panel. They'll randomly connect several different panels >> to the board and ship the boards out. The panels are all compatible >> electrically (same power sequencing) but might need slightly different >> timings. In this particular case there's no board-level strappings >> for the different panels--it's assumed that the EDID on the panels can >> be used to distinguish them. >> >> In that case it seems like it would be nice to allow specifying more >> than one "panel-timing" nodes. Maybe keyed off some type of ID that's >> present in the EDID? >> >> >> Is that something we'd want to account for before we land this series? >> It seems like it would just be adding an extra level of nodes? >> > > AFAICS, there is no EDID without a DDC bus, which we don't > seem to have on gru platforms, do we? IIRC historically we've only done second sourcing when doable because either: 1. the timings between all the panels we use are compatible, or 2. we have a working DDC to figure it out for us. In other words, we haven't handled the case where timings are not compatible and we can't address this by reading EDIDs. Stéphane > > Regards, > -- > Ezequiel García, VanguardiaSur > www.vanguardiasur.com.ar _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: marcheu@chromium.org (Stéphane Marchesin) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 6/6] arm64: dts: rockchip: Specify override mode for kevin panel Date: Tue, 24 Apr 2018 16:02:26 -0700 [thread overview] Message-ID: <CADMs+9a+dwKeKUDHYeiUON6q1UOnt84HoJ4bpjT=6aYm7OZG9A@mail.gmail.com> (raw) In-Reply-To: <CAAEAJfAQMzUfM86o-xNoyBQzTiEMNH+W=9FyFpBy99nA3HrVgw@mail.gmail.com> On Tue, Apr 24, 2018 at 7:31 AM, Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> wrote: > Hi Doug, Sean: > > I would like to move this forward. > > On 26 February 2018 at 15:23, Doug Anderson <dianders@chromium.org> wrote: >> Hi, >> >> On Thu, Feb 8, 2018 at 9:48 AM, Sean Paul <seanpaul@chromium.org> wrote: >>> This patch adds an override mode for kevin devices. The mode increases >>> both back porches to allow a pixel clock of 26666kHz as opposed to the >>> 'typical' value of 252750kHz. This is needed to avoid interference with >>> the touch digitizer on these laptops. >>> >>> Changes in v2: >>> - Wrap the timing in display-timings node to match binding (Rob/Thierry) >>> Changes in v3: >>> - Unwrap the timing from display-timings and rename panel-timing (Rob) >>> >>> Cc: Doug Anderson <dianders@chromium.org> >>> Cc: Eric Anholt <eric@anholt.net> >>> Cc: Heiko Stuebner <heiko@sntech.de> >>> Cc: Jeffy Chen <jeffy.chen@rock-chips.com> >>> Cc: Rob Herring <robh+dt@kernel.org> >>> Cc: St?phane Marchesin <marcheu@chromium.org> >>> Cc: Thierry Reding <thierry.reding@gmail.com> >>> Cc: devicetree at vger.kernel.org >>> Cc: dri-devel at lists.freedesktop.org >>> Cc: linux-rockchip at lists.infradead.org >>> Signed-off-by: Sean Paul <seanpaul@chromium.org> >>> --- >>> arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 14 ++++++++++++++ >>> 1 file changed, 14 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts >>> index 191a6bcb1704..658411ce37ea 100644 >>> --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts >>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts >>> @@ -98,6 +98,20 @@ >>> backlight = <&backlight>; >>> power-supply = <&pp3300_disp>; >>> >>> + panel-timing { >>> + clock-frequency = <266604720>; >>> + hactive = <2400>; >>> + hfront-porch = <48>; >>> + hback-porch = <84>; >>> + hsync-len = <32>; >>> + hsync-active = <0>; >>> + vactive = <1600>; >>> + vfront-porch = <3>; >>> + vback-porch = <120>; >>> + vsync-len = <10>; >>> + vsync-active = <0>; >>> + }; >>> + >>> ports { >>> panel_in_edp: endpoint { >>> remote-endpoint = <&edp_out_panel>; >> >> Kristian brought an old bug to my attention >> <https://bugs.chromium.org/p/chromium/issues/detail?id=750354> and it >> made me think. Should we somehow adjust the bindings here to account >> for the fact that a board may source several different panels? >> >> AKA: on some boards an ODM may want to second source (or third source, >> or ...) the panel. They'll randomly connect several different panels >> to the board and ship the boards out. The panels are all compatible >> electrically (same power sequencing) but might need slightly different >> timings. In this particular case there's no board-level strappings >> for the different panels--it's assumed that the EDID on the panels can >> be used to distinguish them. >> >> In that case it seems like it would be nice to allow specifying more >> than one "panel-timing" nodes. Maybe keyed off some type of ID that's >> present in the EDID? >> >> >> Is that something we'd want to account for before we land this series? >> It seems like it would just be adding an extra level of nodes? >> > > AFAICS, there is no EDID without a DDC bus, which we don't > seem to have on gru platforms, do we? IIRC historically we've only done second sourcing when doable because either: 1. the timings between all the panels we use are compatible, or 2. we have a working DDC to figure it out for us. In other words, we haven't handled the case where timings are not compatible and we can't address this by reading EDIDs. St?phane > > Regards, > -- > Ezequiel Garc?a, VanguardiaSur > www.vanguardiasur.com.ar
next prev parent reply other threads:[~2018-04-24 23:02 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-08 17:48 [PATCH v3 0/6] drm/panel: simple: Add mode support to devicetree Sean Paul 2018-02-08 17:48 ` [PATCH v3 1/6] dt-bindings: Clarify timing subnode use as panel-timing Sean Paul 2018-02-08 18:43 ` Rob Herring 2018-02-19 14:59 ` Thierry Reding [not found] ` <20180208174855.55620-1-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2018-02-08 17:48 ` [PATCH v3 2/6] dt-bindings: Add headings to simple-panel bindings Sean Paul [not found] ` <20180208174855.55620-3-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2018-02-08 18:44 ` Rob Herring 2018-02-08 17:48 ` [PATCH v3 3/6] dt-bindings: Add panel-timing subnode to simple-panel Sean Paul [not found] ` <20180208174855.55620-4-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> 2018-02-08 18:45 ` Rob Herring 2018-02-19 15:09 ` Thierry Reding 2018-03-01 18:47 ` Laurent Pinchart 2018-02-08 17:48 ` [PATCH v3 4/6] drm/panel: simple: Add ability to override typical timing Sean Paul 2018-02-19 14:33 ` Enric Balletbo Serra 2018-02-19 15:25 ` Thierry Reding 2018-02-08 17:48 ` [PATCH v3 5/6] drm/panel: simple: Use display_timing for lq123p1jx31 Sean Paul 2018-02-19 14:34 ` Enric Balletbo Serra 2018-02-08 17:48 ` [PATCH v3 6/6] arm64: dts: rockchip: Specify override mode for kevin panel Sean Paul 2018-02-08 17:48 ` Sean Paul 2018-02-19 14:34 ` Enric Balletbo Serra 2018-02-19 14:34 ` Enric Balletbo Serra 2018-02-26 18:23 ` Doug Anderson 2018-02-26 18:23 ` Doug Anderson 2018-04-24 14:31 ` Ezequiel Garcia 2018-04-24 14:31 ` Ezequiel Garcia 2018-04-24 23:02 ` Stéphane Marchesin [this message] 2018-04-24 23:02 ` Stéphane Marchesin 2018-04-25 4:29 ` Doug Anderson 2018-04-25 4:29 ` Doug Anderson 2018-04-25 12:36 ` Ezequiel Garcia 2018-04-25 12:36 ` Ezequiel Garcia 2018-04-26 12:05 ` Thierry Reding 2018-04-26 12:05 ` Thierry Reding 2018-04-26 15:29 ` Doug Anderson 2018-04-26 15:29 ` Doug Anderson 2018-03-12 8:35 ` [PATCH v3 0/6] drm/panel: simple: Add mode support to devicetree Thierry Reding 2019-03-28 17:28 ` Doug Anderson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CADMs+9a+dwKeKUDHYeiUON6q1UOnt84HoJ4bpjT=6aYm7OZG9A@mail.gmail.com' \ --to=marcheu@chromium.org \ --cc=arnd@arndb.de \ --cc=briannorris@chromium.org \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=dmitry.torokhov@gmail.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=enric.balletbo@collabora.co.uk \ --cc=ezequiel@vanguardiasur.com.ar \ --cc=hoegsberg@chromium.org \ --cc=jeffy.chen@rock-chips.com \ --cc=kernel@esmil.dk \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=mark.rutland@arm.com \ --cc=mka@chromium.org \ --cc=robh+dt@kernel.org \ --cc=thierry.reding@gmail.com \ --cc=tomeu.vizoso@collabora.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.