From: Chander Kashyap <k.chander@samsung.com> To: Kevin Hilman <khilman@linaro.org> Cc: "Chander Kashyap" <k.chander@samsung.com>, "Lukasz Majewski" <l.majewski@samsung.com>, "Kukjin Kim" <kgene.kim@samsung.com>, "Mike Turquette" <mturquette@linaro.org>, "Heiko Stübner" <heiko@sntech.de>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, "Viresh Kumar" <viresh.kumar@linaro.org>, "Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>, "Tomasz Figa" <tomasz.figa@gmail.com>, "Amit Kucheria" <amit.kucheria@linaro.org>, "Chanwoo Choi" <cw00.choi@samsung.com>, "Thomas Abraham" <thomas.ab@samsung.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, linaro-kernel@lists.linaro.org, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>, "Marek Szyprowski" <m.szyprowski@samsung.com> Subject: Re: [PATCH v9 4/6] ARM: Exynos: switch to using generic cpufreq driver for Exynos4210/5250/5420 Date: Tue, 26 Aug 2014 10:55:05 +0530 [thread overview] Message-ID: <CADWw7OgW+o3tB=ptnsy-PsmXmNv8oXzt_WfK6NswQiEWWwAzNA@mail.gmail.com> (raw) In-Reply-To: <7h8umc60we.fsf@paris.lan> Hi Kevin, On Mon, Aug 25, 2014 at 9:02 PM, Kevin Hilman <khilman@linaro.org> wrote: > Hi Chander, > > Chander Kashyap <k.chander@samsung.com> writes: > > [...] > >>>> I'm trying it on the 5800/Chromebook2 and it's not terribly stable. I'm >>>> testing along with CPUidle, so there may be some untested interactions >>>> there as it seems a bit more stable without CPUidle enabled. >>>> >>>> I'd love to hear from anyone else that's testing CPUidle and CPUfreq >>>> together big.LITTLE 5420/5800, with or without the switcher. >> >> I have tested this patch series on SMDK5420 with cpuidle (with and >> without b.L switcher enabled). >> >> As of now voltage scaling support is not there in generic big-little >> cpufreq driver (arm_big_little.c). >> Hence need to tie arm and kfc voltages to highest level for testing. > >> Without this change stability issues are there, but with this change >> everything is stable. > > Can you clarify how you're setting the voltages to ensure stability? below is the diff : wip/exynos/integ --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts @@ -225,7 +225,7 @@ buck2_reg: BUCK2 { regulator-name = "vdd_arm"; - regulator-min-microvolt = <800000>; + regulator-min-microvolt = <1500000>; regulator-max-microvolt = <1500000>; regulator-always-on; regulator-boot-on; @@ -260,7 +260,7 @@ buck6_reg: BUCK6 { regulator-name = "vdd_kfc"; - regulator-min-microvolt = <800000>; + regulator-min-microvolt = <1500000>; regulator-max-microvolt = <1500000>; regulator-always-on; regulator-boot-on; > > Tomasz, I didn't mean to suggest this isn't ready for mainline. For the > 5420/5800 it seems cpufreq support is a new feature, so this isn't a > regression against previous (mainline) behavior. Maybe the big.LITTLE > cpufreq support should've been separated out from the cleanup since it's > more of a new feature, but that's up to you. > > Kevin > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel regards, Chander
WARNING: multiple messages have this Message-ID (diff)
From: k.chander@samsung.com (Chander Kashyap) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v9 4/6] ARM: Exynos: switch to using generic cpufreq driver for Exynos4210/5250/5420 Date: Tue, 26 Aug 2014 10:55:05 +0530 [thread overview] Message-ID: <CADWw7OgW+o3tB=ptnsy-PsmXmNv8oXzt_WfK6NswQiEWWwAzNA@mail.gmail.com> (raw) In-Reply-To: <7h8umc60we.fsf@paris.lan> Hi Kevin, On Mon, Aug 25, 2014 at 9:02 PM, Kevin Hilman <khilman@linaro.org> wrote: > Hi Chander, > > Chander Kashyap <k.chander@samsung.com> writes: > > [...] > >>>> I'm trying it on the 5800/Chromebook2 and it's not terribly stable. I'm >>>> testing along with CPUidle, so there may be some untested interactions >>>> there as it seems a bit more stable without CPUidle enabled. >>>> >>>> I'd love to hear from anyone else that's testing CPUidle and CPUfreq >>>> together big.LITTLE 5420/5800, with or without the switcher. >> >> I have tested this patch series on SMDK5420 with cpuidle (with and >> without b.L switcher enabled). >> >> As of now voltage scaling support is not there in generic big-little >> cpufreq driver (arm_big_little.c). >> Hence need to tie arm and kfc voltages to highest level for testing. > >> Without this change stability issues are there, but with this change >> everything is stable. > > Can you clarify how you're setting the voltages to ensure stability? below is the diff : wip/exynos/integ --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts @@ -225,7 +225,7 @@ buck2_reg: BUCK2 { regulator-name = "vdd_arm"; - regulator-min-microvolt = <800000>; + regulator-min-microvolt = <1500000>; regulator-max-microvolt = <1500000>; regulator-always-on; regulator-boot-on; @@ -260,7 +260,7 @@ buck6_reg: BUCK6 { regulator-name = "vdd_kfc"; - regulator-min-microvolt = <800000>; + regulator-min-microvolt = <1500000>; regulator-max-microvolt = <1500000>; regulator-always-on; regulator-boot-on; > > Tomasz, I didn't mean to suggest this isn't ready for mainline. For the > 5420/5800 it seems cpufreq support is a new feature, so this isn't a > regression against previous (mainline) behavior. Maybe the big.LITTLE > cpufreq support should've been separated out from the cleanup since it's > more of a new feature, but that's up to you. > > Kevin > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel regards, Chander
next prev parent reply other threads:[~2014-08-26 5:25 UTC|newest] Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-07-30 8:07 [PATCH v9 0/6] cpufreq: use generic cpufreq drivers for exynos platforms Thomas Abraham 2014-07-30 8:07 ` Thomas Abraham 2014-07-30 8:07 ` [PATCH v9 1/6] clk: samsung: add infrastructure to register cpu clocks Thomas Abraham 2014-07-30 8:07 ` Thomas Abraham 2014-09-01 22:29 ` Mike Turquette 2014-09-01 22:29 ` Mike Turquette 2014-09-02 13:53 ` Thomas Abraham 2014-09-02 13:53 ` Thomas Abraham 2014-07-30 8:07 ` [PATCH v9 2/6] clk: samsung: add cpu clock configuration data and instantiate cpu clock Thomas Abraham 2014-07-30 8:07 ` Thomas Abraham 2014-09-01 22:29 ` Mike Turquette 2014-09-01 22:29 ` Mike Turquette 2014-07-30 8:07 ` [PATCH v9 3/6] ARM: dts: Exynos: add CPU OPP and regulator supply property Thomas Abraham 2014-07-30 8:07 ` Thomas Abraham 2014-07-30 11:28 ` Andreas Färber 2014-07-30 11:28 ` Andreas Färber 2014-07-31 2:55 ` Thomas Abraham 2014-07-31 2:55 ` Thomas Abraham 2014-07-31 0:37 ` Doug Anderson 2014-07-31 0:37 ` Doug Anderson 2014-07-31 3:21 ` Thomas Abraham 2014-07-31 3:21 ` Thomas Abraham 2014-07-31 3:53 ` Doug Anderson 2014-07-31 3:53 ` Doug Anderson 2014-07-31 4:06 ` Thomas Abraham 2014-07-31 4:06 ` Thomas Abraham 2014-07-31 4:08 ` Doug Anderson 2014-07-31 4:08 ` Doug Anderson 2014-07-31 4:18 ` Thomas Abraham 2014-07-31 4:18 ` Thomas Abraham 2014-08-02 3:49 ` Javier Martinez Canillas 2014-08-02 3:49 ` Javier Martinez Canillas 2014-08-04 3:00 ` Thomas Abraham 2014-08-04 3:00 ` Thomas Abraham 2014-07-30 8:07 ` [PATCH v9 4/6] ARM: Exynos: switch to using generic cpufreq driver for Exynos4210/5250/5420 Thomas Abraham 2014-07-30 8:07 ` Thomas Abraham 2014-07-31 18:32 ` Kukjin Kim 2014-07-31 18:32 ` Kukjin Kim 2014-07-31 18:40 ` Tomasz Figa 2014-07-31 18:40 ` Tomasz Figa 2014-07-31 18:54 ` Tomasz Figa 2014-07-31 18:54 ` Tomasz Figa 2014-07-31 19:25 ` Thomas Abraham 2014-07-31 19:25 ` Thomas Abraham 2014-07-31 19:30 ` Tomasz Figa 2014-07-31 19:30 ` Tomasz Figa 2014-08-04 3:24 ` Thomas Abraham 2014-08-04 3:24 ` Thomas Abraham 2014-08-22 23:54 ` Kevin Hilman 2014-08-22 23:54 ` Kevin Hilman 2014-08-23 0:02 ` Tomasz Figa 2014-08-23 0:02 ` Tomasz Figa 2014-08-25 6:53 ` Lukasz Majewski 2014-08-25 6:53 ` Lukasz Majewski 2014-08-25 12:15 ` Chander Kashyap 2014-08-25 12:15 ` Chander Kashyap 2014-08-25 15:32 ` Kevin Hilman 2014-08-25 15:32 ` Kevin Hilman 2014-08-25 15:56 ` Tomasz Figa 2014-08-25 15:56 ` Tomasz Figa 2014-08-26 4:54 ` Viresh Kumar 2014-08-26 4:54 ` Viresh Kumar 2014-08-26 5:25 ` Chander Kashyap [this message] 2014-08-26 5:25 ` Chander Kashyap 2014-08-26 15:15 ` Kevin Hilman 2014-08-26 15:15 ` Kevin Hilman 2014-08-26 22:25 ` Kevin Hilman 2014-08-26 22:25 ` Kevin Hilman 2014-08-29 12:52 ` Thomas Abraham 2014-08-29 12:52 ` Thomas Abraham 2014-08-29 15:03 ` Kevin Hilman 2014-08-29 15:03 ` Kevin Hilman 2014-09-01 8:47 ` Thomas Abraham 2014-09-01 8:47 ` Thomas Abraham 2014-09-02 19:32 ` Kevin Hilman 2014-09-02 19:32 ` Kevin Hilman 2014-09-03 4:26 ` Thomas Abraham 2014-09-03 4:26 ` Thomas Abraham 2014-09-03 13:18 ` Thomas Abraham 2014-09-03 13:18 ` Thomas Abraham 2014-09-03 23:15 ` Kevin Hilman 2014-09-03 23:15 ` Kevin Hilman 2014-09-04 10:22 ` Thomas Abraham 2014-09-04 13:30 ` Kevin Hilman 2014-09-04 13:30 ` Kevin Hilman 2014-09-05 13:41 ` Thomas Abraham 2014-09-05 13:41 ` Thomas Abraham 2014-08-25 8:11 ` Sjoerd Simons 2014-08-25 8:11 ` Sjoerd Simons 2014-07-30 8:07 ` [PATCH v9 5/6] cpufreq: exynos: remove exynos4210/5250 specific cpufreq driver support Thomas Abraham 2014-07-30 8:07 ` Thomas Abraham 2014-07-30 8:07 ` [PATCH v9 6/6] clk: samsung: remove unused clock aliases and update clock flags Thomas Abraham 2014-07-30 8:07 ` Thomas Abraham 2014-07-31 14:13 ` Tomasz Figa 2014-07-31 14:13 ` Tomasz Figa 2014-07-31 18:24 ` Thomas Abraham 2014-07-31 18:24 ` Thomas Abraham 2014-07-31 18:35 ` Tomasz Figa 2014-07-31 18:35 ` Tomasz Figa 2014-07-31 18:41 ` Thomas Abraham 2014-07-31 18:41 ` Thomas Abraham 2014-07-31 18:46 ` Tomasz Figa 2014-07-31 18:46 ` Tomasz Figa 2014-07-31 18:49 ` Thomas Abraham 2014-07-31 18:49 ` Thomas Abraham 2014-09-01 22:31 ` Mike Turquette 2014-09-01 22:31 ` Mike Turquette 2014-07-31 6:20 ` [PATCH v9 0/6] cpufreq: use generic cpufreq drivers for exynos platforms Chander M. Kashyap 2014-07-31 6:20 ` Chander M. Kashyap 2014-07-31 10:59 ` Thomas Abraham 2014-07-31 10:59 ` Thomas Abraham 2014-07-31 12:24 ` Chander M. Kashyap 2014-07-31 12:24 ` Chander M. Kashyap 2014-07-31 14:15 ` Tomasz Figa 2014-07-31 14:15 ` Tomasz Figa 2014-07-31 18:25 ` Thomas Abraham 2014-07-31 18:25 ` Thomas Abraham 2014-07-31 18:34 ` Thomas Abraham 2014-07-31 18:34 ` Thomas Abraham 2014-08-01 9:42 ` Viresh Kumar 2014-08-01 9:42 ` Viresh Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CADWw7OgW+o3tB=ptnsy-PsmXmNv8oXzt_WfK6NswQiEWWwAzNA@mail.gmail.com' \ --to=k.chander@samsung.com \ --cc=amit.kucheria@linaro.org \ --cc=b.zolnierkie@samsung.com \ --cc=cw00.choi@samsung.com \ --cc=heiko@sntech.de \ --cc=kgene.kim@samsung.com \ --cc=khilman@linaro.org \ --cc=l.majewski@samsung.com \ --cc=linaro-kernel@lists.linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=mturquette@linaro.org \ --cc=thomas.ab@samsung.com \ --cc=tomasz.figa@gmail.com \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.