From: Alex Deucher <alexdeucher@gmail.com>
To: Leo <sunpeng.li@amd.com>
Cc: "Nathan Chancellor" <nathan@kernel.org>,
"Harry Wentland" <harry.wentland@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
llvm@lists.linux.dev,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
patches@lists.linux.dev
Subject: Re: [PATCH] drm/amd/display: Fix indentation in dcn32_get_vco_frequency_from_reg()
Date: Thu, 23 Jun 2022 12:54:32 -0400 [thread overview]
Message-ID: <CADnq5_M8E1x4dDRmFd=Y7Zmz=5DbS9ADGnmiDiP20rdHpKBJxA@mail.gmail.com> (raw)
In-Reply-To: <03448497-30c9-7655-ae6a-a66a1f649828@amd.com>
Applied. Thanks!
Alex
On Thu, Jun 23, 2022 at 12:26 PM Leo <sunpeng.li@amd.com> wrote:
>
>
>
> On 2022-06-23 11:30, Nathan Chancellor wrote:
> > Clang warns:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c:549:4: warning: misleading indentation; statement is not part of the previous 'else' [-Wmisleading-indentation]
> > pll_req = dc_fixpt_from_int(pll_req_reg & clk_mgr->clk_mgr_mask->FbMult_int);
> > ^
> > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c:542:3: note: previous statement is here
> > else
> > ^
> > 1 warning generated.
> >
> > Indent this statement to the left, as it was clearly intended to be
> > called unconditionally, which will fix the warning.
> >
> > Link: https://github.com/ClangBuiltLinux/linux/issues/1655
> > Fixes: 3e838f7ccf64 ("drm/amd/display: Get VCO frequency from registers")
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
>
> Just hit this myself, thanks for the fix!
> Reviewed-by: Leo Li <sunpeng.li@amd.com>
>
> > ---
> > drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c
> > index 113f93b3d3b2..4e8059f20007 100644
> > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c
> > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c
> > @@ -546,7 +546,7 @@ static uint32_t dcn32_get_vco_frequency_from_reg(struct clk_mgr_internal *clk_mg
> > * this works because the int part is on the right edge of the register
> > * and the frac part is on the left edge
> > */
> > - pll_req = dc_fixpt_from_int(pll_req_reg & clk_mgr->clk_mgr_mask->FbMult_int);
> > + pll_req = dc_fixpt_from_int(pll_req_reg & clk_mgr->clk_mgr_mask->FbMult_int);
> > pll_req.value |= pll_req_reg & clk_mgr->clk_mgr_mask->FbMult_frac;
> >
> > /* multiply by REFCLK period */
> >
> > base-commit: fdf249c70a36e2daa7ddf1252cf3b71faed87abc
>
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: Leo <sunpeng.li@amd.com>
Cc: llvm@lists.linux.dev, "Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
patches@lists.linux.dev,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amd/display: Fix indentation in dcn32_get_vco_frequency_from_reg()
Date: Thu, 23 Jun 2022 12:54:32 -0400 [thread overview]
Message-ID: <CADnq5_M8E1x4dDRmFd=Y7Zmz=5DbS9ADGnmiDiP20rdHpKBJxA@mail.gmail.com> (raw)
In-Reply-To: <03448497-30c9-7655-ae6a-a66a1f649828@amd.com>
Applied. Thanks!
Alex
On Thu, Jun 23, 2022 at 12:26 PM Leo <sunpeng.li@amd.com> wrote:
>
>
>
> On 2022-06-23 11:30, Nathan Chancellor wrote:
> > Clang warns:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c:549:4: warning: misleading indentation; statement is not part of the previous 'else' [-Wmisleading-indentation]
> > pll_req = dc_fixpt_from_int(pll_req_reg & clk_mgr->clk_mgr_mask->FbMult_int);
> > ^
> > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c:542:3: note: previous statement is here
> > else
> > ^
> > 1 warning generated.
> >
> > Indent this statement to the left, as it was clearly intended to be
> > called unconditionally, which will fix the warning.
> >
> > Link: https://github.com/ClangBuiltLinux/linux/issues/1655
> > Fixes: 3e838f7ccf64 ("drm/amd/display: Get VCO frequency from registers")
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
>
> Just hit this myself, thanks for the fix!
> Reviewed-by: Leo Li <sunpeng.li@amd.com>
>
> > ---
> > drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c
> > index 113f93b3d3b2..4e8059f20007 100644
> > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c
> > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c
> > @@ -546,7 +546,7 @@ static uint32_t dcn32_get_vco_frequency_from_reg(struct clk_mgr_internal *clk_mg
> > * this works because the int part is on the right edge of the register
> > * and the frac part is on the left edge
> > */
> > - pll_req = dc_fixpt_from_int(pll_req_reg & clk_mgr->clk_mgr_mask->FbMult_int);
> > + pll_req = dc_fixpt_from_int(pll_req_reg & clk_mgr->clk_mgr_mask->FbMult_int);
> > pll_req.value |= pll_req_reg & clk_mgr->clk_mgr_mask->FbMult_frac;
> >
> > /* multiply by REFCLK period */
> >
> > base-commit: fdf249c70a36e2daa7ddf1252cf3b71faed87abc
>
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: Leo <sunpeng.li@amd.com>
Cc: llvm@lists.linux.dev, "Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
patches@lists.linux.dev,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Harry Wentland" <harry.wentland@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amd/display: Fix indentation in dcn32_get_vco_frequency_from_reg()
Date: Thu, 23 Jun 2022 12:54:32 -0400 [thread overview]
Message-ID: <CADnq5_M8E1x4dDRmFd=Y7Zmz=5DbS9ADGnmiDiP20rdHpKBJxA@mail.gmail.com> (raw)
In-Reply-To: <03448497-30c9-7655-ae6a-a66a1f649828@amd.com>
Applied. Thanks!
Alex
On Thu, Jun 23, 2022 at 12:26 PM Leo <sunpeng.li@amd.com> wrote:
>
>
>
> On 2022-06-23 11:30, Nathan Chancellor wrote:
> > Clang warns:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c:549:4: warning: misleading indentation; statement is not part of the previous 'else' [-Wmisleading-indentation]
> > pll_req = dc_fixpt_from_int(pll_req_reg & clk_mgr->clk_mgr_mask->FbMult_int);
> > ^
> > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c:542:3: note: previous statement is here
> > else
> > ^
> > 1 warning generated.
> >
> > Indent this statement to the left, as it was clearly intended to be
> > called unconditionally, which will fix the warning.
> >
> > Link: https://github.com/ClangBuiltLinux/linux/issues/1655
> > Fixes: 3e838f7ccf64 ("drm/amd/display: Get VCO frequency from registers")
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
>
> Just hit this myself, thanks for the fix!
> Reviewed-by: Leo Li <sunpeng.li@amd.com>
>
> > ---
> > drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c
> > index 113f93b3d3b2..4e8059f20007 100644
> > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c
> > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c
> > @@ -546,7 +546,7 @@ static uint32_t dcn32_get_vco_frequency_from_reg(struct clk_mgr_internal *clk_mg
> > * this works because the int part is on the right edge of the register
> > * and the frac part is on the left edge
> > */
> > - pll_req = dc_fixpt_from_int(pll_req_reg & clk_mgr->clk_mgr_mask->FbMult_int);
> > + pll_req = dc_fixpt_from_int(pll_req_reg & clk_mgr->clk_mgr_mask->FbMult_int);
> > pll_req.value |= pll_req_reg & clk_mgr->clk_mgr_mask->FbMult_frac;
> >
> > /* multiply by REFCLK period */
> >
> > base-commit: fdf249c70a36e2daa7ddf1252cf3b71faed87abc
>
next prev parent reply other threads:[~2022-06-23 16:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 15:30 [PATCH] drm/amd/display: Fix indentation in dcn32_get_vco_frequency_from_reg() Nathan Chancellor
2022-06-23 15:30 ` Nathan Chancellor
2022-06-23 16:26 ` Leo
2022-06-23 16:26 ` Leo
2022-06-23 16:54 ` Alex Deucher [this message]
2022-06-23 16:54 ` Alex Deucher
2022-06-23 16:54 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_M8E1x4dDRmFd=Y7Zmz=5DbS9ADGnmiDiP20rdHpKBJxA@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=patches@lists.linux.dev \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.