From: Alex Deucher <alexdeucher@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: security@kernel.org, "Marek Olšák" <marek.olsak@amd.com>,
"Ilja Van Sprundel" <ivansprundel@ioactive.com>,
kernel-janitors@vger.kernel.org,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"monk.liu" <monk.liu@amd.com>
Subject: Re: [patch] drm/amdgpu: signedness bug in amdgpu_cs_parser_init()
Date: Tue, 29 Sep 2015 17:44:57 +0000 [thread overview]
Message-ID: <CADnq5_Mf0LHs-tMbqs30AK-TF791msfgmyaaYP71RRjmtQEtNg@mail.gmail.com> (raw)
In-Reply-To: <20150925113655.GA12962@mwanda>
On Fri, Sep 25, 2015 at 7:36 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The "i" variable should be signed or it leads to a crash in the error
> handling code.
>
> Fixes: 1d263474c441 ('drm/amdgpu: unwind properly in amdgpu_cs_parser_init()')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied. thanks!
Alex
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index 749420f..cb3c274 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -156,7 +156,8 @@ int amdgpu_cs_parser_init(struct amdgpu_cs_parser *p, void *data)
> uint64_t *chunk_array_user;
> uint64_t *chunk_array;
> struct amdgpu_fpriv *fpriv = p->filp->driver_priv;
> - unsigned size, i;
> + unsigned size;
> + int i;
> int ret;
>
> if (cs->in.num_chunks = 0)
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: security@kernel.org, "Marek Olšák" <marek.olsak@amd.com>,
"Ilja Van Sprundel" <ivansprundel@ioactive.com>,
kernel-janitors@vger.kernel.org,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"monk.liu" <monk.liu@amd.com>
Subject: Re: [patch] drm/amdgpu: signedness bug in amdgpu_cs_parser_init()
Date: Tue, 29 Sep 2015 13:44:57 -0400 [thread overview]
Message-ID: <CADnq5_Mf0LHs-tMbqs30AK-TF791msfgmyaaYP71RRjmtQEtNg@mail.gmail.com> (raw)
In-Reply-To: <20150925113655.GA12962@mwanda>
On Fri, Sep 25, 2015 at 7:36 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The "i" variable should be signed or it leads to a crash in the error
> handling code.
>
> Fixes: 1d263474c441 ('drm/amdgpu: unwind properly in amdgpu_cs_parser_init()')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied. thanks!
Alex
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index 749420f..cb3c274 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -156,7 +156,8 @@ int amdgpu_cs_parser_init(struct amdgpu_cs_parser *p, void *data)
> uint64_t *chunk_array_user;
> uint64_t *chunk_array;
> struct amdgpu_fpriv *fpriv = p->filp->driver_priv;
> - unsigned size, i;
> + unsigned size;
> + int i;
> int ret;
>
> if (cs->in.num_chunks == 0)
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-09-29 17:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <13E61BCA7787794E89BDF39B8DE40C024D12E9F63F@ioaexchange.ioactive.local>
2015-09-23 10:59 ` [patch 1/4] drm/amdgpu: unwind properly in amdgpu_cs_parser_init() Dan Carpenter
2015-09-23 14:16 ` Christian König
2015-09-23 17:13 ` Alex Deucher
2015-09-24 7:56 ` Dan Carpenter
2015-09-24 12:56 ` Deucher, Alexander
2015-09-25 11:36 ` [patch] drm/amdgpu: signedness bug " Dan Carpenter
2015-09-25 11:36 ` Dan Carpenter
2015-09-29 17:44 ` Alex Deucher [this message]
2015-09-29 17:44 ` Alex Deucher
2015-09-23 11:00 ` [patch 2/4] drm/amdgpu: integer overflow in amdgpu_info_ioctl() Dan Carpenter
2015-09-23 11:00 ` [patch 3/4] drm/amdgpu: info leak in amdgpu_gem_metadata_ioctl() Dan Carpenter
2015-09-23 11:00 ` [patch 4/4] drm/amdgpu: integer overflow in amdgpu_mode_dumb_create() Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_Mf0LHs-tMbqs30AK-TF791msfgmyaaYP71RRjmtQEtNg@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ivansprundel@ioactive.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=marek.olsak@amd.com \
--cc=monk.liu@amd.com \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.