From: Alex Deucher <alexdeucher@gmail.com> To: "Christian König" <christian.koenig@amd.com> Cc: Tony Cheng <tony.cheng@amd.com>, David Airlie <airlied@linux.ie>, kernel-janitors@vger.kernel.org, amd-gfx list <amd-gfx@lists.freedesktop.org>, Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>, Hersen Wu <hersenxs.wu@amd.com>, Maling list - DRI developers <dri-devel@lists.freedesktop.org>, Alex Deucher <alexander.deucher@amd.com>, Dave Airlie <airlied@redhat.com>, Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>, Dan Carpenter <dan.carpenter@oracle.com> Subject: Re: [PATCH] drm/amd/display: small cleanup in destruct() Date: Mon, 06 Nov 2017 21:29:31 +0000 [thread overview] Message-ID: <CADnq5_NSTbpOrDHzWD9ug5jEQspeCO2qpri6f1VaaMKR3yqyDQ@mail.gmail.com> (raw) In-Reply-To: <031c92ca-86b0-718d-bf93-18d50db00ce9@amd.com> On Mon, Nov 6, 2017 at 3:44 AM, Christian König <christian.koenig@amd.com> wrote: > Am 06.11.2017 um 08:07 schrieb Dan Carpenter: >> >> Static analysis tools get annoyed that we don't indent this if >> statement. Actually, the if statement isn't required because kfree() >> can handle NULL pointers just fine. The DCE110STRENC_FROM_STRENC() >> macro is a wrapper around container_of() but it's basically a no-op or a >> cast. Anyway, it's not really appropriate here so it should be removed >> as well. >> >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > > Acked-by: Christian König <christian.koenig@amd.com> Applied. thanks! Alex > >> --- >> v2: in v1 I just added a tab >> >> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c >> b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c >> index d911590d08bc..4c4bd72d4e40 100644 >> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c >> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c >> @@ -725,10 +725,8 @@ static void destruct(struct dcn10_resource_pool >> *pool) >> } >> } >> - for (i = 0; i < pool->base.stream_enc_count; i++) { >> - if (pool->base.stream_enc[i] != NULL) >> - kfree(DCE110STRENC_FROM_STRENC(pool->base.stream_enc[i])); >> - } >> + for (i = 0; i < pool->base.stream_enc_count; i++) >> + kfree(pool->base.stream_enc[i]); >> for (i = 0; i < pool->base.audio_count; i++) { >> if (pool->base.audios[i]) > > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com> To: "Christian König" <christian.koenig@amd.com> Cc: Tony Cheng <tony.cheng@amd.com>, David Airlie <airlied@linux.ie>, kernel-janitors@vger.kernel.org, amd-gfx list <amd-gfx@lists.freedesktop.org>, Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>, Hersen Wu <hersenxs.wu@amd.com>, Maling list - DRI developers <dri-devel@lists.freedesktop.org>, Alex Deucher <alexander.deucher@amd.com>, Dave Airlie <airlied@redhat.com>, Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>, Dan Carpenter <dan.carpenter@oracle.com> Subject: Re: [PATCH] drm/amd/display: small cleanup in destruct() Date: Mon, 6 Nov 2017 16:29:31 -0500 [thread overview] Message-ID: <CADnq5_NSTbpOrDHzWD9ug5jEQspeCO2qpri6f1VaaMKR3yqyDQ@mail.gmail.com> (raw) In-Reply-To: <031c92ca-86b0-718d-bf93-18d50db00ce9@amd.com> On Mon, Nov 6, 2017 at 3:44 AM, Christian König <christian.koenig@amd.com> wrote: > Am 06.11.2017 um 08:07 schrieb Dan Carpenter: >> >> Static analysis tools get annoyed that we don't indent this if >> statement. Actually, the if statement isn't required because kfree() >> can handle NULL pointers just fine. The DCE110STRENC_FROM_STRENC() >> macro is a wrapper around container_of() but it's basically a no-op or a >> cast. Anyway, it's not really appropriate here so it should be removed >> as well. >> >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > > Acked-by: Christian König <christian.koenig@amd.com> Applied. thanks! Alex > >> --- >> v2: in v1 I just added a tab >> >> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c >> b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c >> index d911590d08bc..4c4bd72d4e40 100644 >> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c >> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c >> @@ -725,10 +725,8 @@ static void destruct(struct dcn10_resource_pool >> *pool) >> } >> } >> - for (i = 0; i < pool->base.stream_enc_count; i++) { >> - if (pool->base.stream_enc[i] != NULL) >> - kfree(DCE110STRENC_FROM_STRENC(pool->base.stream_enc[i])); >> - } >> + for (i = 0; i < pool->base.stream_enc_count; i++) >> + kfree(pool->base.stream_enc[i]); >> for (i = 0; i < pool->base.audio_count; i++) { >> if (pool->base.audios[i]) > > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-11-06 21:29 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-04 6:12 [PATCH] drm/amd/display: indent an if statement Dan Carpenter 2017-11-04 6:12 ` Dan Carpenter 2017-11-04 9:16 ` walter harms 2017-11-04 9:16 ` walter harms [not found] ` <59FD8567.4030500-fPG8STNUNVg@public.gmane.org> 2017-11-04 10:07 ` Christian König 2017-11-04 10:07 ` Christian König 2017-11-06 7:07 ` [PATCH] drm/amd/display: small cleanup in destruct() Dan Carpenter 2017-11-06 7:07 ` Dan Carpenter 2017-11-06 8:44 ` Christian König 2017-11-06 8:44 ` Christian König 2017-11-06 21:29 ` Alex Deucher [this message] 2017-11-06 21:29 ` Alex Deucher 2017-11-06 6:42 ` [PATCH] drm/amd/display: indent an if statement Dan Carpenter 2017-11-06 6:42 ` Dan Carpenter 2018-08-14 9:09 ` Dan Carpenter 2018-08-14 9:09 ` Dan Carpenter [not found] ` <20180814090944.qjm4vxyrjdqxu4d7-vMlZ3nK25oGAIHFoDFOv9A@public.gmane.org> 2018-08-21 18:51 ` Harry Wentland 2018-08-21 18:51 ` Harry Wentland 2020-08-03 14:35 ` [PATCH] drm/amd/display: Indent " Dan Carpenter 2020-08-03 14:35 ` Dan Carpenter 2020-08-04 20:33 ` Alex Deucher 2020-08-04 20:33 ` Alex Deucher
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CADnq5_NSTbpOrDHzWD9ug5jEQspeCO2qpri6f1VaaMKR3yqyDQ@mail.gmail.com \ --to=alexdeucher@gmail.com \ --cc=Bhawanpreet.Lakha@amd.com \ --cc=Dmytro.Laktyushkin@amd.com \ --cc=airlied@linux.ie \ --cc=airlied@redhat.com \ --cc=alexander.deucher@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=christian.koenig@amd.com \ --cc=dan.carpenter@oracle.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=hersenxs.wu@amd.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=tony.cheng@amd.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.