From: Alex Deucher <alexdeucher@gmail.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org,
Sergey Larin <cerg2010cerg2010@mail.ru>,
Linux I2C <linux-i2c@vger.kernel.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] i2c: algos: bit: mention our experience about initial states
Date: Mon, 18 Jun 2018 12:03:22 -0400 [thread overview]
Message-ID: <CADnq5_Nfee+r-FC_c94-ByWqC9GBONr+Acr15ATb+5yAw_bWMA@mail.gmail.com> (raw)
In-Reply-To: <20180616133757.5994-3-wsa+renesas@sang-engineering.com>
On Sat, Jun 16, 2018 at 9:37 AM, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> So, if somebody wants to re-implement this in the future, we pinpoint to
> a problem case.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Series is:
Acked-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/i2c/algos/i2c-algo-bit.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/i2c/algos/i2c-algo-bit.c b/drivers/i2c/algos/i2c-algo-bit.c
> index 0c0eb16d710f..6ec65adaba49 100644
> --- a/drivers/i2c/algos/i2c-algo-bit.c
> +++ b/drivers/i2c/algos/i2c-algo-bit.c
> @@ -647,6 +647,11 @@ static int __i2c_bit_add_bus(struct i2c_adapter *adap,
> if (bit_adap->getscl == NULL)
> adap->quirks = &i2c_bit_quirk_no_clk_stretch;
>
> + /*
> + * We tried forcing SCL/SDA to an initial state here. But that caused a
> + * regression, sadly. Check Bugzilla #200045 for details.
> + */
> +
> ret = add_adapter(adap);
> if (ret < 0)
> return ret;
> --
> 2.11.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
linux-renesas-soc@vger.kernel.org,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
Sergey Larin <cerg2010cerg2010@mail.ru>
Subject: Re: [PATCH 2/2] i2c: algos: bit: mention our experience about initial states
Date: Mon, 18 Jun 2018 12:03:22 -0400 [thread overview]
Message-ID: <CADnq5_Nfee+r-FC_c94-ByWqC9GBONr+Acr15ATb+5yAw_bWMA@mail.gmail.com> (raw)
In-Reply-To: <20180616133757.5994-3-wsa+renesas@sang-engineering.com>
On Sat, Jun 16, 2018 at 9:37 AM, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> So, if somebody wants to re-implement this in the future, we pinpoint to
> a problem case.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Series is:
Acked-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/i2c/algos/i2c-algo-bit.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/i2c/algos/i2c-algo-bit.c b/drivers/i2c/algos/i2c-algo-bit.c
> index 0c0eb16d710f..6ec65adaba49 100644
> --- a/drivers/i2c/algos/i2c-algo-bit.c
> +++ b/drivers/i2c/algos/i2c-algo-bit.c
> @@ -647,6 +647,11 @@ static int __i2c_bit_add_bus(struct i2c_adapter *adap,
> if (bit_adap->getscl == NULL)
> adap->quirks = &i2c_bit_quirk_no_clk_stretch;
>
> + /*
> + * We tried forcing SCL/SDA to an initial state here. But that caused a
> + * regression, sadly. Check Bugzilla #200045 for details.
> + */
> +
> ret = add_adapter(adap);
> if (ret < 0)
> return ret;
> --
> 2.11.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-06-18 16:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-16 13:37 [PATCH 0/2] i2c: algos: bit: revert to fix regression (#200045) Wolfram Sang
2018-06-16 13:37 ` Wolfram Sang
2018-06-16 13:37 ` [PATCH 1/2] Revert "i2c: algo-bit: init the bus to a known state" Wolfram Sang
2018-06-16 13:37 ` Wolfram Sang
2018-06-26 2:37 ` Wolfram Sang
2018-06-26 2:37 ` Wolfram Sang
2018-06-16 13:37 ` [PATCH 2/2] i2c: algos: bit: mention our experience about initial states Wolfram Sang
2018-06-16 13:37 ` Wolfram Sang
2018-06-18 16:03 ` Alex Deucher [this message]
2018-06-18 16:03 ` Alex Deucher
2018-06-26 2:37 ` Wolfram Sang
2018-06-26 2:37 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_Nfee+r-FC_c94-ByWqC9GBONr+Acr15ATb+5yAw_bWMA@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=cerg2010cerg2010@mail.ru \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.