From: Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: zhengbin <zhengbin13-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: Chunming Zhou <David1.Zhou-5C7GfCeVMHo@public.gmane.org>,
"Leo (Sunpeng) Li" <sunpeng.li-5C7GfCeVMHo@public.gmane.org>,
amd-gfx list
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
Dave Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
Maling list - DRI developers
<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>,
"Deucher,
Alexander" <alexander.deucher-5C7GfCeVMHo@public.gmane.org>,
"Wentland, Harry" <harry.wentland-5C7GfCeVMHo@public.gmane.org>,
Christian Koenig <christian.koenig-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH] drm/amd/display: Use static const, not const static
Date: Mon, 11 Nov 2019 12:54:16 -0500 [thread overview]
Message-ID: <CADnq5_O9mh6=2RVe-GhxuV1DqN5iCpiXQWLQzK1cfE9zXye9-A@mail.gmail.com> (raw)
In-Reply-To: <1573464793-34901-1-git-send-email-zhengbin13-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Applied. Thanks!
Alex
On Mon, Nov 11, 2019 at 9:11 AM zhengbin <zhengbin13@huawei.com> wrote:
>
> Move the static keyword to the front of declarations.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 1fdba13..0d8c663 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -69,7 +69,7 @@
> #define DC_LOGGER \
> dc->ctx->logger
>
> -const static char DC_BUILD_ID[] = "production-build";
> +static const char DC_BUILD_ID[] = "production-build";
>
> /**
> * DOC: Overview
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: zhengbin <zhengbin13@huawei.com>
Cc: "Leo \(Sunpeng\) Li" <sunpeng.li@amd.com>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
Dave Airlie <airlied@linux.ie>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
"Deucher, Alexander" <alexander.deucher@amd.com>,
Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amd/display: Use static const, not const static
Date: Mon, 11 Nov 2019 12:54:16 -0500 [thread overview]
Message-ID: <CADnq5_O9mh6=2RVe-GhxuV1DqN5iCpiXQWLQzK1cfE9zXye9-A@mail.gmail.com> (raw)
Message-ID: <20191111175416.q4KAKIpH0w3eGXuSmp9-FJlXmlXFyH-h9rJRE_Nt8DM@z> (raw)
In-Reply-To: <1573464793-34901-1-git-send-email-zhengbin13@huawei.com>
Applied. Thanks!
Alex
On Mon, Nov 11, 2019 at 9:11 AM zhengbin <zhengbin13@huawei.com> wrote:
>
> Move the static keyword to the front of declarations.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 1fdba13..0d8c663 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -69,7 +69,7 @@
> #define DC_LOGGER \
> dc->ctx->logger
>
> -const static char DC_BUILD_ID[] = "production-build";
> +static const char DC_BUILD_ID[] = "production-build";
>
> /**
> * DOC: Overview
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: zhengbin <zhengbin13@huawei.com>
Cc: Chunming Zhou <David1.Zhou@amd.com>,
"Leo \(Sunpeng\) Li" <sunpeng.li@amd.com>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
Dave Airlie <airlied@linux.ie>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel@ffwll.ch>,
"Deucher, Alexander" <alexander.deucher@amd.com>,
"Wentland, Harry" <harry.wentland@amd.com>,
Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amd/display: Use static const, not const static
Date: Mon, 11 Nov 2019 12:54:16 -0500 [thread overview]
Message-ID: <CADnq5_O9mh6=2RVe-GhxuV1DqN5iCpiXQWLQzK1cfE9zXye9-A@mail.gmail.com> (raw)
Message-ID: <20191111175416.mp-iTHL1OvrC7iXgGZJGtVhWvU4BHKGxcfcOVPiYLzE@z> (raw)
In-Reply-To: <1573464793-34901-1-git-send-email-zhengbin13@huawei.com>
Applied. Thanks!
Alex
On Mon, Nov 11, 2019 at 9:11 AM zhengbin <zhengbin13@huawei.com> wrote:
>
> Move the static keyword to the front of declarations.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 1fdba13..0d8c663 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -69,7 +69,7 @@
> #define DC_LOGGER \
> dc->ctx->logger
>
> -const static char DC_BUILD_ID[] = "production-build";
> +static const char DC_BUILD_ID[] = "production-build";
>
> /**
> * DOC: Overview
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2019-11-11 17:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 9:33 [PATCH] drm/amd/display: Use static const, not const static zhengbin
2019-11-11 9:33 ` zhengbin
2019-11-11 9:33 ` zhengbin
[not found] ` <1573464793-34901-1-git-send-email-zhengbin13-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2019-11-11 17:54 ` Alex Deucher [this message]
2019-11-11 17:54 ` Alex Deucher
2019-11-11 17:54 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_O9mh6=2RVe-GhxuV1DqN5iCpiXQWLQzK1cfE9zXye9-A@mail.gmail.com' \
--to=alexdeucher-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=David1.Zhou-5C7GfCeVMHo@public.gmane.org \
--cc=airlied-cv59FeDIM0c@public.gmane.org \
--cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
--cc=daniel-/w4YWyX8dFk@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=harry.wentland-5C7GfCeVMHo@public.gmane.org \
--cc=sunpeng.li-5C7GfCeVMHo@public.gmane.org \
--cc=zhengbin13-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.