From: Alex Deucher <alexdeucher@gmail.com> To: YueHaibing <yuehaibing@huawei.com> Cc: "Deucher, Alexander" <alexander.deucher@amd.com>, Christian Koenig <christian.koenig@amd.com>, Chunming Zhou <David1.Zhou@amd.com>, Dave Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, kernel-janitors@vger.kernel.org, Maling list - DRI developers <dri-devel@lists.freedesktop.org>, amd-gfx list <amd-gfx@lists.freedesktop.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH -next] drm/ttm: remove set but not used variable 'rdev' Date: Thu, 21 Mar 2019 10:00:02 -0400 [thread overview] Message-ID: <CADnq5_OS8SkHxFp41u_BwQRMZAr+3KHACRndSn+bROnMPQE9JA@mail.gmail.com> (raw) In-Reply-To: <20190320125939.74347-1-yuehaibing@huawei.com> On Wed, Mar 20, 2019 at 9:25 AM YueHaibing <yuehaibing@huawei.com> wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/radeon/radeon_ttm.c: In function 'radeon_move_vram_ram': > drivers/gpu/drm/radeon/radeon_ttm.c:254:24: warning: > variable 'rdev' set but not used [-Wunused-but-set-variable] > > drivers/gpu/drm/radeon/radeon_ttm.c: In function 'radeon_move_ram_vram': > drivers/gpu/drm/radeon/radeon_ttm.c:301:24: warning: > variable 'rdev' set but not used [-Wunused-but-set-variable] > > It's not used since a987fcaa805f ("ttm: Make parts of a struct ttm_bo_device > global.") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Applied. thanks! Alex > --- > drivers/gpu/drm/radeon/radeon_ttm.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c > index 557bdd7a2fc8..5d42f8d8e68d 100644 > --- a/drivers/gpu/drm/radeon/radeon_ttm.c > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c > @@ -251,14 +251,12 @@ static int radeon_move_vram_ram(struct ttm_buffer_object *bo, > struct ttm_mem_reg *new_mem) > { > struct ttm_operation_ctx ctx = { interruptible, no_wait_gpu }; > - struct radeon_device *rdev; > struct ttm_mem_reg *old_mem = &bo->mem; > struct ttm_mem_reg tmp_mem; > struct ttm_place placements; > struct ttm_placement placement; > int r; > > - rdev = radeon_get_rdev(bo->bdev); > tmp_mem = *new_mem; > tmp_mem.mm_node = NULL; > placement.num_placement = 1; > @@ -298,14 +296,12 @@ static int radeon_move_ram_vram(struct ttm_buffer_object *bo, > struct ttm_mem_reg *new_mem) > { > struct ttm_operation_ctx ctx = { interruptible, no_wait_gpu }; > - struct radeon_device *rdev; > struct ttm_mem_reg *old_mem = &bo->mem; > struct ttm_mem_reg tmp_mem; > struct ttm_placement placement; > struct ttm_place placements; > int r; > > - rdev = radeon_get_rdev(bo->bdev); > tmp_mem = *new_mem; > tmp_mem.mm_node = NULL; > placement.num_placement = 1; > > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com> To: YueHaibing <yuehaibing@huawei.com> Cc: "Deucher, Alexander" <alexander.deucher@amd.com>, Christian Koenig <christian.koenig@amd.com>, Chunming Zhou <David1.Zhou@amd.com>, Dave Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, kernel-janitors@vger.kernel.org, Maling list - DRI developers <dri-devel@lists.freedesktop.org>, amd-gfx list <amd-gfx@lists.freedesktop.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH -next] drm/ttm: remove set but not used variable 'rdev' Date: Thu, 21 Mar 2019 14:00:02 +0000 [thread overview] Message-ID: <CADnq5_OS8SkHxFp41u_BwQRMZAr+3KHACRndSn+bROnMPQE9JA@mail.gmail.com> (raw) In-Reply-To: <20190320125939.74347-1-yuehaibing@huawei.com> On Wed, Mar 20, 2019 at 9:25 AM YueHaibing <yuehaibing@huawei.com> wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/radeon/radeon_ttm.c: In function 'radeon_move_vram_ram': > drivers/gpu/drm/radeon/radeon_ttm.c:254:24: warning: > variable 'rdev' set but not used [-Wunused-but-set-variable] > > drivers/gpu/drm/radeon/radeon_ttm.c: In function 'radeon_move_ram_vram': > drivers/gpu/drm/radeon/radeon_ttm.c:301:24: warning: > variable 'rdev' set but not used [-Wunused-but-set-variable] > > It's not used since a987fcaa805f ("ttm: Make parts of a struct ttm_bo_device > global.") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Applied. thanks! Alex > --- > drivers/gpu/drm/radeon/radeon_ttm.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c > index 557bdd7a2fc8..5d42f8d8e68d 100644 > --- a/drivers/gpu/drm/radeon/radeon_ttm.c > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c > @@ -251,14 +251,12 @@ static int radeon_move_vram_ram(struct ttm_buffer_object *bo, > struct ttm_mem_reg *new_mem) > { > struct ttm_operation_ctx ctx = { interruptible, no_wait_gpu }; > - struct radeon_device *rdev; > struct ttm_mem_reg *old_mem = &bo->mem; > struct ttm_mem_reg tmp_mem; > struct ttm_place placements; > struct ttm_placement placement; > int r; > > - rdev = radeon_get_rdev(bo->bdev); > tmp_mem = *new_mem; > tmp_mem.mm_node = NULL; > placement.num_placement = 1; > @@ -298,14 +296,12 @@ static int radeon_move_ram_vram(struct ttm_buffer_object *bo, > struct ttm_mem_reg *new_mem) > { > struct ttm_operation_ctx ctx = { interruptible, no_wait_gpu }; > - struct radeon_device *rdev; > struct ttm_mem_reg *old_mem = &bo->mem; > struct ttm_mem_reg tmp_mem; > struct ttm_placement placement; > struct ttm_place placements; > int r; > > - rdev = radeon_get_rdev(bo->bdev); > tmp_mem = *new_mem; > tmp_mem.mm_node = NULL; > placement.num_placement = 1; > > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2019-03-21 14:00 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-20 12:59 [PATCH -next] drm/ttm: remove set but not used variable 'rdev' YueHaibing 2019-03-20 12:59 ` YueHaibing 2019-03-20 12:59 ` YueHaibing 2019-03-21 14:00 ` Alex Deucher [this message] 2019-03-21 14:00 ` Alex Deucher 2019-03-21 14:00 ` Alex Deucher -- strict thread matches above, loose matches on Subject: below -- 2019-02-18 13:59 [PATCH -next] drm/ttm: remove set but not used variable 'bdev' YueHaibing 2019-02-18 13:59 ` YueHaibing 2019-02-18 13:59 ` YueHaibing 2019-02-28 2:41 ` Alex Deucher 2019-02-28 2:41 ` Alex Deucher 2019-02-28 2:41 ` Alex Deucher 2018-11-08 2:15 [PATCH -next] drm/ttm: remove set but not used variable 'driver' YueHaibing 2018-11-08 2:15 ` YueHaibing 2018-11-08 2:15 ` YueHaibing 2018-11-08 2:17 ` Zhang, Jerry(Junwei) 2018-11-08 2:17 ` Zhang, Jerry(Junwei) 2018-11-08 2:17 ` Zhang, Jerry(Junwei) 2018-11-08 6:11 ` Huang, Ray 2018-11-08 6:11 ` Huang, Ray 2018-11-08 6:11 ` Huang, Ray 2018-11-08 8:17 ` Koenig, Christian 2018-11-08 8:17 ` Koenig, Christian 2018-11-08 8:17 ` Koenig, Christian 2019-03-20 1:51 ` [PATCH -next] drm/ttm: remove set but not used variable 'vgdev' YueHaibing 2019-03-20 2:03 ` YueHaibing 2019-03-20 2:03 ` YueHaibing 2019-03-25 9:02 ` Daniel Vetter 2019-03-25 9:02 ` Daniel Vetter 2019-03-25 9:02 ` Daniel Vetter 2019-03-25 9:11 ` YueHaibing 2019-03-25 9:11 ` YueHaibing 2019-03-25 9:11 ` YueHaibing 2019-03-25 9:26 ` [PATCH v2 -next] drm/virtio: " YueHaibing 2019-03-25 9:26 ` YueHaibing 2019-03-25 11:35 ` Mukesh Ojha 2019-03-25 11:35 ` Mukesh Ojha 2019-03-27 14:47 ` Mukesh Ojha 2019-03-27 14:47 ` Mukesh Ojha 2019-03-27 14:59 ` Mukesh Ojha 2019-03-28 10:32 ` Gerd Hoffmann 2019-03-28 10:32 ` Gerd Hoffmann 2019-03-28 10:32 ` Gerd Hoffmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CADnq5_OS8SkHxFp41u_BwQRMZAr+3KHACRndSn+bROnMPQE9JA@mail.gmail.com \ --to=alexdeucher@gmail.com \ --cc=David1.Zhou@amd.com \ --cc=airlied@linux.ie \ --cc=alexander.deucher@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=christian.koenig@amd.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=yuehaibing@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.