From: Alex Deucher <alexdeucher@gmail.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: "Wentland, Harry" <harry.wentland@amd.com>,
"Leo (Sunpeng) Li" <sunpeng.li@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
Dave Airlie <airlied@linux.ie>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
"Deucher, Alexander" <alexander.deucher@amd.com>,
Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amd/display: remove unnecessary conversion to bool
Date: Thu, 25 Feb 2021 16:30:52 -0500 [thread overview]
Message-ID: <CADnq5_OwCB1+uXRoqHfkHp3t6kvY8Emu=pLgoTJ6VkyWPFJDLw@mail.gmail.com> (raw)
In-Reply-To: <1614244742-67869-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On Thu, Feb 25, 2021 at 4:19 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c:243:67-72:
> WARNING: conversion to bool not needed here.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c
> index 3398540..102f6a0 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c
> @@ -240,7 +240,7 @@ bool dpp3_program_gamcor_lut(
> next_mode = LUT_RAM_A;
>
> dpp3_power_on_gamcor_lut(dpp_base, true);
> - dpp3_configure_gamcor_lut(dpp_base, next_mode == LUT_RAM_A ? true:false);
> + dpp3_configure_gamcor_lut(dpp_base, next_mode == LUT_RAM_A);
>
> if (next_mode == LUT_RAM_B) {
> gam_regs.start_cntl_b = REG(CM_GAMCOR_RAMB_START_CNTL_B);
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: "Leo \(Sunpeng\) Li" <sunpeng.li@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
Dave Airlie <airlied@linux.ie>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
"Deucher, Alexander" <alexander.deucher@amd.com>,
Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amd/display: remove unnecessary conversion to bool
Date: Thu, 25 Feb 2021 16:30:52 -0500 [thread overview]
Message-ID: <CADnq5_OwCB1+uXRoqHfkHp3t6kvY8Emu=pLgoTJ6VkyWPFJDLw@mail.gmail.com> (raw)
In-Reply-To: <1614244742-67869-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On Thu, Feb 25, 2021 at 4:19 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c:243:67-72:
> WARNING: conversion to bool not needed here.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c
> index 3398540..102f6a0 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c
> @@ -240,7 +240,7 @@ bool dpp3_program_gamcor_lut(
> next_mode = LUT_RAM_A;
>
> dpp3_power_on_gamcor_lut(dpp_base, true);
> - dpp3_configure_gamcor_lut(dpp_base, next_mode == LUT_RAM_A ? true:false);
> + dpp3_configure_gamcor_lut(dpp_base, next_mode == LUT_RAM_A);
>
> if (next_mode == LUT_RAM_B) {
> gam_regs.start_cntl_b = REG(CM_GAMCOR_RAMB_START_CNTL_B);
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: "Leo \(Sunpeng\) Li" <sunpeng.li@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
Dave Airlie <airlied@linux.ie>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
"Deucher, Alexander" <alexander.deucher@amd.com>,
"Wentland, Harry" <harry.wentland@amd.com>,
Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amd/display: remove unnecessary conversion to bool
Date: Thu, 25 Feb 2021 16:30:52 -0500 [thread overview]
Message-ID: <CADnq5_OwCB1+uXRoqHfkHp3t6kvY8Emu=pLgoTJ6VkyWPFJDLw@mail.gmail.com> (raw)
In-Reply-To: <1614244742-67869-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On Thu, Feb 25, 2021 at 4:19 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c:243:67-72:
> WARNING: conversion to bool not needed here.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c
> index 3398540..102f6a0 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c
> @@ -240,7 +240,7 @@ bool dpp3_program_gamcor_lut(
> next_mode = LUT_RAM_A;
>
> dpp3_power_on_gamcor_lut(dpp_base, true);
> - dpp3_configure_gamcor_lut(dpp_base, next_mode == LUT_RAM_A ? true:false);
> + dpp3_configure_gamcor_lut(dpp_base, next_mode == LUT_RAM_A);
>
> if (next_mode == LUT_RAM_B) {
> gam_regs.start_cntl_b = REG(CM_GAMCOR_RAMB_START_CNTL_B);
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-02-25 21:31 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 9:19 [PATCH] drm/amd/display: remove unnecessary conversion to bool Jiapeng Chong
2021-02-25 9:19 ` Jiapeng Chong
2021-02-25 9:19 ` Jiapeng Chong
2021-02-25 21:30 ` Alex Deucher [this message]
2021-02-25 21:30 ` Alex Deucher
2021-02-25 21:30 ` Alex Deucher
-- strict thread matches above, loose matches on Subject: below --
2021-03-22 2:22 [PATCH] drm/amd/display: Remove " Jiapeng Chong
2021-03-22 2:22 ` Jiapeng Chong
2021-03-22 2:22 ` Jiapeng Chong
2021-03-18 2:36 Jiapeng Chong
2021-03-18 2:36 ` Jiapeng Chong
2021-03-18 2:36 ` Jiapeng Chong
2021-03-18 3:11 ` Alex Deucher
2021-03-18 3:11 ` Alex Deucher
2021-03-18 3:11 ` Alex Deucher
2021-03-16 8:08 Jiapeng Chong
2021-03-16 8:08 ` Jiapeng Chong
2021-03-16 8:08 ` Jiapeng Chong
2021-03-18 3:09 ` Alex Deucher
2021-03-18 3:09 ` Alex Deucher
2021-03-18 3:09 ` Alex Deucher
2021-03-15 8:22 Jiapeng Chong
2021-03-15 8:22 ` Jiapeng Chong
2021-03-15 8:22 ` Jiapeng Chong
2021-03-15 18:27 ` Alex Deucher
2021-03-15 18:27 ` Alex Deucher
2021-03-15 18:27 ` Alex Deucher
2021-03-09 8:02 Jiapeng Chong
2021-03-09 8:02 ` Jiapeng Chong
2021-03-09 8:02 ` Jiapeng Chong
2021-03-08 3:00 Jiapeng Chong
2021-03-08 3:00 ` Jiapeng Chong
2021-03-08 3:00 ` Jiapeng Chong
2021-03-08 21:56 ` Alex Deucher
2021-03-08 21:56 ` Alex Deucher
2021-03-08 21:56 ` Alex Deucher
2021-03-05 6:40 Jiapeng Chong
2021-03-05 6:40 ` Jiapeng Chong
2021-03-05 6:40 ` Jiapeng Chong
2021-03-05 19:14 ` Alex Deucher
2021-03-05 19:14 ` Alex Deucher
2021-03-05 19:14 ` Alex Deucher
2021-03-01 6:49 Jiapeng Chong
2021-03-01 6:49 ` Jiapeng Chong
2021-03-01 6:49 ` Jiapeng Chong
2021-03-02 18:21 ` Alex Deucher
2021-03-02 18:21 ` Alex Deucher
2021-03-02 18:21 ` Alex Deucher
2021-02-23 6:13 Jiapeng Chong
2021-02-23 6:13 ` Jiapeng Chong
2021-02-23 6:13 ` Jiapeng Chong
2021-02-23 16:02 ` Alex Deucher
2021-02-23 16:02 ` Alex Deucher
2021-02-23 16:02 ` Alex Deucher
2021-02-20 7:40 Jiapeng Chong
2021-02-20 7:40 ` Jiapeng Chong
2021-02-20 7:40 ` Jiapeng Chong
2020-01-10 7:16 [PATCH] drm/amd/display: remove " Chen Zhou
2020-01-10 7:16 ` Chen Zhou
2020-01-10 21:41 ` Harry Wentland
2020-01-10 21:41 ` Harry Wentland
2020-01-11 0:17 ` Alex Deucher
2020-01-11 0:17 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_OwCB1+uXRoqHfkHp3t6kvY8Emu=pLgoTJ6VkyWPFJDLw@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.