From: Stephen Boyd <swboyd@chromium.org>
To: Kuogee Hsieh <quic_khsieh@quicinc.com>,
agross@kernel.org, airlied@linux.ie, bjorn.andersson@linaro.org,
daniel@ffwll.ch, dianders@chromium.org,
dmitry.baryshkov@linaro.org, dri-devel@lists.freedesktop.org,
robdclark@gmail.com, sean@poorly.run, vkoul@kernel.org
Cc: quic_sbillaka@quicinc.com, linux-arm-msm@vger.kernel.org,
quic_abhinavk@quicinc.com, linux-kernel@vger.kernel.org,
quic_aravindh@quicinc.com, freedreno@lists.freedesktop.org
Subject: Re: [PATCH v8 1/2] drm/msm/dp: force link training for display resolution change
Date: Thu, 16 Jun 2022 13:08:46 -0700 [thread overview]
Message-ID: <CAE-0n50GVKagM5Q0vZnMREesJqa99bEouiiB7PeG1nzix7EmdQ@mail.gmail.com> (raw)
In-Reply-To: <1655399361-10842-2-git-send-email-quic_khsieh@quicinc.com>
Quoting Kuogee Hsieh (2022-06-16 10:09:20)
> diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.h b/drivers/gpu/drm/msm/dp/dp_ctrl.h
> index 0745fde..9a39b00 100644
> --- a/drivers/gpu/drm/msm/dp/dp_ctrl.h
> +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.h
> @@ -21,7 +21,8 @@ struct dp_ctrl {
> };
>
> int dp_ctrl_on_link(struct dp_ctrl *dp_ctrl);
> -int dp_ctrl_on_stream(struct dp_ctrl *dp_ctrl);
> +int dp_ctrl_on_stream(struct dp_ctrl *dp_ctrl, bool force_link_train);
> +int dp_ctrl_on_stream_phy_test_report(struct dp_ctrl *dp_ctrl);
Instead of declaring it here how about forward declaring it in the C
file and making it static?
> int dp_ctrl_off_link_stream(struct dp_ctrl *dp_ctrl);
> int dp_ctrl_off_link(struct dp_ctrl *dp_ctrl);
> int dp_ctrl_off(struct dp_ctrl *dp_ctrl);
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org>
To: Kuogee Hsieh <quic_khsieh@quicinc.com>,
agross@kernel.org, airlied@linux.ie, bjorn.andersson@linaro.org,
daniel@ffwll.ch, dianders@chromium.org,
dmitry.baryshkov@linaro.org, dri-devel@lists.freedesktop.org,
robdclark@gmail.com, sean@poorly.run, vkoul@kernel.org
Cc: quic_abhinavk@quicinc.com, quic_aravindh@quicinc.com,
quic_sbillaka@quicinc.com, freedreno@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 1/2] drm/msm/dp: force link training for display resolution change
Date: Thu, 16 Jun 2022 13:08:46 -0700 [thread overview]
Message-ID: <CAE-0n50GVKagM5Q0vZnMREesJqa99bEouiiB7PeG1nzix7EmdQ@mail.gmail.com> (raw)
In-Reply-To: <1655399361-10842-2-git-send-email-quic_khsieh@quicinc.com>
Quoting Kuogee Hsieh (2022-06-16 10:09:20)
> diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.h b/drivers/gpu/drm/msm/dp/dp_ctrl.h
> index 0745fde..9a39b00 100644
> --- a/drivers/gpu/drm/msm/dp/dp_ctrl.h
> +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.h
> @@ -21,7 +21,8 @@ struct dp_ctrl {
> };
>
> int dp_ctrl_on_link(struct dp_ctrl *dp_ctrl);
> -int dp_ctrl_on_stream(struct dp_ctrl *dp_ctrl);
> +int dp_ctrl_on_stream(struct dp_ctrl *dp_ctrl, bool force_link_train);
> +int dp_ctrl_on_stream_phy_test_report(struct dp_ctrl *dp_ctrl);
Instead of declaring it here how about forward declaring it in the C
file and making it static?
> int dp_ctrl_off_link_stream(struct dp_ctrl *dp_ctrl);
> int dp_ctrl_off_link(struct dp_ctrl *dp_ctrl);
> int dp_ctrl_off(struct dp_ctrl *dp_ctrl);
next prev parent reply other threads:[~2022-06-16 20:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 17:09 [PATCH v8 0/2] force link training for display resolution change Kuogee Hsieh
2022-06-16 17:09 ` Kuogee Hsieh
2022-06-16 17:09 ` [PATCH v8 1/2] drm/msm/dp: " Kuogee Hsieh
2022-06-16 17:09 ` Kuogee Hsieh
2022-06-16 20:08 ` Stephen Boyd [this message]
2022-06-16 20:08 ` Stephen Boyd
2022-06-22 7:26 ` Dmitry Baryshkov
2022-06-22 7:26 ` Dmitry Baryshkov
2022-06-22 15:21 ` Kuogee Hsieh
2022-06-22 15:21 ` Kuogee Hsieh
2022-06-16 17:09 ` [PATCH v8 2/2] drm/msm/dp: clean up pixel_rate from dp_ctrl.c Kuogee Hsieh
2022-06-16 17:09 ` Kuogee Hsieh
2022-06-16 20:07 ` Stephen Boyd
2022-06-16 20:07 ` Stephen Boyd
2022-06-16 20:29 ` Kuogee Hsieh
2022-06-16 20:29 ` Kuogee Hsieh
2022-06-16 21:06 ` kernel test robot
2022-06-16 21:06 ` kernel test robot
2022-06-17 16:05 ` kernel test robot
2022-06-17 16:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE-0n50GVKagM5Q0vZnMREesJqa99bEouiiB7PeG1nzix7EmdQ@mail.gmail.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_aravindh@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_sbillaka@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.