From: Stephen Boyd <swboyd@chromium.org>
To: Johan Hovold <johan@kernel.org>
Cc: stable@vger.kernel.org, Johan Hovold <johan+linaro@kernel.org>,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH 5.15.y 4/4] phy: qcom-qmp-combo: fix runtime suspend
Date: Fri, 13 Jan 2023 14:04:35 -0600 [thread overview]
Message-ID: <CAE-0n50bbUJGfdXLhD2FP6-dwZEn_AqyB-fCTxgnZ=YBUQdUAw@mail.gmail.com> (raw)
In-Reply-To: <Y8ERv0712EfPJWtF@hovoldconsulting.com>
Quoting Johan Hovold (2023-01-13 00:09:35)
> On Thu, Jan 12, 2023 at 04:54:05PM -0800, Stephen Boyd wrote:
> > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
> > index 9fda6d283f20..d928afe2ebba 100644
> > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> > @@ -4985,15 +4985,11 @@ static void qcom_qmp_phy_disable_autonomous_mode(struct qmp_phy *qphy)
> > static int __maybe_unused qcom_qmp_phy_runtime_suspend(struct device *dev)
> > {
> > struct qcom_qmp *qmp = dev_get_drvdata(dev);
> > - struct qmp_phy *qphy = qmp->phys[0];
> > + struct qmp_phy *qphy = qmp->usb_phy;
> > const struct qmp_phy_cfg *cfg = qphy->cfg;
> >
> > dev_vdbg(dev, "Suspending QMP phy, mode:%d\n", qphy->mode);
>
> So this doesn't work currently either as the usb_phy pointer is not set
> for PCIe and UFS PHYs.
Cool, setting usb_phy for pcie and ufs fixes this.
prev parent reply other threads:[~2023-01-13 20:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 0:54 [PATCH 5.15.y 0/4] phy: qcom-qmp-combo: Backport some stable fixes Stephen Boyd
2023-01-13 0:54 ` [PATCH 5.15.y 1/4] phy: qcom-qmp-combo: disable runtime PM on unbind Stephen Boyd
2023-01-13 0:54 ` [PATCH 5.15.y 2/4] phy: qcom-qmp-combo: fix memleak on probe deferral Stephen Boyd
2023-01-13 7:57 ` Johan Hovold
2023-01-13 19:53 ` Stephen Boyd
2023-01-13 0:54 ` [PATCH 5.15.y 3/4] phy: qcom-qmp-combo: fix broken power on Stephen Boyd
2023-01-13 8:07 ` Johan Hovold
2023-01-13 20:03 ` Stephen Boyd
2023-01-13 0:54 ` [PATCH 5.15.y 4/4] phy: qcom-qmp-combo: fix runtime suspend Stephen Boyd
2023-01-13 8:09 ` Johan Hovold
2023-01-13 20:04 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE-0n50bbUJGfdXLhD2FP6-dwZEn_AqyB-fCTxgnZ=YBUQdUAw@mail.gmail.com' \
--to=swboyd@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.