From: Johan Hovold <johan@kernel.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: stable@vger.kernel.org, Johan Hovold <johan+linaro@kernel.org>,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH 5.15.y 2/4] phy: qcom-qmp-combo: fix memleak on probe deferral
Date: Fri, 13 Jan 2023 08:57:39 +0100 [thread overview]
Message-ID: <Y8EO8w9Smn4NAox6@hovoldconsulting.com> (raw)
In-Reply-To: <20230113005405.3992011-3-swboyd@chromium.org>
On Thu, Jan 12, 2023 at 04:54:03PM -0800, Stephen Boyd wrote:
> From: Johan Hovold <johan+linaro@kernel.org>
>
> commit 2de8a325b1084330ae500380cc27edc39f488c30 upstream.
>
> Switch to using the device-managed of_iomap helper to avoid leaking
> memory on probe deferral and driver unbind.
>
> Note that this helper checks for already reserved regions and may fail
> if there are multiple devices claiming the same memory.
This bit turned out to catch some buggy bindings and dts, so if you want
to backport this one then the corresponding fixes for that would be
needed as well.
That includes
a5d6b1ac56cb ("phy: qcom-qmp-usb: fix memleak on probe deferral")
and some dts fixes which likely already have been backported.
It may even be preferred to keep to just skip this patch and keep those
small memory leaks on probe deferral to not risk any regressions in
stable.
> Fixes: e78f3d15e115 ("phy: qcom-qmp: new qmp phy driver for qcom-chipsets")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> Link: https://lore.kernel.org/r/20220916102340.11520-5-johan+linaro@kernel.org
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Johan
next prev parent reply other threads:[~2023-01-13 7:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 0:54 [PATCH 5.15.y 0/4] phy: qcom-qmp-combo: Backport some stable fixes Stephen Boyd
2023-01-13 0:54 ` [PATCH 5.15.y 1/4] phy: qcom-qmp-combo: disable runtime PM on unbind Stephen Boyd
2023-01-13 0:54 ` [PATCH 5.15.y 2/4] phy: qcom-qmp-combo: fix memleak on probe deferral Stephen Boyd
2023-01-13 7:57 ` Johan Hovold [this message]
2023-01-13 19:53 ` Stephen Boyd
2023-01-13 0:54 ` [PATCH 5.15.y 3/4] phy: qcom-qmp-combo: fix broken power on Stephen Boyd
2023-01-13 8:07 ` Johan Hovold
2023-01-13 20:03 ` Stephen Boyd
2023-01-13 0:54 ` [PATCH 5.15.y 4/4] phy: qcom-qmp-combo: fix runtime suspend Stephen Boyd
2023-01-13 8:09 ` Johan Hovold
2023-01-13 20:04 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8EO8w9Smn4NAox6@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.