From: Stephen Boyd <swboyd@chromium.org>
To: cgel.zte@gmail.com, robdclark@gmail.com, sean@poorly.run
Cc: quic_abhinavk@quicinc.com, airlied@linux.ie, daniel@ffwll.ch,
dmitry.baryshkov@linaro.org, bjorn.andersson@linaro.org,
angelogioacchino.delregno@somainline.org, tiny.windzz@gmail.com,
architt@codeaurora.org, jsanka@codeaurora.org,
skolluku@codeaurora.org, ryadav@codeaurora.org,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Lv Ruyi <lv.ruyi@zte.com.cn>, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] drm/msm/dpu: fix error check return value of irq_of_parse_and_map()
Date: Mon, 25 Apr 2022 13:10:29 -0700 [thread overview]
Message-ID: <CAE-0n50fs1fFQcwMCq_x_UG8ZJKprjcYKwcy1+1ckD--XE28+g@mail.gmail.com> (raw)
In-Reply-To: <20220425090947.3498897-1-lv.ruyi@zte.com.cn>
Quoting cgel.zte@gmail.com (2022-04-25 02:09:47)
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> The irq_of_parse_and_map() function returns 0 on failure, and does not
> return a negative value anyhow, so never enter this conditional branch.
>
> Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
Question still stands why we can't use platform device APIs.
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org>
To: cgel.zte@gmail.com, robdclark@gmail.com, sean@poorly.run
Cc: architt@codeaurora.org, linux-kernel@vger.kernel.org,
ryadav@codeaurora.org, airlied@linux.ie,
linux-arm-msm@vger.kernel.org, Lv Ruyi <lv.ruyi@zte.com.cn>,
quic_abhinavk@quicinc.com, dri-devel@lists.freedesktop.org,
bjorn.andersson@linaro.org, tiny.windzz@gmail.com,
angelogioacchino.delregno@somainline.org,
dmitry.baryshkov@linaro.org, jsanka@codeaurora.org,
freedreno@lists.freedesktop.org, Zeal Robot <zealci@zte.com.cn>,
skolluku@codeaurora.org
Subject: Re: [PATCH] drm/msm/dpu: fix error check return value of irq_of_parse_and_map()
Date: Mon, 25 Apr 2022 13:10:29 -0700 [thread overview]
Message-ID: <CAE-0n50fs1fFQcwMCq_x_UG8ZJKprjcYKwcy1+1ckD--XE28+g@mail.gmail.com> (raw)
In-Reply-To: <20220425090947.3498897-1-lv.ruyi@zte.com.cn>
Quoting cgel.zte@gmail.com (2022-04-25 02:09:47)
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> The irq_of_parse_and_map() function returns 0 on failure, and does not
> return a negative value anyhow, so never enter this conditional branch.
>
> Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
Question still stands why we can't use platform device APIs.
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
next prev parent reply other threads:[~2022-04-25 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 9:09 [PATCH] drm/msm/dpu: fix error check return value of irq_of_parse_and_map() cgel.zte
2022-04-25 9:09 ` cgel.zte
2022-04-25 20:10 ` Stephen Boyd [this message]
2022-04-25 20:10 ` Stephen Boyd
2022-04-25 21:08 ` Dmitry Baryshkov
2022-04-25 21:08 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE-0n50fs1fFQcwMCq_x_UG8ZJKprjcYKwcy1+1ckD--XE28+g@mail.gmail.com \
--to=swboyd@chromium.org \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@somainline.org \
--cc=architt@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=cgel.zte@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jsanka@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.ruyi@zte.com.cn \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=ryadav@codeaurora.org \
--cc=sean@poorly.run \
--cc=skolluku@codeaurora.org \
--cc=tiny.windzz@gmail.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.