From: Stephen Boyd <swboyd@chromium.org>
To: Rob Clark <robdclark@gmail.com>, alsa-devel@alsa-project.org
Cc: Derek Fang <derek.fang@realtek.com>,
linux-arm-msm@vger.kernel.org, Rob Clark <robdclark@chromium.org>,
Oder Chiou <oder_chiou@realtek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: rt5682s: Fix crash due to out of scope stack vars
Date: Wed, 17 Nov 2021 17:36:27 -0800 [thread overview]
Message-ID: <CAE-0n52AAfNqYP5MM1CUntkM15ftskuPVRNyCbBdCbp8mFHL2Q@mail.gmail.com> (raw)
In-Reply-To: <20211118010453.843286-2-robdclark@gmail.com>
Quoting Rob Clark (2021-11-17 17:04:53)
> From: Rob Clark <robdclark@chromium.org>
>
> Move the declaration of temporary arrays to somewhere that won't go out
> of scope before the devm_clk_hw_register() call, lest we be at the whim
> of the compiler for whether those stack variables get overwritten.
>
> Fixes a crash seen with gcc version 11.2.1 20210728 (Red Hat 11.2.1-1)
>
> Fixes: bdd229ab26be ("ASoC: rt5682s: Add driver for ALC5682I-VS codec")
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org>
To: Rob Clark <robdclark@gmail.com>, alsa-devel@alsa-project.org
Cc: Rob Clark <robdclark@chromium.org>,
Oder Chiou <oder_chiou@realtek.com>,
linux-arm-msm@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Derek Fang <derek.fang@realtek.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: rt5682s: Fix crash due to out of scope stack vars
Date: Wed, 17 Nov 2021 17:36:27 -0800 [thread overview]
Message-ID: <CAE-0n52AAfNqYP5MM1CUntkM15ftskuPVRNyCbBdCbp8mFHL2Q@mail.gmail.com> (raw)
In-Reply-To: <20211118010453.843286-2-robdclark@gmail.com>
Quoting Rob Clark (2021-11-17 17:04:53)
> From: Rob Clark <robdclark@chromium.org>
>
> Move the declaration of temporary arrays to somewhere that won't go out
> of scope before the devm_clk_hw_register() call, lest we be at the whim
> of the compiler for whether those stack variables get overwritten.
>
> Fixes a crash seen with gcc version 11.2.1 20210728 (Red Hat 11.2.1-1)
>
> Fixes: bdd229ab26be ("ASoC: rt5682s: Add driver for ALC5682I-VS codec")
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
next prev parent reply other threads:[~2021-11-18 1:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 1:04 [PATCH 1/2] ASoC: rt5682: Fix crash due to out of scope stack vars Rob Clark
2021-11-18 1:04 ` Rob Clark
2021-11-18 1:04 ` [PATCH 2/2] ASoC: rt5682s: " Rob Clark
2021-11-18 1:04 ` Rob Clark
2021-11-18 1:36 ` Stephen Boyd [this message]
2021-11-18 1:36 ` Stephen Boyd
2021-11-18 1:36 ` [PATCH 1/2] ASoC: rt5682: " Stephen Boyd
2021-11-18 1:36 ` Stephen Boyd
2021-11-27 1:29 ` Mark Brown
2021-11-27 1:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE-0n52AAfNqYP5MM1CUntkM15ftskuPVRNyCbBdCbp8mFHL2Q@mail.gmail.com \
--to=swboyd@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.