From: Stephen Boyd <swboyd@chromium.org> To: Kuogee Hsieh <khsieh@codeaurora.org>, dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run Cc: abhinavk@codeaurora.org, aravindh@codeaurora.org, airlied@linux.ie, daniel@ffwll.ch, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/7] drm/msm/dp: return correct edid checksum after corrupted edid checksum read Date: Thu, 22 Jul 2021 19:23:29 +0000 [thread overview] Message-ID: <CAE-0n539r5zQx7zX9bECspKUAypQ8VucgeMNTmqAjHOCemVmOg@mail.gmail.com> (raw) In-Reply-To: <1626191647-13901-6-git-send-email-khsieh@codeaurora.org> Quoting Kuogee Hsieh (2021-07-13 08:54:05) > diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c > index 88196f7..0fdb551 100644 > --- a/drivers/gpu/drm/msm/dp/dp_panel.c > +++ b/drivers/gpu/drm/msm/dp/dp_panel.c > @@ -303,7 +303,12 @@ void dp_panel_handle_sink_request(struct dp_panel *dp_panel) > panel = container_of(dp_panel, struct dp_panel_private, dp_panel); > > if (panel->link->sink_request & DP_TEST_LINK_EDID_READ) { > - u8 checksum = dp_panel_get_edid_checksum(dp_panel->edid); > + u8 checksum; > + > + if (dp_panel->edid) > + checksum = dp_panel_get_edid_checksum(dp_panel->edid); > + else > + checksum = dp_panel->connector->real_edid_checksum; Is there any reason why we can't use connector->real_edid_checksum all the time? > > dp_link_send_edid_checksum(panel->link, checksum); > dp_link_send_test_response(panel->link);
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org> To: Kuogee Hsieh <khsieh@codeaurora.org>, dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run Cc: airlied@linux.ie, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, abhinavk@codeaurora.org, bjorn.andersson@linaro.org, aravindh@codeaurora.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH v2 5/7] drm/msm/dp: return correct edid checksum after corrupted edid checksum read Date: Thu, 22 Jul 2021 19:23:29 +0000 [thread overview] Message-ID: <CAE-0n539r5zQx7zX9bECspKUAypQ8VucgeMNTmqAjHOCemVmOg@mail.gmail.com> (raw) In-Reply-To: <1626191647-13901-6-git-send-email-khsieh@codeaurora.org> Quoting Kuogee Hsieh (2021-07-13 08:54:05) > diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c > index 88196f7..0fdb551 100644 > --- a/drivers/gpu/drm/msm/dp/dp_panel.c > +++ b/drivers/gpu/drm/msm/dp/dp_panel.c > @@ -303,7 +303,12 @@ void dp_panel_handle_sink_request(struct dp_panel *dp_panel) > panel = container_of(dp_panel, struct dp_panel_private, dp_panel); > > if (panel->link->sink_request & DP_TEST_LINK_EDID_READ) { > - u8 checksum = dp_panel_get_edid_checksum(dp_panel->edid); > + u8 checksum; > + > + if (dp_panel->edid) > + checksum = dp_panel_get_edid_checksum(dp_panel->edid); > + else > + checksum = dp_panel->connector->real_edid_checksum; Is there any reason why we can't use connector->real_edid_checksum all the time? > > dp_link_send_edid_checksum(panel->link, checksum); > dp_link_send_test_response(panel->link);
next prev parent reply other threads:[~2021-07-22 19:23 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-13 15:54 [PATCH v2 0/7] add fixes to pass DP Link Layer compliance test cases Kuogee Hsieh 2021-07-13 15:54 ` Kuogee Hsieh 2021-07-13 15:54 ` [PATCH v2 1/7] drm/msm/dp: use dp_ctrl_off_link_stream during PHY compliance test run Kuogee Hsieh 2021-07-13 15:54 ` Kuogee Hsieh 2021-07-22 19:01 ` Stephen Boyd 2021-07-22 19:01 ` Stephen Boyd 2021-07-13 15:54 ` [PATCH v2 2/7] drm/msm/dp: reduce link rate if failed at link training 1 Kuogee Hsieh 2021-07-13 15:54 ` Kuogee Hsieh 2021-07-22 19:05 ` Stephen Boyd 2021-07-22 19:05 ` Stephen Boyd 2021-07-13 15:54 ` [PATCH v2 3/7] drm/msm/dp: reset aux controller after dp_aux_cmd_fifo_tx() failed Kuogee Hsieh 2021-07-13 15:54 ` Kuogee Hsieh 2021-07-22 19:08 ` Stephen Boyd 2021-07-22 19:08 ` Stephen Boyd 2021-07-13 15:54 ` [PATCH v2 4/7] drm/msm/dp: replug event is converted into an unplug followed by an plug events Kuogee Hsieh 2021-07-13 15:54 ` Kuogee Hsieh 2021-07-22 19:24 ` Stephen Boyd 2021-07-22 19:24 ` Stephen Boyd 2021-07-13 15:54 ` [PATCH v2 5/7] drm/msm/dp: return correct edid checksum after corrupted edid checksum read Kuogee Hsieh 2021-07-13 15:54 ` Kuogee Hsieh 2021-07-22 19:23 ` Stephen Boyd [this message] 2021-07-22 19:23 ` Stephen Boyd 2021-07-29 16:17 ` khsieh 2021-07-29 16:17 ` khsieh 2021-07-13 15:54 ` [PATCH v2 6/7] drm/msm/dp: do not end dp link training until video is ready Kuogee Hsieh 2021-07-13 15:54 ` Kuogee Hsieh 2021-07-22 19:15 ` Stephen Boyd 2021-07-22 19:15 ` Stephen Boyd 2021-07-13 15:54 ` [PATCH v2 7/7] drm/msm/dp: retrain link when loss of symbol lock detected Kuogee Hsieh 2021-07-13 15:54 ` Kuogee Hsieh 2021-07-22 19:14 ` Stephen Boyd 2021-07-22 19:14 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAE-0n539r5zQx7zX9bECspKUAypQ8VucgeMNTmqAjHOCemVmOg@mail.gmail.com \ --to=swboyd@chromium.org \ --cc=abhinavk@codeaurora.org \ --cc=airlied@linux.ie \ --cc=aravindh@codeaurora.org \ --cc=bjorn.andersson@linaro.org \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=khsieh@codeaurora.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.