From: Amy Parker <enbyamy@gmail.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-api@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Victor Hsieh <victorhsieh@google.com>
Subject: Re: [PATCH 2/6] fs-verity: don't pass whole descriptor to fsverity_verify_signature()
Date: Wed, 27 Jan 2021 19:24:05 -0800 [thread overview]
Message-ID: <CAE1WUT7v4PTu2hEgDSpj+Y3f_Hn0XzOH3kO1-eYkOUgNun_9DA@mail.gmail.com> (raw)
In-Reply-To: <20210115181819.34732-3-ebiggers@kernel.org>
On Fri, Jan 15, 2021 at 10:22 AM Eric Biggers <ebiggers@kernel.org> wrote:
>
> From: Eric Biggers <ebiggers@google.com>
>
> Now that fsverity_get_descriptor() validates the sig_size field,
> fsverity_verify_signature() doesn't need to do it.
>
> Just change the prototype of fsverity_verify_signature() to take the
> signature directly rather than take a fsverity_descriptor.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Amy Parker <enbyamy@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Amy Parker <enbyamy@gmail.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Theodore Ts'o <tytso@mit.edu>,
linux-api@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jaegeuk Kim <jaegeuk@kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
Victor Hsieh <victorhsieh@google.com>
Subject: Re: [f2fs-dev] [PATCH 2/6] fs-verity: don't pass whole descriptor to fsverity_verify_signature()
Date: Wed, 27 Jan 2021 19:24:05 -0800 [thread overview]
Message-ID: <CAE1WUT7v4PTu2hEgDSpj+Y3f_Hn0XzOH3kO1-eYkOUgNun_9DA@mail.gmail.com> (raw)
In-Reply-To: <20210115181819.34732-3-ebiggers@kernel.org>
On Fri, Jan 15, 2021 at 10:22 AM Eric Biggers <ebiggers@kernel.org> wrote:
>
> From: Eric Biggers <ebiggers@google.com>
>
> Now that fsverity_get_descriptor() validates the sig_size field,
> fsverity_verify_signature() doesn't need to do it.
>
> Just change the prototype of fsverity_verify_signature() to take the
> signature directly rather than take a fsverity_descriptor.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Amy Parker <enbyamy@gmail.com>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-01-28 3:25 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 18:18 [PATCH 0/6] fs-verity: add an ioctl to read verity metadata Eric Biggers
2021-01-15 18:18 ` [f2fs-dev] " Eric Biggers
2021-01-15 18:18 ` [PATCH 1/6] fs-verity: factor out fsverity_get_descriptor() Eric Biggers
2021-01-15 18:18 ` [f2fs-dev] " Eric Biggers
2021-01-28 1:04 ` Jaegeuk Kim
2021-01-28 1:04 ` [f2fs-dev] " Jaegeuk Kim
2021-01-15 18:18 ` [PATCH 2/6] fs-verity: don't pass whole descriptor to fsverity_verify_signature() Eric Biggers
2021-01-15 18:18 ` [f2fs-dev] " Eric Biggers
2021-01-28 1:04 ` Jaegeuk Kim
2021-01-28 1:04 ` [f2fs-dev] " Jaegeuk Kim
2021-01-28 3:24 ` Amy Parker [this message]
2021-01-28 3:24 ` Amy Parker
2021-01-15 18:18 ` [PATCH 3/6] fs-verity: add FS_IOC_READ_VERITY_METADATA ioctl Eric Biggers
2021-01-15 18:18 ` [f2fs-dev] " Eric Biggers
2021-01-28 1:03 ` Jaegeuk Kim
2021-01-28 1:03 ` [f2fs-dev] " Jaegeuk Kim
2021-02-07 7:46 ` Chao Yu
2021-02-07 7:46 ` Chao Yu
2021-02-07 8:01 ` Eric Biggers
2021-02-07 8:01 ` [f2fs-dev] " Eric Biggers
2021-02-07 8:32 ` Chao Yu
2021-02-07 8:32 ` [f2fs-dev] " Chao Yu
2021-01-15 18:18 ` [PATCH 4/6] fs-verity: support reading Merkle tree with ioctl Eric Biggers
2021-01-15 18:18 ` [f2fs-dev] " Eric Biggers
2021-01-28 1:10 ` Jaegeuk Kim
2021-01-28 1:10 ` [f2fs-dev] " Jaegeuk Kim
2021-01-28 2:17 ` Eric Biggers
2021-01-28 2:17 ` [f2fs-dev] " Eric Biggers
2021-01-15 18:18 ` [PATCH 5/6] fs-verity: support reading descriptor " Eric Biggers
2021-01-15 18:18 ` [f2fs-dev] " Eric Biggers
2021-01-28 1:11 ` Jaegeuk Kim
2021-01-28 1:11 ` [f2fs-dev] " Jaegeuk Kim
2021-01-15 18:18 ` [PATCH 6/6] fs-verity: support reading signature " Eric Biggers
2021-01-15 18:18 ` [f2fs-dev] " Eric Biggers
2021-01-28 1:11 ` Jaegeuk Kim
2021-01-28 1:11 ` [f2fs-dev] " Jaegeuk Kim
2021-01-22 23:26 ` [PATCH 0/6] fs-verity: add an ioctl to read verity metadata Victor Hsieh
2021-01-22 23:26 ` [f2fs-dev] " Victor Hsieh via Linux-f2fs-devel
2021-01-25 18:41 ` Eric Biggers
2021-01-25 18:41 ` [f2fs-dev] " Eric Biggers
2021-02-01 17:41 ` Eric Biggers
2021-02-01 17:41 ` [f2fs-dev] " Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE1WUT7v4PTu2hEgDSpj+Y3f_Hn0XzOH3kO1-eYkOUgNun_9DA@mail.gmail.com \
--to=enbyamy@gmail.com \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=victorhsieh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.