Re: [PATCH v6] dt-bindings: imx-pata: Convert to dtschema

From: Animesh Agarwal <animeshagarwal28@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Damien Le Moal <dlemoal@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	 Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	 NXP Linux Team <linux-imx@nxp.com>,
	linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] dt-bindings: imx-pata: Convert to dtschema
Date: Mon, 11 Mar 2024 08:56:24 +0530	[thread overview]
Message-ID: <CAE3Oz81KCzFVuVeGiCvFi5jHD6gBMTLx5fHd6DO_ySz2X488og@mail.gmail.com> (raw)
In-Reply-To: <448f9d20-8b45-4794-9440-89d6a6888aee@linaro.org>

On Mon, Mar 11, 2024 at 2:00 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> What is happening with your patches? It's 3rd or 4th version the same
> day and while it was improving, this version has some weird changes.

I'll stick to 1 version in 1 day from now on.

> Why did you changed the sentence from imperative? What for? Please read
> again my comments.
Ok, I'll change it back to imperative.

> What is imx31-pata.dtsi? Where is this file?
Sorry for this, I will add the complete path now.

> These are not sentences. Please use regular imperative mood with full
> stop and capital letters.
Noted.

> patch 6 of what? There is no patch 6 here.
I wanted to say patch v6.

> "Convert foo bar to DT schema format. Add missing fsl,imx31-pata and
> fsl,imx51-pata compatibles during conversion, because they are already
> being used in existing DTS."
Got it! Adding this in the new patch now.

> Why adding this blank line? It was not here before and no one asked to
> you to change anything at this place. How it is possible to edit one
> piece of file and cause some entirely unrelated changes in other places?
> Please use an editor which you are comfortable with - which you know how
> to use.
Sorry for this too. I'll be more cautious while posting.

> The use `git add -p`, to see what you are adding to commit. DO NOT USE
> `GIT ADD FILE` or `GIT ADD .`. Almost never... Think what you are adding
> to the commit.
Noted.

Thanks for your patience and time.
Animesh