From: Ajay kumar <ajaynumb@gmail.com> To: "Andreas Färber" <afaerber@suse.de> Cc: Ajay Kumar <ajaykumar.rs@samsung.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Kukjin Kim <kgene.kim@samsung.com>, Doug Anderson <dianders@chromium.org>, sunil joshi <joshi@samsung.com>, Prashanth G <prashanth.g@samsung.com>, Thierry Reding <thierry.reding@gmail.com> Subject: Re: [PATCH 2/3] ARM: dts: Add DT changes for display on peach_pit Date: Mon, 25 Aug 2014 11:31:50 +0530 [thread overview] Message-ID: <CAEC9eQP1wAJwC6-9YMjHvA+O=4c93SJNA5YG90t2aWj4P1S6kg@mail.gmail.com> (raw) In-Reply-To: <53F86E85.3050200@suse.de> On Sat, Aug 23, 2014 at 4:05 PM, Andreas Färber <afaerber@suse.de> wrote: > Am 25.07.2014 21:44, schrieb Ajay Kumar: >> Add DT nodes for ps8622 bridge chip and panel-simple panel. > > "simple-panel" Ok. >> Add backlight power supply for pwm-backlight. >> Also add bridge phandle needed by dp to enable display on peach_pit. > > Note that peach_pi[t] is inconsistent with the file names being > peach-pi[t] here and in the two subjects. Ok. >> >> Note that, peach_pit doesn't support "chunghwa,claa101wb01" panel, >> but still we choose to reuse the binding since "chunghwa,claa101wb01" >> has similar LCD timings. >> >> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com> >> --- >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 36 +++++++++++++++------------- >> 1 file changed, 19 insertions(+), 17 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> index 228a6b1..79beba8 100644 >> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts >> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> @@ -30,11 +30,12 @@ >> i2c20 = "/spi@12d40000/cros-ec@0/i2c-tunnel"; >> }; >> >> - backlight { >> + backlight: backlight { >> compatible = "pwm-backlight"; >> pwms = <&pwm 0 1000000 0>; >> brightness-levels = <0 100 500 1000 1500 2000 2500 2800>; >> default-brightness-level = <7>; >> + power-supply = <&tps65090_fet1>; >> pinctrl-0 = <&pwm0_out>; >> pinctrl-names = "default"; >> }; >> @@ -100,6 +101,12 @@ >> regulator-boot-on; >> regulator-always-on; >> }; >> + >> + panel: panel-simple { > > Just "panel"? (AF) > >> + compatible = "chunghwa,claa101wb01", "simple-panel"; > > Drop "simple-panel" (Thierry) Right. >> + power-supply = <&tps65090_fet6>; >> + backlight = <&backlight>; >> + }; >> }; >> >> &dp { >> @@ -113,22 +120,7 @@ >> samsung,link-rate = <0x06>; >> samsung,lane-count = <2>; >> samsung,hpd-gpio = <&gpx2 6 0>; >> - >> - display-timings { >> - native-mode = <&timing1>; >> - >> - timing1: timing@1 { >> - clock-frequency = <70589280>; >> - hactive = <1366>; >> - vactive = <768>; >> - hfront-porch = <40>; >> - hback-porch = <40>; >> - hsync-len = <32>; >> - vback-porch = <10>; >> - vfront-porch = <12>; >> - vsync-len = <6>; >> - }; >> - }; >> + bridge = <&ps8625>; >> }; >> >> &fimd { >> @@ -155,6 +147,16 @@ >> pinctrl-names = "default"; >> pinctrl-0 = <&max98090_irq>; >> }; >> + >> + ps8625: ps8625-bridge@48 { > > "lvds-bridge"? (AF) Ok. I will fix all these nits and resend along with the driver patches. Ajay >> + compatible = "parade,ps8625"; >> + reg = <0x48>; >> + sleep-gpios = <&gpx3 5 0>; >> + reset-gpios = <&gpy7 7 0>; >> + lane-count = <2>; >> + panel = <&panel>; >> + backlight = <&backlight>; >> + }; >> }; >> >> &hsi2c_9 { > > Regards, > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
WARNING: multiple messages have this Message-ID (diff)
From: ajaynumb@gmail.com (Ajay kumar) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] ARM: dts: Add DT changes for display on peach_pit Date: Mon, 25 Aug 2014 11:31:50 +0530 [thread overview] Message-ID: <CAEC9eQP1wAJwC6-9YMjHvA+O=4c93SJNA5YG90t2aWj4P1S6kg@mail.gmail.com> (raw) In-Reply-To: <53F86E85.3050200@suse.de> On Sat, Aug 23, 2014 at 4:05 PM, Andreas F?rber <afaerber@suse.de> wrote: > Am 25.07.2014 21:44, schrieb Ajay Kumar: >> Add DT nodes for ps8622 bridge chip and panel-simple panel. > > "simple-panel" Ok. >> Add backlight power supply for pwm-backlight. >> Also add bridge phandle needed by dp to enable display on peach_pit. > > Note that peach_pi[t] is inconsistent with the file names being > peach-pi[t] here and in the two subjects. Ok. >> >> Note that, peach_pit doesn't support "chunghwa,claa101wb01" panel, >> but still we choose to reuse the binding since "chunghwa,claa101wb01" >> has similar LCD timings. >> >> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com> >> --- >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 36 +++++++++++++++------------- >> 1 file changed, 19 insertions(+), 17 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> index 228a6b1..79beba8 100644 >> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts >> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> @@ -30,11 +30,12 @@ >> i2c20 = "/spi at 12d40000/cros-ec at 0/i2c-tunnel"; >> }; >> >> - backlight { >> + backlight: backlight { >> compatible = "pwm-backlight"; >> pwms = <&pwm 0 1000000 0>; >> brightness-levels = <0 100 500 1000 1500 2000 2500 2800>; >> default-brightness-level = <7>; >> + power-supply = <&tps65090_fet1>; >> pinctrl-0 = <&pwm0_out>; >> pinctrl-names = "default"; >> }; >> @@ -100,6 +101,12 @@ >> regulator-boot-on; >> regulator-always-on; >> }; >> + >> + panel: panel-simple { > > Just "panel"? (AF) > >> + compatible = "chunghwa,claa101wb01", "simple-panel"; > > Drop "simple-panel" (Thierry) Right. >> + power-supply = <&tps65090_fet6>; >> + backlight = <&backlight>; >> + }; >> }; >> >> &dp { >> @@ -113,22 +120,7 @@ >> samsung,link-rate = <0x06>; >> samsung,lane-count = <2>; >> samsung,hpd-gpio = <&gpx2 6 0>; >> - >> - display-timings { >> - native-mode = <&timing1>; >> - >> - timing1: timing at 1 { >> - clock-frequency = <70589280>; >> - hactive = <1366>; >> - vactive = <768>; >> - hfront-porch = <40>; >> - hback-porch = <40>; >> - hsync-len = <32>; >> - vback-porch = <10>; >> - vfront-porch = <12>; >> - vsync-len = <6>; >> - }; >> - }; >> + bridge = <&ps8625>; >> }; >> >> &fimd { >> @@ -155,6 +147,16 @@ >> pinctrl-names = "default"; >> pinctrl-0 = <&max98090_irq>; >> }; >> + >> + ps8625: ps8625-bridge at 48 { > > "lvds-bridge"? (AF) Ok. I will fix all these nits and resend along with the driver patches. Ajay >> + compatible = "parade,ps8625"; >> + reg = <0x48>; >> + sleep-gpios = <&gpx3 5 0>; >> + reset-gpios = <&gpy7 7 0>; >> + lane-count = <2>; >> + panel = <&panel>; >> + backlight = <&backlight>; >> + }; >> }; >> >> &hsi2c_9 { > > Regards, > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
next prev parent reply other threads:[~2014-08-25 6:01 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-07-25 19:44 [PATCH 0/3] ARM: dts: Add display DT changes for snow, peach_pit and peach_pi Ajay Kumar 2014-07-25 19:44 ` Ajay Kumar 2014-07-25 19:44 ` [PATCH 1/3] ARM: dts: Add DT changes for display on snow Ajay Kumar 2014-07-25 19:44 ` Ajay Kumar 2014-08-23 10:47 ` Andreas Färber 2014-08-23 10:47 ` Andreas Färber 2014-08-25 6:08 ` Ajay kumar 2014-08-25 6:08 ` Ajay kumar 2014-07-25 19:44 ` [PATCH 2/3] ARM: dts: Add DT changes for display on peach_pit Ajay Kumar 2014-07-25 19:44 ` Ajay Kumar 2014-08-22 23:31 ` Javier Martinez Canillas 2014-08-22 23:31 ` Javier Martinez Canillas 2014-08-23 10:35 ` Andreas Färber 2014-08-23 10:35 ` Andreas Färber 2014-08-25 6:01 ` Ajay kumar [this message] 2014-08-25 6:01 ` Ajay kumar 2014-07-25 19:44 ` [PATCH 3/3] ARM: dts: Add DT changes for display on peach_pi Ajay Kumar 2014-07-25 19:44 ` Ajay Kumar 2014-08-22 23:32 ` Javier Martinez Canillas 2014-08-22 23:32 ` Javier Martinez Canillas 2014-08-23 10:29 ` Andreas Färber 2014-08-23 10:29 ` Andreas Färber 2014-08-25 6:00 ` Ajay kumar 2014-08-25 6:00 ` Ajay kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAEC9eQP1wAJwC6-9YMjHvA+O=4c93SJNA5YG90t2aWj4P1S6kg@mail.gmail.com' \ --to=ajaynumb@gmail.com \ --cc=afaerber@suse.de \ --cc=ajaykumar.rs@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=joshi@samsung.com \ --cc=kgene.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=prashanth.g@samsung.com \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.