From: Mario Kleiner <mario.kleiner.de@gmail.com>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Alex Deucher <alexander.deucher@amd.com>,
Dave Airlie <airlied@redhat.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
amd-gfx mailing list <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+
Date: Sat, 2 Jan 2021 20:40:11 +0100 [thread overview]
Message-ID: <CAEsyxyiKetNtMZboEaMGOMGiNk=r-66U=tAgi5hf7Ja6VAz0iA@mail.gmail.com> (raw)
In-Reply-To: <CAKb7UvhTtJ_w65ESmvb216Nf=YyQ7=3_HjXtoGTNP1azqVeo4A@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1266 bytes --]
On Sat, Jan 2, 2021 at 7:51 PM Ilia Mirkin <imirkin@alum.mit.edu> wrote:
> On Sat, Jan 2, 2021 at 1:35 PM Mario Kleiner <mario.kleiner.de@gmail.com>
> wrote:
> > I'm less sure about nouveau. It uses modifiers, but has atomic support
> > only on nv50+ and that atomic support is off by default -- needs a
> > nouveau.nouveau_atomic=1 boot parameter to switch it on. It seems to
> > enable modifier support unconditionally regardless if atomic or not,
> > see:
> >
> https://elixir.bootlin.com/linux/v5.11-rc1/source/drivers/gpu/drm/nouveau/nouveau_display.c#L703
> >
> > Atm. nouveau doesn't assign a new format_info though, so wouldn't
> > trigger this issue atm.
>
> Note that pre-nv50, no modifiers exist. Also,
> drm_drv_uses_atomic_modeset() doesn't care whether the client is an
> atomic client or not. It will return true for nv50+ no matter what.
> nouveau_atomic=1 affects whether atomic UAPI is exposed. Not sure if
> this impacts your discussion.
>
>
Thanks Ilia. So nouveau is fine in any case, as nv50 => modifiers and
atomic commit even if atomic UAPI is off. Also
drm_drv_uses_atomic_modeset() is the right choice, as my patch should check
if the atomic driver uses atomic commit, it doesn't care about atomic UAPI
or the client being atomic.
-mario
[-- Attachment #1.2: Type: text/html, Size: 1896 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Mario Kleiner <mario.kleiner.de@gmail.com>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Alex Deucher <alexander.deucher@amd.com>,
Dave Airlie <airlied@redhat.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
amd-gfx mailing list <amd-gfx@lists.freedesktop.org>,
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Subject: Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+
Date: Sat, 2 Jan 2021 20:40:11 +0100 [thread overview]
Message-ID: <CAEsyxyiKetNtMZboEaMGOMGiNk=r-66U=tAgi5hf7Ja6VAz0iA@mail.gmail.com> (raw)
In-Reply-To: <CAKb7UvhTtJ_w65ESmvb216Nf=YyQ7=3_HjXtoGTNP1azqVeo4A@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1266 bytes --]
On Sat, Jan 2, 2021 at 7:51 PM Ilia Mirkin <imirkin@alum.mit.edu> wrote:
> On Sat, Jan 2, 2021 at 1:35 PM Mario Kleiner <mario.kleiner.de@gmail.com>
> wrote:
> > I'm less sure about nouveau. It uses modifiers, but has atomic support
> > only on nv50+ and that atomic support is off by default -- needs a
> > nouveau.nouveau_atomic=1 boot parameter to switch it on. It seems to
> > enable modifier support unconditionally regardless if atomic or not,
> > see:
> >
> https://elixir.bootlin.com/linux/v5.11-rc1/source/drivers/gpu/drm/nouveau/nouveau_display.c#L703
> >
> > Atm. nouveau doesn't assign a new format_info though, so wouldn't
> > trigger this issue atm.
>
> Note that pre-nv50, no modifiers exist. Also,
> drm_drv_uses_atomic_modeset() doesn't care whether the client is an
> atomic client or not. It will return true for nv50+ no matter what.
> nouveau_atomic=1 affects whether atomic UAPI is exposed. Not sure if
> this impacts your discussion.
>
>
Thanks Ilia. So nouveau is fine in any case, as nv50 => modifiers and
atomic commit even if atomic UAPI is off. Also
drm_drv_uses_atomic_modeset() is the right choice, as my patch should check
if the atomic driver uses atomic commit, it doesn't care about atomic UAPI
or the client being atomic.
-mario
[-- Attachment #1.2: Type: text/html, Size: 1896 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-01-02 19:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 20:51 [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+ Mario Kleiner
2020-12-31 20:51 ` Mario Kleiner
2021-01-02 14:05 ` Bas Nieuwenhuizen
2021-01-02 14:05 ` Bas Nieuwenhuizen
2021-01-02 15:05 ` Mario Kleiner
2021-01-02 15:05 ` Mario Kleiner
2021-01-02 15:49 ` Bas Nieuwenhuizen
2021-01-02 15:49 ` Bas Nieuwenhuizen
2021-01-02 18:34 ` Mario Kleiner
2021-01-02 18:34 ` Mario Kleiner
2021-01-02 18:50 ` Ilia Mirkin
2021-01-02 18:50 ` Ilia Mirkin
2021-01-02 19:40 ` Mario Kleiner [this message]
2021-01-02 19:40 ` Mario Kleiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEsyxyiKetNtMZboEaMGOMGiNk=r-66U=tAgi5hf7Ja6VAz0iA@mail.gmail.com' \
--to=mario.kleiner.de@gmail.com \
--cc=airlied@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=imirkin@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.