All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent Legoll <vincent.legoll@gmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	Heiko Stuebner <heiko@sntech.de>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	kernel@pengutronix.de,
	Michael Riesch <michael.riesch@wolfvision.net>,
	Robin Murphy <robin.murphy@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v5 00/25] Add perf support to the rockchip-dfi driver
Date: Wed, 14 Jun 2023 19:51:21 +0000	[thread overview]
Message-ID: <CAEwRq=qufx6Y6JCD3pzA31y7mfXUxFeMLtwthE_N7rYY7k9+-A@mail.gmail.com> (raw)
In-Reply-To: <20230614152721.eep5ip726ump2kpe@mercury.elektranox.org>

Hi,

On Wed, Jun 14, 2023 at 3:27 PM Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
> On Wed, Jun 14, 2023 at 03:40:34PM +0200, Sebastian Reichel wrote:
> > I tested the series on RK3588 EVB1. The read/write byts looks
> > sensible. Sometimes cycles reads unrealistic values, though:
> >
> > 18446744070475110400      rockchip_ddr/cycles/
>
> I have seen this going off a few times with and without memory
> pressure. If it's way off, it always seems to follow the same
> pattern: The upper 32 bits are 0xffffffff instead of 0x00000000
> with the lower 32 bits containing sensible data.

How often is that happening ?

I have been running this in a loop with varying sleep duration for
the last few hours without hitting it, with and without memtester.

REPEATS=1000
MAX_DURATION=100

OUT="/tmp/perf-dfi-rk3588-${REPEATS}x${MAX_DURATION}s.txt"
echo -n > $OUT

for i in $(seq $REPEATS) ; do
  DURATION=$(shuf -i "0-${MAX_DURATION}" -n 1)
  echo -n "${DURATION} : " >> $OUT
  perf stat -a -e rockchip_ddr/cycles/ sleep $DURATION 2>&1 | awk
'/rockchip_ddr/ {printf("%X\n", int($1))}' >> $OUT
done

BTW, it's on a musl-libc arm64 void linux userspace.

-- 
Vincent Legoll

WARNING: multiple messages have this Message-ID (diff)
From: Vincent Legoll <vincent.legoll@gmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	linux-rockchip@lists.infradead.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,  linux-pm@vger.kernel.org,
	Heiko Stuebner <heiko@sntech.de>,
	 Kyungmin Park <kyungmin.park@samsung.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	 Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	kernel@pengutronix.de,
	 Michael Riesch <michael.riesch@wolfvision.net>,
	Robin Murphy <robin.murphy@arm.com>,
	 Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 devicetree@vger.kernel.org
Subject: Re: [PATCH v5 00/25] Add perf support to the rockchip-dfi driver
Date: Wed, 14 Jun 2023 19:51:21 +0000	[thread overview]
Message-ID: <CAEwRq=qufx6Y6JCD3pzA31y7mfXUxFeMLtwthE_N7rYY7k9+-A@mail.gmail.com> (raw)
In-Reply-To: <20230614152721.eep5ip726ump2kpe@mercury.elektranox.org>

Hi,

On Wed, Jun 14, 2023 at 3:27 PM Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
> On Wed, Jun 14, 2023 at 03:40:34PM +0200, Sebastian Reichel wrote:
> > I tested the series on RK3588 EVB1. The read/write byts looks
> > sensible. Sometimes cycles reads unrealistic values, though:
> >
> > 18446744070475110400      rockchip_ddr/cycles/
>
> I have seen this going off a few times with and without memory
> pressure. If it's way off, it always seems to follow the same
> pattern: The upper 32 bits are 0xffffffff instead of 0x00000000
> with the lower 32 bits containing sensible data.

How often is that happening ?

I have been running this in a loop with varying sleep duration for
the last few hours without hitting it, with and without memtester.

REPEATS=1000
MAX_DURATION=100

OUT="/tmp/perf-dfi-rk3588-${REPEATS}x${MAX_DURATION}s.txt"
echo -n > $OUT

for i in $(seq $REPEATS) ; do
  DURATION=$(shuf -i "0-${MAX_DURATION}" -n 1)
  echo -n "${DURATION} : " >> $OUT
  perf stat -a -e rockchip_ddr/cycles/ sleep $DURATION 2>&1 | awk
'/rockchip_ddr/ {printf("%X\n", int($1))}' >> $OUT
done

BTW, it's on a musl-libc arm64 void linux userspace.

-- 
Vincent Legoll

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Vincent Legoll <vincent.legoll@gmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	linux-rockchip@lists.infradead.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,  linux-pm@vger.kernel.org,
	Heiko Stuebner <heiko@sntech.de>,
	 Kyungmin Park <kyungmin.park@samsung.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	 Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	kernel@pengutronix.de,
	 Michael Riesch <michael.riesch@wolfvision.net>,
	Robin Murphy <robin.murphy@arm.com>,
	 Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 devicetree@vger.kernel.org
Subject: Re: [PATCH v5 00/25] Add perf support to the rockchip-dfi driver
Date: Wed, 14 Jun 2023 19:51:21 +0000	[thread overview]
Message-ID: <CAEwRq=qufx6Y6JCD3pzA31y7mfXUxFeMLtwthE_N7rYY7k9+-A@mail.gmail.com> (raw)
In-Reply-To: <20230614152721.eep5ip726ump2kpe@mercury.elektranox.org>

Hi,

On Wed, Jun 14, 2023 at 3:27 PM Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
> On Wed, Jun 14, 2023 at 03:40:34PM +0200, Sebastian Reichel wrote:
> > I tested the series on RK3588 EVB1. The read/write byts looks
> > sensible. Sometimes cycles reads unrealistic values, though:
> >
> > 18446744070475110400      rockchip_ddr/cycles/
>
> I have seen this going off a few times with and without memory
> pressure. If it's way off, it always seems to follow the same
> pattern: The upper 32 bits are 0xffffffff instead of 0x00000000
> with the lower 32 bits containing sensible data.

How often is that happening ?

I have been running this in a loop with varying sleep duration for
the last few hours without hitting it, with and without memtester.

REPEATS=1000
MAX_DURATION=100

OUT="/tmp/perf-dfi-rk3588-${REPEATS}x${MAX_DURATION}s.txt"
echo -n > $OUT

for i in $(seq $REPEATS) ; do
  DURATION=$(shuf -i "0-${MAX_DURATION}" -n 1)
  echo -n "${DURATION} : " >> $OUT
  perf stat -a -e rockchip_ddr/cycles/ sleep $DURATION 2>&1 | awk
'/rockchip_ddr/ {printf("%X\n", int($1))}' >> $OUT
done

BTW, it's on a musl-libc arm64 void linux userspace.

-- 
Vincent Legoll

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-06-14 19:51 UTC|newest]

Thread overview: 171+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-24  8:31 [PATCH v5 00/25] Add perf support to the rockchip-dfi driver Sascha Hauer
2023-05-24  8:31 ` Sascha Hauer
2023-05-24  8:31 ` Sascha Hauer
2023-05-24  8:31 ` [PATCH v5 01/25] PM / devfreq: rockchip-dfi: Make pmu regmap mandatory Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-13 16:21   ` Sebastian Reichel
2023-06-13 16:21     ` Sebastian Reichel
2023-06-13 16:21     ` Sebastian Reichel
2023-05-24  8:31 ` [PATCH v5 02/25] PM / devfreq: rockchip-dfi: Embed desc into private data struct Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-13 16:22   ` Sebastian Reichel
2023-06-13 16:22     ` Sebastian Reichel
2023-06-13 16:22     ` Sebastian Reichel
2023-05-24  8:31 ` [PATCH v5 03/25] PM / devfreq: rockchip-dfi: use consistent name for " Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-13 16:23   ` Sebastian Reichel
2023-06-13 16:23     ` Sebastian Reichel
2023-06-13 16:23     ` Sebastian Reichel
2023-05-24  8:31 ` [PATCH v5 04/25] PM / devfreq: rockchip-dfi: Add SoC specific init function Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-13 16:26   ` Sebastian Reichel
2023-06-13 16:26     ` Sebastian Reichel
2023-06-13 16:26     ` Sebastian Reichel
2023-05-24  8:31 ` [PATCH v5 05/25] PM / devfreq: rockchip-dfi: dfi store raw values in counter struct Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-13 16:28   ` Sebastian Reichel
2023-06-13 16:28     ` Sebastian Reichel
2023-06-13 16:28     ` Sebastian Reichel
2023-05-24  8:31 ` [PATCH v5 06/25] PM / devfreq: rockchip-dfi: Use free running counter Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-13 16:32   ` Sebastian Reichel
2023-06-13 16:32     ` Sebastian Reichel
2023-06-13 16:32     ` Sebastian Reichel
2023-05-24  8:31 ` [PATCH v5 07/25] PM / devfreq: rockchip-dfi: introduce channel mask Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-13 16:34   ` Sebastian Reichel
2023-06-13 16:34     ` Sebastian Reichel
2023-06-13 16:34     ` Sebastian Reichel
2023-05-24  8:31 ` [PATCH v5 08/25] PM / devfreq: rk3399_dmc,dfi: generalize DDRTYPE defines Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-13 16:39   ` Sebastian Reichel
2023-06-13 16:39     ` Sebastian Reichel
2023-06-13 16:39     ` Sebastian Reichel
2023-05-24  8:31 ` [PATCH v5 09/25] PM / devfreq: rockchip-dfi: Clean up DDR type register defines Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-13 16:46   ` Sebastian Reichel
2023-06-13 16:46     ` Sebastian Reichel
2023-06-13 16:46     ` Sebastian Reichel
2023-05-24  8:31 ` [PATCH v5 10/25] PM / devfreq: rockchip-dfi: Add RK3568 support Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31 ` [PATCH v5 11/25] PM / devfreq: rockchip-dfi: Handle LPDDR2 correctly Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-13 16:47   ` Sebastian Reichel
2023-06-13 16:47     ` Sebastian Reichel
2023-06-13 16:47     ` Sebastian Reichel
2023-05-24  8:31 ` [PATCH v5 12/25] PM / devfreq: rockchip-dfi: Handle LPDDR4X Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-13 16:48   ` Sebastian Reichel
2023-06-13 16:48     ` Sebastian Reichel
2023-06-13 16:48     ` Sebastian Reichel
2023-05-24  8:31 ` [PATCH v5 13/25] PM / devfreq: rockchip-dfi: Pass private data struct to internal functions Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-13 17:08   ` Sebastian Reichel
2023-06-13 17:08     ` Sebastian Reichel
2023-06-13 17:08     ` Sebastian Reichel
2023-05-24  8:31 ` [PATCH v5 14/25] PM / devfreq: rockchip-dfi: Prepare for multiple users Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-13 17:15   ` Sebastian Reichel
2023-06-13 17:15     ` Sebastian Reichel
2023-06-13 17:15     ` Sebastian Reichel
2023-05-24  8:31 ` [PATCH v5 15/25] PM / devfreq: rockchip-dfi: give variable a better name Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-13 17:16   ` Sebastian Reichel
2023-06-13 17:16     ` Sebastian Reichel
2023-06-13 17:16     ` Sebastian Reichel
2023-05-24  8:31 ` [PATCH v5 16/25] PM / devfreq: rockchip-dfi: Add perf support Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-14 13:29   ` Sebastian Reichel
2023-06-14 13:29     ` Sebastian Reichel
2023-06-14 13:29     ` Sebastian Reichel
2023-06-15 13:13   ` Sascha Hauer
2023-06-15 13:13     ` Sascha Hauer
2023-06-15 13:13     ` Sascha Hauer
2023-05-24  8:31 ` [PATCH v5 17/25] PM / devfreq: rockchip-dfi: make register stride SoC specific Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-13 17:17   ` Sebastian Reichel
2023-06-13 17:17     ` Sebastian Reichel
2023-06-13 17:17     ` Sebastian Reichel
2023-05-24  8:31 ` [PATCH v5 18/25] PM / devfreq: rockchip-dfi: account for multiple DDRMON_CTRL registers Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-13 17:24   ` Sebastian Reichel
2023-06-13 17:24     ` Sebastian Reichel
2023-06-13 17:24     ` Sebastian Reichel
2023-05-24  8:31 ` [PATCH v5 19/25] PM / devfreq: rockchip-dfi: add support for RK3588 Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-13 16:16   ` Sebastian Reichel
2023-06-13 16:16     ` Sebastian Reichel
2023-06-13 16:16     ` Sebastian Reichel
2023-05-24  8:31 ` [PATCH v5 20/25] dt-bindings: devfreq: event: convert Rockchip DFI binding to yaml Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-13 23:39   ` Sebastian Reichel
2023-06-13 23:39     ` Sebastian Reichel
2023-06-13 23:39     ` Sebastian Reichel
2023-05-24  8:31 ` [PATCH v5 21/25] dt-bindings: devfreq: event: rockchip,dfi: Add rk3568 support Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24 19:42   ` Conor Dooley
2023-05-24 19:42     ` Conor Dooley
2023-05-24 19:42     ` Conor Dooley
2023-05-24  8:31 ` [PATCH v5 22/25] dt-bindings: devfreq: event: rockchip,dfi: Add rk3588 support Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24 19:37   ` Conor Dooley
2023-05-24 19:37     ` Conor Dooley
2023-05-24 19:37     ` Conor Dooley
2023-06-08 20:07   ` Rob Herring
2023-06-08 20:07     ` Rob Herring
2023-06-08 20:07     ` Rob Herring
2023-05-24  8:31 ` [PATCH v5 23/25] arm64: dts: rockchip: rk3399: Enable DFI Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31 ` [PATCH v5 24/25] arm64: dts: rockchip: rk356x: Add DFI Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31 ` [PATCH v5 25/25] arm64: dts: rockchip: rk3588s: " Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-05-24  8:31   ` Sascha Hauer
2023-06-13 16:19   ` Sebastian Reichel
2023-06-13 16:19     ` Sebastian Reichel
2023-06-13 16:19     ` Sebastian Reichel
2023-06-14 13:40 ` [PATCH v5 00/25] Add perf support to the rockchip-dfi driver Sebastian Reichel
2023-06-14 13:40   ` Sebastian Reichel
2023-06-14 13:40   ` Sebastian Reichel
2023-06-14 14:19   ` Vincent Legoll
2023-06-14 14:19     ` Vincent Legoll
2023-06-14 14:19     ` Vincent Legoll
2023-06-14 15:27   ` Sebastian Reichel
2023-06-14 15:27     ` Sebastian Reichel
2023-06-14 15:27     ` Sebastian Reichel
2023-06-14 19:51     ` Vincent Legoll [this message]
2023-06-14 19:51       ` Vincent Legoll
2023-06-14 19:51       ` Vincent Legoll
2023-06-14 22:18       ` Sebastian Reichel
2023-06-14 22:18         ` Sebastian Reichel
2023-06-14 22:18         ` Sebastian Reichel
2023-06-15  6:56   ` Sascha Hauer
2023-06-15  6:56     ` Sascha Hauer
2023-06-15  6:56     ` Sascha Hauer
2023-06-15 13:27   ` Sascha Hauer
2023-06-15 13:27     ` Sascha Hauer
2023-06-15 13:27     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEwRq=qufx6Y6JCD3pzA31y7mfXUxFeMLtwthE_N7rYY7k9+-A@mail.gmail.com' \
    --to=vincent.legoll@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=michael.riesch@wolfvision.net \
    --cc=myungjoo.ham@samsung.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sebastian.reichel@collabora.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.