Re: [PATCHv3 5/5] ARM: sunxi: dts: Add note ps2 pins conflict with hdmi

From: Vishnu Patekar <vishnupatekar0510@gmail.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Hans De Goede <hdegoede@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree <devicetree@vger.kernel.org>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
	"msalter@redhat.com" <msalter@redhat.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"ralf@linux-mips.org" <ralf@linux-mips.org>,
	Rob Herring <robh+dt@kernel.org>,
	"jdelvare@suse.de" <jdelvare@suse.de>,
	Kumar Gala <galak@codeaurora.org>,
	Grant Likely <grant.likely@linaro.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCHv3 5/5] ARM: sunxi: dts: Add note ps2 pins conflict with hdmi
Date: Sat, 13 Dec 2014 08:48:13 +0530	[thread overview]
Message-ID: <CAEzqOZtOycU5LT8b3SHOymMpMOMExGC9PHiZ9wHtAjxR2R5+Ew@mail.gmail.com> (raw)
In-Reply-To: <CAGb2v65xpUhiMzSKu_1+JGNbg3oFdpw2EQ+JGUYkivCtG2O6gw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1924 bytes --]

Hello Chen-Yu,
Thank you for pointing out styling error.

On Sat, Dec 13, 2014 at 7:36 AM, Chen-Yu Tsai <wens@csie.org> wrote:
>
> Hi,
>
> On Sat, Dec 13, 2014 at 2:25 AM, VishnuPatekar
> <vishnupatekar0510@gmail.com> wrote:
> > 1. Please note that ps20 pins conflict with HDMI on Lime2 Board
> > so, by deault ps20 and ps21 are disabled for Lime2 Board.
> > There is no on board ps2 connector and these pins can be used
> > for different purpose.
> >
> > Signed-off-by: VishnuPatekar <vishnupatekar0510@gmail.com>
> > ---
> >  arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts |    6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> > index ed364d5..951b615 100644
> > --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> > +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> > @@ -112,7 +112,11 @@
> >                         pinctrl-0 = <&uart0_pins_a>;
> >                         status = "okay";
> >                 };
> > -
> > +
> > +               /* PS2 0 and PS2 1 are disabled by default; Please note
> that
> > +               ps20 pins conflict with HDMI on Lime2 Board
> > +               */
> > +
>
> Multi-line comments should be:
>
> /*
>  * line 1
>  * line 2
>  * ...
>  */
>
Okie.

>
> And why is there a delete and insert for an empty line?
> Weird... though git seems to ignore it when applying.
>
I used clean_patch to clear the styling error. that might have modified it.

>
> ChenYu
>
> >                 i2c0: i2c@01c2ac00 {
> >                         pinctrl-names = "default";
> >                         pinctrl-0 = <&i2c0_pins_a>;
> > --
> > 1.7.9.5
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

[-- Attachment #2: Type: text/html, Size: 3194 bytes --]