From: Maxime Ripard <maxime.ripard@free-electrons.com> To: VishnuPatekar <vishnupatekar0510@gmail.com> Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com, hdegoede@redhat.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, grant.likely@linaro.org, benh@kernel.crashing.org, msalter@redhat.com, ralf@linux-mips.org, jdelvare@suse.de Subject: Re: [PATCHv3 3/5] ARM: sunxi: dts: Add PS2 nodes to dtsi for A10 and A20 Date: Tue, 16 Dec 2014 10:32:41 +0100 [thread overview] Message-ID: <20141216093241.GN4337@lukather> (raw) In-Reply-To: <1418408748-9797-4-git-send-email-vishnupatekar0510@gmail.com> [-- Attachment #1: Type: text/plain, Size: 2215 bytes --] Hi Vishnu, On Fri, Dec 12, 2014 at 11:55:46PM +0530, VishnuPatekar wrote: > 1) Fixup the sun4i ps/2 nodes interrupt property, sun4i interrupts take > only 1 specifier > > 2) dt bindings should use the compat string for the earliest version of the > hardware which has the relevant hardware block, unless there are differences, > the A10 and A20 ps2 controllers are identical, so for both sun4i-a10-ps2 > should be used as compat string, update the sun7i.dtsi ps2 entries to > use the sun4i-a10-ps2 compat string. This shouldn't be a changelog, but what this patch actually does. > Signed-off-by: VishnuPatekar <vishnupatekar0510@gmail.com> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > arch/arm/boot/dts/sun4i-a10.dtsi | 17 +++++++++++++++++ > arch/arm/boot/dts/sun7i-a20.dtsi | 18 ++++++++++++++++++ > 2 files changed, 35 insertions(+) > > diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi > index 7b4099f..ef9a01c 100644 > --- a/arch/arm/boot/dts/sun4i-a10.dtsi > +++ b/arch/arm/boot/dts/sun4i-a10.dtsi > @@ -629,6 +629,7 @@ > allwinner,drive = <0>; > allwinner,pull = <0>; > }; > + This is an uneeded change > }; > > timer@01c20c00 { > @@ -795,5 +796,21 @@ > #address-cells = <1>; > #size-cells = <0>; > }; > + > + ps20: ps2@01c2a000 { > + compatible = "allwinner,sun4i-a10-ps2"; > + reg = <0x01c2a000 0x400>; > + interrupts = <62>; > + clocks = <&apb1_gates 6>; > + status = "disabled"; > + }; > + > + ps21: ps2@01c2a400 { > + compatible = "allwinner,sun4i-a10-ps2"; > + reg = <0x01c2a400 0x400>; > + interrupts = <63>; > + clocks = <&apb1_gates 7>; > + status = "disabled"; > + }; > }; > }; > diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi > index e21ce59..6ab7714 100644 > --- a/arch/arm/boot/dts/sun7i-a20.dtsi > +++ b/arch/arm/boot/dts/sun7i-a20.dtsi > @@ -866,6 +866,7 @@ > allwinner,drive = <0>; > allwinner,pull = <0>; > }; > + Ditto. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard) To: linux-arm-kernel@lists.infradead.org Subject: [PATCHv3 3/5] ARM: sunxi: dts: Add PS2 nodes to dtsi for A10 and A20 Date: Tue, 16 Dec 2014 10:32:41 +0100 [thread overview] Message-ID: <20141216093241.GN4337@lukather> (raw) In-Reply-To: <1418408748-9797-4-git-send-email-vishnupatekar0510@gmail.com> Hi Vishnu, On Fri, Dec 12, 2014 at 11:55:46PM +0530, VishnuPatekar wrote: > 1) Fixup the sun4i ps/2 nodes interrupt property, sun4i interrupts take > only 1 specifier > > 2) dt bindings should use the compat string for the earliest version of the > hardware which has the relevant hardware block, unless there are differences, > the A10 and A20 ps2 controllers are identical, so for both sun4i-a10-ps2 > should be used as compat string, update the sun7i.dtsi ps2 entries to > use the sun4i-a10-ps2 compat string. This shouldn't be a changelog, but what this patch actually does. > Signed-off-by: VishnuPatekar <vishnupatekar0510@gmail.com> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > arch/arm/boot/dts/sun4i-a10.dtsi | 17 +++++++++++++++++ > arch/arm/boot/dts/sun7i-a20.dtsi | 18 ++++++++++++++++++ > 2 files changed, 35 insertions(+) > > diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi > index 7b4099f..ef9a01c 100644 > --- a/arch/arm/boot/dts/sun4i-a10.dtsi > +++ b/arch/arm/boot/dts/sun4i-a10.dtsi > @@ -629,6 +629,7 @@ > allwinner,drive = <0>; > allwinner,pull = <0>; > }; > + This is an uneeded change > }; > > timer at 01c20c00 { > @@ -795,5 +796,21 @@ > #address-cells = <1>; > #size-cells = <0>; > }; > + > + ps20: ps2 at 01c2a000 { > + compatible = "allwinner,sun4i-a10-ps2"; > + reg = <0x01c2a000 0x400>; > + interrupts = <62>; > + clocks = <&apb1_gates 6>; > + status = "disabled"; > + }; > + > + ps21: ps2 at 01c2a400 { > + compatible = "allwinner,sun4i-a10-ps2"; > + reg = <0x01c2a400 0x400>; > + interrupts = <63>; > + clocks = <&apb1_gates 7>; > + status = "disabled"; > + }; > }; > }; > diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi > index e21ce59..6ab7714 100644 > --- a/arch/arm/boot/dts/sun7i-a20.dtsi > +++ b/arch/arm/boot/dts/sun7i-a20.dtsi > @@ -866,6 +866,7 @@ > allwinner,drive = <0>; > allwinner,pull = <0>; > }; > + Ditto. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141216/71c6a958/attachment.sig>
next prev parent reply other threads:[~2014-12-16 9:35 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-12-12 18:25 [PATCHv3 0/5] ARM:sunxi:ps2 Added support for A10/A20 ps2 controller VishnuPatekar 2014-12-12 18:25 ` VishnuPatekar 2014-12-12 18:25 ` [PATCHv3 1/5] sunxi:dts-bindings:input:ps2 bindings for A10/A20 ps2 VishnuPatekar 2014-12-12 18:25 ` VishnuPatekar 2014-12-12 18:25 ` [PATCHv3 2/5] ARM:sunxi:drivers:input Add support for A10/A20 PS2 VishnuPatekar 2014-12-12 18:25 ` VishnuPatekar 2014-12-14 20:37 ` Dmitry Torokhov 2014-12-14 20:37 ` Dmitry Torokhov 2014-12-23 22:28 ` Vishnu Patekar 2014-12-23 22:28 ` Vishnu Patekar 2014-12-23 22:28 ` Vishnu Patekar 2014-12-12 18:25 ` [PATCHv3 3/5] ARM: sunxi: dts: Add PS2 nodes to dtsi for A10 and A20 VishnuPatekar 2014-12-12 18:25 ` VishnuPatekar 2014-12-16 9:32 ` Maxime Ripard [this message] 2014-12-16 9:32 ` Maxime Ripard 2014-12-12 18:25 ` [PATCHv3 4/5] ARM: sunxi: dts: Add A10/A20 PS2 pin muxing options VishnuPatekar 2014-12-12 18:25 ` VishnuPatekar 2014-12-12 18:25 ` [PATCHv3 5/5] ARM: sunxi: dts: Add note ps2 pins conflict with hdmi VishnuPatekar 2014-12-12 18:25 ` VishnuPatekar 2014-12-13 2:06 ` Chen-Yu Tsai 2014-12-13 2:06 ` Chen-Yu Tsai 2014-12-13 3:18 ` Vishnu Patekar 2014-12-16 15:21 ` Chen-Yu Tsai 2014-12-16 15:21 ` Chen-Yu Tsai 2014-12-16 15:21 ` Chen-Yu Tsai 2014-12-13 11:09 ` [PATCHv3 0/5] ARM:sunxi:ps2 Added support for A10/A20 ps2 controller Hans de Goede 2014-12-13 11:09 ` Hans de Goede 2014-12-13 20:01 ` Vishnu Patekar 2014-12-13 20:01 ` Vishnu Patekar 2014-12-13 20:01 ` Vishnu Patekar 2014-12-14 9:01 ` Hans de Goede 2014-12-14 9:01 ` Hans de Goede 2014-12-15 14:13 ` Vishnu Patekar 2014-12-15 14:13 ` Vishnu Patekar 2014-12-15 14:13 ` Vishnu Patekar 2014-12-15 15:13 ` Hans de Goede 2014-12-15 15:13 ` Hans de Goede 2014-12-15 15:13 ` Hans de Goede 2014-12-15 15:41 ` Chen-Yu Tsai 2014-12-15 15:41 ` Chen-Yu Tsai 2014-12-15 15:41 ` Chen-Yu Tsai 2014-12-22 3:30 ` Vishnu Patekar 2014-12-22 3:30 ` Vishnu Patekar 2014-12-22 3:30 ` Vishnu Patekar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20141216093241.GN4337@lukather \ --to=maxime.ripard@free-electrons.com \ --cc=benh@kernel.crashing.org \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.torokhov@gmail.com \ --cc=galak@codeaurora.org \ --cc=grant.likely@linaro.org \ --cc=hdegoede@redhat.com \ --cc=ijc+devicetree@hellion.org.uk \ --cc=jdelvare@suse.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=mark.rutland@arm.com \ --cc=msalter@redhat.com \ --cc=pawel.moll@arm.com \ --cc=ralf@linux-mips.org \ --cc=robh+dt@kernel.org \ --cc=vishnupatekar0510@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.