From: Rob Clark <robdclark@gmail.com> To: Jeffrey Hugo <jeffrey.l.hugo@gmail.com> Cc: Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Bjorn Andersson <bjorn.andersson@linaro.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, freedreno <freedreno@lists.freedesktop.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] drm/msm: Transition console to msm framebuffer Date: Sat, 29 Jun 2019 10:46:20 -0700 [thread overview] Message-ID: <CAF6AEGuLvgfWYdGm-0caGbWcvzt7raCWkz_sBCxFKV99YQZmeg@mail.gmail.com> (raw) In-Reply-To: <20190628162831.20645-1-jeffrey.l.hugo@gmail.com> On Fri, Jun 28, 2019 at 9:28 AM Jeffrey Hugo <jeffrey.l.hugo@gmail.com> wrote: > > If booting a device using EFI, efifb will likely come up and claim the > console. When the msm display stack finally comes up, we want the > console to move over to the msm fb, so add support to kick out any > firmware based framebuffers to accomplish the console transition. > > Suggested-by: Rob Clark <robdclark@gmail.com> > Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com> lgtm, Reviewed-by: Rob Clark <robdclark@gmail.com> > --- > drivers/gpu/drm/msm/msm_fbdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c > index 2429d5e6ce9f..e3836c7725a6 100644 > --- a/drivers/gpu/drm/msm/msm_fbdev.c > +++ b/drivers/gpu/drm/msm/msm_fbdev.c > @@ -169,6 +169,9 @@ struct drm_fb_helper *msm_fbdev_init(struct drm_device *dev) > if (ret) > goto fini; > > + /* the fw fb could be anywhere in memory */ > + drm_fb_helper_remove_conflicting_framebuffers(NULL, "msm", false); > + > ret = drm_fb_helper_initial_config(helper, 32); > if (ret) > goto fini; > -- > 2.17.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Clark <robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Jeffrey Hugo <jeffrey.l.hugo-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: freedreno <freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>, David Airlie <airlied-cv59FeDIM0c@public.gmane.org>, linux-arm-msm <linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux Kernel Mailing List <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, dri-devel <dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>, Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>, Sean Paul <sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org> Subject: Re: [PATCH] drm/msm: Transition console to msm framebuffer Date: Sat, 29 Jun 2019 10:46:20 -0700 [thread overview] Message-ID: <CAF6AEGuLvgfWYdGm-0caGbWcvzt7raCWkz_sBCxFKV99YQZmeg@mail.gmail.com> (raw) In-Reply-To: <20190628162831.20645-1-jeffrey.l.hugo-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> On Fri, Jun 28, 2019 at 9:28 AM Jeffrey Hugo <jeffrey.l.hugo@gmail.com> wrote: > > If booting a device using EFI, efifb will likely come up and claim the > console. When the msm display stack finally comes up, we want the > console to move over to the msm fb, so add support to kick out any > firmware based framebuffers to accomplish the console transition. > > Suggested-by: Rob Clark <robdclark@gmail.com> > Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com> lgtm, Reviewed-by: Rob Clark <robdclark@gmail.com> > --- > drivers/gpu/drm/msm/msm_fbdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c > index 2429d5e6ce9f..e3836c7725a6 100644 > --- a/drivers/gpu/drm/msm/msm_fbdev.c > +++ b/drivers/gpu/drm/msm/msm_fbdev.c > @@ -169,6 +169,9 @@ struct drm_fb_helper *msm_fbdev_init(struct drm_device *dev) > if (ret) > goto fini; > > + /* the fw fb could be anywhere in memory */ > + drm_fb_helper_remove_conflicting_framebuffers(NULL, "msm", false); > + > ret = drm_fb_helper_initial_config(helper, 32); > if (ret) > goto fini; > -- > 2.17.1 > _______________________________________________ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno
next prev parent reply other threads:[~2019-06-29 17:46 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-28 16:28 [PATCH] drm/msm: Transition console to msm framebuffer Jeffrey Hugo 2019-06-29 17:46 ` Rob Clark [this message] 2019-06-29 17:46 ` Rob Clark 2019-06-29 19:55 ` Rob Clark 2019-06-29 19:55 ` Rob Clark
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAF6AEGuLvgfWYdGm-0caGbWcvzt7raCWkz_sBCxFKV99YQZmeg@mail.gmail.com \ --to=robdclark@gmail.com \ --cc=airlied@linux.ie \ --cc=bjorn.andersson@linaro.org \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=jeffrey.l.hugo@gmail.com \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.