Re: [patch v2] drm/msm/dsi: free first element on error

From: Rob Clark <robdclark@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Archit Taneja <architt@codeaurora.org>,
	David Airlie <airlied@linux.ie>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Hai Li <hali@codeaurora.org>, Rob Herring <robh@kernel.org>,
	Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	freedreno@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] drm/msm/dsi: free first element on error
Date: Thu, 16 Feb 2017 07:16:27 -0500	[thread overview]
Message-ID: <CAF6AEGuaYjRQCpLxade_Htm6tS8Zvy6JQG8dRt973C-aaPCP5g@mail.gmail.com> (raw)
In-Reply-To: <20170216120028.GA29698@mwanda>

On Thu, Feb 16, 2017 at 7:00 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We're off by one here.  We free something that wasn't allocated and we
> don't free msm_host->bus_clks[].
>
> Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks

Reviewed-by: Rob Clark <robdclark@gmail.com>

>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index 1fc07ce24686..4fa32296162e 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -437,7 +437,7 @@ static int dsi_bus_clk_enable(struct msm_dsi_host *msm_host)
>
>         return 0;
>  err:
> -       for (; i > 0; i--)
> +       while (i--)
>                 clk_disable_unprepare(msm_host->bus_clks[i]);
>
>         return ret;