Re: [PATCH v3 2/2] spi: meson-spicc: Use pinctrl to drive CLK line when idle

From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Amjad Ouled-Ameur <aouledameur@baylibre.com>
Cc: Mark Brown <broonie@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>, Da Xue <da@libre.computer>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] spi: meson-spicc: Use pinctrl to drive CLK line when idle
Date: Wed, 19 Oct 2022 22:50:29 +0200	[thread overview]
Message-ID: <CAFBinCAsCg6QQRH3VPY1OKuyfkxY0oCXLhAuMwO6=00gXKqQrQ@mail.gmail.com> (raw)
In-Reply-To: <20221004-up-aml-fix-spi-v3-2-89de126fd163@baylibre.com>

Hi Amjad,

On Wed, Oct 19, 2022 at 4:03 PM Amjad Ouled-Ameur
<aouledameur@baylibre.com> wrote:
[...]
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> index c3ac531c4f84..04e9d0f1bde0 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> @@ -429,6 +429,20 @@ mux {
>                         };
>                 };
>
> +               spi_idle_high_pins: spi-idle-high-pins {
> +                       mux {
> +                               groups = "spi_sclk";
> +                               bias-pull-up;
> +                       };
> +               };
> +
> +               spi_idle_low_pins: spi-idle-low-pins {
> +                       mux {
> +                               groups = "spi_sclk";
> +                               bias-pull-down;
> +                       };
> +               };
> +
We typically have the .dts{,i} changes in a separate patch. I suggest
doing the same here.
I also have two questions about this part:
- why are these not referenced by the SPICC controller node?
- is there a particular reason why meson-gxl.dtsi is updated but
meson-gxbb.dtsi is not? (my understanding is that GXBB is also lacking
hardware OEN support)

Best regards,
Martin