From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Xingyu Chen <xingyu.chen@amlogic.com>, Rob Herring <robh+dt@kernel.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Kevin Hilman <khilman@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Qianggui Song <qianggui.song@amlogic.com>,
devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org,
Jianxin Pan <jianxin.pan@amlogic.com>,
linux-kernel@vger.kernel.org, Jian Hu <jian.hu@amlogic.com>,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v5 2/4] dt-bindings: watchdog: add new binding for meson secure watchdog
Date: Thu, 12 Dec 2019 21:05:34 +0100 [thread overview]
Message-ID: <CAFBinCBHLqgPExPsVaSWdSOr0Oj-jeYa4Z82U-pJ=fS+D1wGnA@mail.gmail.com> (raw)
In-Reply-To: <1576153187-28378-3-git-send-email-xingyu.chen@amlogic.com>
Hi Xingyu and Rob,
On Thu, Dec 12, 2019 at 1:20 PM Xingyu Chen <xingyu.chen@amlogic.com> wrote:
[...]
> +examples:
> + - |
> + watchdog {
> + compatible = "amlogic,meson-sec-wdt";
> + timeout-sec = <60>;
> + };
in v3 of this patch Rob commented that there shouldn't be an OF node
if there are no additional properties
with timeout-sec there's now an additional property so my
understanding is that it's fine to have an OF node
what I don't understand yet is where this node should be placed.
is it supposed to be a child node of the secure monitor node (for
which we already have a binding here:
Documentation/devicetree/bindings/firmware/meson/meson_sm.txt) or
where else would we place it inside the .dts?
Martin
[0] https://patchwork.kernel.org/patch/11211399/
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Xingyu Chen <xingyu.chen@amlogic.com>, Rob Herring <robh+dt@kernel.org>
Cc: Qianggui Song <qianggui.song@amlogic.com>,
devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org,
Jianxin Pan <jianxin.pan@amlogic.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
linux-kernel@vger.kernel.org, Jian Hu <jian.hu@amlogic.com>,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v5 2/4] dt-bindings: watchdog: add new binding for meson secure watchdog
Date: Thu, 12 Dec 2019 21:05:34 +0100 [thread overview]
Message-ID: <CAFBinCBHLqgPExPsVaSWdSOr0Oj-jeYa4Z82U-pJ=fS+D1wGnA@mail.gmail.com> (raw)
In-Reply-To: <1576153187-28378-3-git-send-email-xingyu.chen@amlogic.com>
Hi Xingyu and Rob,
On Thu, Dec 12, 2019 at 1:20 PM Xingyu Chen <xingyu.chen@amlogic.com> wrote:
[...]
> +examples:
> + - |
> + watchdog {
> + compatible = "amlogic,meson-sec-wdt";
> + timeout-sec = <60>;
> + };
in v3 of this patch Rob commented that there shouldn't be an OF node
if there are no additional properties
with timeout-sec there's now an additional property so my
understanding is that it's fine to have an OF node
what I don't understand yet is where this node should be placed.
is it supposed to be a child node of the secure monitor node (for
which we already have a binding here:
Documentation/devicetree/bindings/firmware/meson/meson_sm.txt) or
where else would we place it inside the .dts?
Martin
[0] https://patchwork.kernel.org/patch/11211399/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Xingyu Chen <xingyu.chen@amlogic.com>, Rob Herring <robh+dt@kernel.org>
Cc: Qianggui Song <qianggui.song@amlogic.com>,
devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org,
Jianxin Pan <jianxin.pan@amlogic.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
linux-kernel@vger.kernel.org, Jian Hu <jian.hu@amlogic.com>,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v5 2/4] dt-bindings: watchdog: add new binding for meson secure watchdog
Date: Thu, 12 Dec 2019 21:05:34 +0100 [thread overview]
Message-ID: <CAFBinCBHLqgPExPsVaSWdSOr0Oj-jeYa4Z82U-pJ=fS+D1wGnA@mail.gmail.com> (raw)
In-Reply-To: <1576153187-28378-3-git-send-email-xingyu.chen@amlogic.com>
Hi Xingyu and Rob,
On Thu, Dec 12, 2019 at 1:20 PM Xingyu Chen <xingyu.chen@amlogic.com> wrote:
[...]
> +examples:
> + - |
> + watchdog {
> + compatible = "amlogic,meson-sec-wdt";
> + timeout-sec = <60>;
> + };
in v3 of this patch Rob commented that there shouldn't be an OF node
if there are no additional properties
with timeout-sec there's now an additional property so my
understanding is that it's fine to have an OF node
what I don't understand yet is where this node should be placed.
is it supposed to be a child node of the secure monitor node (for
which we already have a binding here:
Documentation/devicetree/bindings/firmware/meson/meson_sm.txt) or
where else would we place it inside the .dts?
Martin
[0] https://patchwork.kernel.org/patch/11211399/
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-12-12 20:05 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 12:19 [PATCH v5 0/4] add meson secure watchdog driver Xingyu Chen
2019-12-12 12:19 ` Xingyu Chen
2019-12-12 12:19 ` Xingyu Chen
2019-12-12 12:19 ` [PATCH v5 1/4] firmware: meson_sm: add new SMC ID support for accessing secure watchdog Xingyu Chen
2019-12-12 12:19 ` Xingyu Chen
2019-12-12 12:19 ` Xingyu Chen
2019-12-12 12:19 ` [PATCH v5 2/4] dt-bindings: watchdog: add new binding for meson " Xingyu Chen
2019-12-12 12:19 ` Xingyu Chen
2019-12-12 12:19 ` Xingyu Chen
2019-12-12 20:05 ` Martin Blumenstingl [this message]
2019-12-12 20:05 ` Martin Blumenstingl
2019-12-12 20:05 ` Martin Blumenstingl
2019-12-16 6:03 ` Xingyu Chen
2019-12-16 6:03 ` Xingyu Chen
2019-12-16 6:03 ` Xingyu Chen
2019-12-16 13:30 ` Guenter Roeck
2019-12-16 13:30 ` Guenter Roeck
2019-12-16 13:30 ` Guenter Roeck
2019-12-18 7:37 ` Xingyu Chen
2019-12-18 7:37 ` Xingyu Chen
2019-12-18 7:37 ` Xingyu Chen
2019-12-18 20:34 ` Rob Herring
2019-12-18 20:34 ` Rob Herring
2019-12-18 20:34 ` Rob Herring
2019-12-19 2:51 ` Xingyu Chen
2019-12-19 2:51 ` Xingyu Chen
2019-12-19 2:51 ` Xingyu Chen
2019-12-12 12:19 ` [PATCH v5 3/4] watchdog: add meson secure watchdog driver Xingyu Chen
2019-12-12 12:19 ` Xingyu Chen
2019-12-12 12:19 ` Xingyu Chen
2019-12-15 4:07 ` Guenter Roeck
2019-12-15 4:07 ` Guenter Roeck
2019-12-15 4:07 ` Guenter Roeck
2019-12-12 12:19 ` [PATCH v5 4/4] arm64: dts: a1: add secure watchdog controller Xingyu Chen
2019-12-12 12:19 ` Xingyu Chen
2019-12-12 12:19 ` Xingyu Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFBinCBHLqgPExPsVaSWdSOr0Oj-jeYa4Z82U-pJ=fS+D1wGnA@mail.gmail.com' \
--to=martin.blumenstingl@googlemail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jian.hu@amlogic.com \
--cc=jianxin.pan@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=narmstrong@baylibre.com \
--cc=qianggui.song@amlogic.com \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=xingyu.chen@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.